Per PR discussion
- clean up "the the" in XML comments - simplify refactoring VS did when I renamed `GetHtmlHelperForViewData()` - fix existing issue in `HtmlHelperCheckboxTest.CheckBoxReplacesUnderscoresInHtmlAttributesWithDashes()` (was using a `HtmlHelper<ViewDataDictionary<TestModel>>`)
This commit is contained in:
parent
1d3ae83507
commit
7e8870cb9f
|
|
@ -616,8 +616,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Renders a <form> start tag to the response. When the user submits the form, the
|
/// Renders a <form> start tag to the response. When the user submits the form, the action with name
|
||||||
/// the action with name <paramref name="actionName"/> will process the request.
|
/// <paramref name="actionName"/> will process the request.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="actionName">The name of the action method.</param>
|
/// <param name="actionName">The name of the action method.</param>
|
||||||
/// <param name="controllerName">The name of the controller.</param>
|
/// <param name="controllerName">The name of the controller.</param>
|
||||||
|
|
|
||||||
|
|
@ -82,8 +82,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
|
||||||
HtmlString AntiForgeryToken();
|
HtmlString AntiForgeryToken();
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Renders a <form> start tag to the response. When the user submits the form, the
|
/// Renders a <form> start tag to the response. When the user submits the form, the action with name
|
||||||
/// the action with name <paramref name="actionName"/> will process the request.
|
/// <paramref name="actionName"/> will process the request.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="actionName">The name of the action method.</param>
|
/// <param name="actionName">The name of the action method.</param>
|
||||||
/// <param name="controllerName">The name of the controller.</param>
|
/// <param name="controllerName">The name of the controller.</param>
|
||||||
|
|
|
||||||
|
|
@ -132,7 +132,7 @@ namespace Microsoft.AspNet.Mvc.Rendering
|
||||||
var expected = @"<input checked=""checked"" id=""Property1"" name=""Property1"" " +
|
var expected = @"<input checked=""checked"" id=""Property1"" name=""Property1"" " +
|
||||||
@"Property1-Property3=""Property3ObjValue"" type=""checkbox"" value=""true"" /><input " +
|
@"Property1-Property3=""Property3ObjValue"" type=""checkbox"" value=""true"" /><input " +
|
||||||
@"name=""Property1"" type=""hidden"" value=""false"" />";
|
@"name=""Property1"" type=""hidden"" value=""false"" />";
|
||||||
var helper = DefaultTemplatesUtilities.GetHtmlHelper<ViewDataDictionary<TestModel>>(GetTestModelViewData());
|
var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData());
|
||||||
var htmlAttributes = new { Property1_Property3 = "Property3ObjValue" };
|
var htmlAttributes = new { Property1_Property3 = "Property3ObjValue" };
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
|
|
|
||||||
|
|
@ -21,7 +21,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
// Arrange
|
// Arrange
|
||||||
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
||||||
var enumerableHelper =
|
var enumerableHelper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var displayNameResult = helper.DisplayName(expression: string.Empty);
|
var displayNameResult = helper.DisplayName(expression: string.Empty);
|
||||||
|
|
@ -44,7 +44,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
// Arrange
|
// Arrange
|
||||||
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
||||||
var enumerableHelper =
|
var enumerableHelper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var displayNameResult = helper.DisplayName("Property1");
|
var displayNameResult = helper.DisplayName("Property1");
|
||||||
|
|
@ -92,7 +92,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
||||||
helper.ViewData.ModelMetadata = metadata;
|
helper.ViewData.ModelMetadata = metadata;
|
||||||
var enumerableHelper =
|
var enumerableHelper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
enumerableHelper.ViewData.ModelMetadata = metadata;
|
enumerableHelper.ViewData.ModelMetadata = metadata;
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
|
|
@ -149,7 +149,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
|
||||||
helper.ViewData.ModelMetadata.DisplayName = displayName;
|
helper.ViewData.ModelMetadata.DisplayName = displayName;
|
||||||
var enumerableHelper =
|
var enumerableHelper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
enumerableHelper.ViewData.ModelMetadata.DisplayName = displayName;
|
enumerableHelper.ViewData.ModelMetadata.DisplayName = displayName;
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
|
|
@ -255,7 +255,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var helper =
|
var helper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
|
|
||||||
// Act & Assert
|
// Act & Assert
|
||||||
var exception = Assert.Throws<InvalidOperationException>(
|
var exception = Assert.Throws<InvalidOperationException>(
|
||||||
|
|
@ -285,7 +285,7 @@ namespace Microsoft.AspNet.Mvc.Core
|
||||||
// Arrange
|
// Arrange
|
||||||
var unknownKey = "this is a dummy parameter value";
|
var unknownKey = "this is a dummy parameter value";
|
||||||
var helper =
|
var helper =
|
||||||
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
|
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var result = helper.DisplayNameFor(model => unknownKey);
|
var result = helper.DisplayNameFor(model => unknownKey);
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue