huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Per PR discussion 

- clean up "the the" in XML comments
- simplify refactoring VS did when I renamed `GetHtmlHelperForViewData()`
 - fix existing issue in `HtmlHelperCheckboxTest.CheckBoxReplacesUnderscoresInHtmlAttributesWithDashes()`
   (was using a `HtmlHelper<ViewDataDictionary<TestModel>>`)
This commit is contained in:
Doug Bunting 2014-11-12 10:11:16 -08:00
parent 1d3ae83507
commit 7e8870cb9f
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNet.Mvc.Core/Rendering/Html/HtmlHelper.cs
View File

@ -616,8 +616,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
}
/// <summary>
/// Renders a &lt;form&gt; start tag to the response. When the user submits the form, the
/// the action with name <paramref name="actionName"/> will process the request.
/// Renders a &lt;form&gt; start tag to the response. When the user submits the form, the action with name
/// <paramref name="actionName"/> will process the request.
/// </summary>
/// <param name="actionName">The name of the action method.</param>
/// <param name="controllerName">The name of the controller.</param>

4
src/Microsoft.AspNet.Mvc.Core/Rendering/IHtmlHelper.cs
View File

@ -82,8 +82,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
HtmlString AntiForgeryToken();
/// <summary>
/// Renders a &lt;form&gt; start tag to the response. When the user submits the form, the
/// the action with name <paramref name="actionName"/> will process the request.
/// Renders a &lt;form&gt; start tag to the response. When the user submits the form, the action with name
/// <paramref name="actionName"/> will process the request.
/// </summary>
/// <param name="actionName">The name of the action method.</param>
/// <param name="controllerName">The name of the controller.</param>

2
test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperCheckboxTest.cs
View File

@ -132,7 +132,7 @@ namespace Microsoft.AspNet.Mvc.Rendering
var expected = @"<input checked=""checked"" id=""Property1"" name=""Property1"" " +
@"Property1-Property3=""Property3ObjValue"" type=""checkbox"" value=""true"" /><input " +
@"name=""Property1"" type=""hidden"" value=""false"" />";
var helper = DefaultTemplatesUtilities.GetHtmlHelper<ViewDataDictionary<TestModel>>(GetTestModelViewData());
var helper = DefaultTemplatesUtilities.GetHtmlHelper(GetTestModelViewData());
var htmlAttributes = new { Property1_Property3 = "Property3ObjValue" };
// Act

12
test/Microsoft.AspNet.Mvc.Core.Test/Rendering/HtmlHelperDisplayNameExtensionsTest.cs
View File

@ -21,7 +21,7 @@ namespace Microsoft.AspNet.Mvc.Core
// Arrange
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
var enumerableHelper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
// Act
var displayNameResult = helper.DisplayName(expression: string.Empty);
@ -44,7 +44,7 @@ namespace Microsoft.AspNet.Mvc.Core
// Arrange
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
var enumerableHelper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
// Act
var displayNameResult = helper.DisplayName("Property1");
@ -92,7 +92,7 @@ namespace Microsoft.AspNet.Mvc.Core
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
helper.ViewData.ModelMetadata = metadata;
var enumerableHelper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
enumerableHelper.ViewData.ModelMetadata = metadata;
// Act
@ -149,7 +149,7 @@ namespace Microsoft.AspNet.Mvc.Core
var helper = DefaultTemplatesUtilities.GetHtmlHelper();
helper.ViewData.ModelMetadata.DisplayName = displayName;
var enumerableHelper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
enumerableHelper.ViewData.ModelMetadata.DisplayName = displayName;
// Act
@ -255,7 +255,7 @@ namespace Microsoft.AspNet.Mvc.Core
{
// Arrange
var helper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
// Act & Assert
var exception = Assert.Throws<InvalidOperationException>(
@ -285,7 +285,7 @@ namespace Microsoft.AspNet.Mvc.Core
// Arrange
var unknownKey = "this is a dummy parameter value";
var helper =
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>((IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>)null);
DefaultTemplatesUtilities.GetHtmlHelper<IEnumerable<DefaultTemplatesUtilities.ObjectTemplateModel>>(model: null);
// Act
var result = helper.DisplayNameFor(model => unknownKey);