From 7e447c33eadda96217e0641a1241db3cc8973afc Mon Sep 17 00:00:00 2001 From: Ajay Bhargav Baaskaran Date: Fri, 12 May 2017 15:42:02 -0700 Subject: [PATCH] [Issue #1317] Rename HasAnyErrors to HasErrors in tag helper descriptor api --- .../BoundAttributeDescriptor.cs | 6 +++--- .../RequiredAttributeDescriptor.cs | 6 +++--- .../TagHelperDescriptor.cs | 6 +++--- src/Microsoft.AspNetCore.Razor.Language/TagMatchingRule.cs | 6 +++--- .../DefaultTagHelperDescriptorFactoryTest.cs | 4 ++-- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Microsoft.AspNetCore.Razor.Language/BoundAttributeDescriptor.cs b/src/Microsoft.AspNetCore.Razor.Language/BoundAttributeDescriptor.cs index 2d720eff98..03a8342a6d 100644 --- a/src/Microsoft.AspNetCore.Razor.Language/BoundAttributeDescriptor.cs +++ b/src/Microsoft.AspNetCore.Razor.Language/BoundAttributeDescriptor.cs @@ -43,13 +43,13 @@ namespace Microsoft.AspNetCore.Razor.Language public IReadOnlyDictionary Metadata { get; protected set; } - public bool HasAnyErrors + public bool HasErrors { get { - var anyErrors = Diagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); + var errors = Diagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); - return anyErrors; + return errors; } } diff --git a/src/Microsoft.AspNetCore.Razor.Language/RequiredAttributeDescriptor.cs b/src/Microsoft.AspNetCore.Razor.Language/RequiredAttributeDescriptor.cs index cf25263397..5fa519f6a7 100644 --- a/src/Microsoft.AspNetCore.Razor.Language/RequiredAttributeDescriptor.cs +++ b/src/Microsoft.AspNetCore.Razor.Language/RequiredAttributeDescriptor.cs @@ -22,13 +22,13 @@ namespace Microsoft.AspNetCore.Razor.Language public IReadOnlyList Diagnostics { get; protected set; } - public bool HasAnyErrors + public bool HasErrors { get { - var anyErrors = Diagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); + var errors = Diagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); - return anyErrors; + return errors; } } diff --git a/src/Microsoft.AspNetCore.Razor.Language/TagHelperDescriptor.cs b/src/Microsoft.AspNetCore.Razor.Language/TagHelperDescriptor.cs index 3e69ddd964..45f7eba55f 100644 --- a/src/Microsoft.AspNetCore.Razor.Language/TagHelperDescriptor.cs +++ b/src/Microsoft.AspNetCore.Razor.Language/TagHelperDescriptor.cs @@ -38,14 +38,14 @@ namespace Microsoft.AspNetCore.Razor.Language public IReadOnlyDictionary Metadata { get; protected set; } - public bool HasAnyErrors + public bool HasErrors { get { var allDiagnostics = GetAllDiagnostics(); - var anyErrors = allDiagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); + var errors = allDiagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); - return anyErrors; + return errors; } } diff --git a/src/Microsoft.AspNetCore.Razor.Language/TagMatchingRule.cs b/src/Microsoft.AspNetCore.Razor.Language/TagMatchingRule.cs index 4cc0c76e9c..998690fefd 100644 --- a/src/Microsoft.AspNetCore.Razor.Language/TagMatchingRule.cs +++ b/src/Microsoft.AspNetCore.Razor.Language/TagMatchingRule.cs @@ -21,14 +21,14 @@ namespace Microsoft.AspNetCore.Razor.Language public IReadOnlyList Diagnostics { get; protected set; } - public bool HasAnyErrors + public bool HasErrors { get { var allDiagnostics = GetAllDiagnostics(); - var anyErrors = allDiagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); + var errors = allDiagnostics.Any(diagnostic => diagnostic.Severity == RazorDiagnosticSeverity.Error); - return anyErrors; + return errors; } } diff --git a/test/Microsoft.CodeAnalysis.Razor.Test/DefaultTagHelperDescriptorFactoryTest.cs b/test/Microsoft.CodeAnalysis.Razor.Test/DefaultTagHelperDescriptorFactoryTest.cs index 64c1d856c8..83b36aba51 100644 --- a/test/Microsoft.CodeAnalysis.Razor.Test/DefaultTagHelperDescriptorFactoryTest.cs +++ b/test/Microsoft.CodeAnalysis.Razor.Test/DefaultTagHelperDescriptorFactoryTest.cs @@ -1518,7 +1518,7 @@ namespace Microsoft.CodeAnalysis.Razor.Workspaces var descriptor = factory.CreateDescriptor(tagHelperType); // Assert - Assert.False(descriptor.HasAnyErrors); + Assert.False(descriptor.HasErrors); } public static TheoryData ValidAttributePrefixData @@ -1558,7 +1558,7 @@ namespace Microsoft.CodeAnalysis.Razor.Workspaces var descriptor = factory.CreateDescriptor(tagHelperType); // Assert - Assert.False(descriptor.HasAnyErrors); + Assert.False(descriptor.HasErrors); } // name, expectedErrorMessages