huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Show unexpected error logs in assertion failures.

This commit is contained in:
Cesar Blum Silveira 2017-04-05 11:23:04 -07:00 committed by GitHub
parent bab4332a47
commit 7d50f34b85
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/HttpsTests.cs
View File

@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System; using System;
using System.Collections.Generic;
using System.Net; using System.Net;
using System.Net.Security; using System.Net.Security;
using System.Net.Sockets; using System.Net.Sockets;
@ -52,7 +53,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id); Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id);
Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel); Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel);
Assert.Equal(0, loggerFactory.ErrorLogger.TotalErrorsLogged); Assert.True(loggerFactory.ErrorLogger.TotalErrorsLogged == 0,
userMessage: string.Join(Environment.NewLine, loggerFactory.ErrorLogger.ErrorMessages));
} }
[Fact] [Fact]
@ -87,7 +89,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id); Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id);
Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel); Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel);
Assert.Equal(0, loggerFactory.ErrorLogger.TotalErrorsLogged); Assert.True(loggerFactory.ErrorLogger.TotalErrorsLogged == 0,
userMessage: string.Join(Environment.NewLine, loggerFactory.ErrorLogger.ErrorMessages));
} }
// Regression test for https://github.com/aspnet/KestrelHttpServer/issues/1103#issuecomment-246971172 // Regression test for https://github.com/aspnet/KestrelHttpServer/issues/1103#issuecomment-246971172
@ -277,7 +280,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
private class ApplicationErrorLogger : ILogger private class ApplicationErrorLogger : ILogger
{ {
public int TotalErrorsLogged { get; set; } private List<string> _errorMessages = new List<string>();
public IEnumerable<string> ErrorMessages => _errorMessages;
public int TotalErrorsLogged => _errorMessages.Count;
public bool ObjectDisposedExceptionLogged { get; set; } public bool ObjectDisposedExceptionLogged { get; set; }
@ -285,7 +292,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
{ {
if (logLevel == LogLevel.Error) if (logLevel == LogLevel.Error)
{ {
TotalErrorsLogged++; _errorMessages.Add(formatter(state, exception));
} }
if (exception is ObjectDisposedException) if (exception is ObjectDisposedException)