From 7d4b691d8b2d74d01fe2f78c7f3999513fa13346 Mon Sep 17 00:00:00 2001
From: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Date: Mon, 16 Sep 2019 21:28:28 -0700
Subject: [PATCH] Provide more information when pipelines fail - restore
 publication of flaky test results to AzDO Tests tab - upload logs and test
 results for forks too

---
 .azure/pipelines/ci.yml                  | 35 ++++++++++++++++++++++++
 .azure/pipelines/jobs/codesign-xplat.yml |  1 +
 2 files changed, 36 insertions(+)

diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml
index f7cc167b14..5a098bca9d 100644
--- a/.azure/pipelines/ci.yml
+++ b/.azure/pipelines/ci.yml
@@ -83,6 +83,7 @@ stages:
       - name: Code_Check_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
 
   # Build Windows (x64/x86)
   - template: jobs/default-build.yml
@@ -167,6 +168,7 @@ stages:
       - name: Windows_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Windows_Packages
         path: artifacts/packages/
 
@@ -195,6 +197,7 @@ stages:
       - name: Windows_arm_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Windows_arm_Packages
         path: artifacts/packages/
 
@@ -220,6 +223,7 @@ stages:
       - name: MacOS_x64_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: MacOS_x64_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -280,6 +284,7 @@ stages:
       - name: Linux_x64_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_x64_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -309,6 +314,7 @@ stages:
       - name: Linux_arm_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_arm_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -338,6 +344,7 @@ stages:
       - name: Linux_arm64_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_arm64_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -370,6 +377,7 @@ stages:
       - name: Linux_musl_x64_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_musl_x64_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -402,6 +410,7 @@ stages:
       - name: Linux_musl_arm64_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_musl_arm64_Packages
         path: artifacts/packages/
   - template: jobs/codesign-xplat.yml
@@ -424,13 +433,21 @@ stages:
       - powershell: "& ./build.ps1 -CI -NoBuild -Test /p:RunFlakyTests=true"
         displayName: Run Flaky Tests
         continueOnError: true
+      - task: PublishTestResults@2
+        displayName: Publish Flaky Test Results
+        inputs:
+          testResultsFormat: 'xUnit'
+          testResultsFiles: '*.xml'
+          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
       artifacts:
       - name: Windows_Test_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Windows_Test_Results
         path: artifacts/TestResults/
         publishOnError: true
+        includeForks: true
 
   - template: jobs/default-build.yml
     parameters:
@@ -450,9 +467,11 @@ stages:
       - name: Windows_Test_Templates_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Windows_Test_Templates_Results
         path: artifacts/TestResults/
         publishOnError: true
+        includeForks: true
 
   - template: jobs/default-build.yml
     parameters:
@@ -473,13 +492,21 @@ stages:
       - bash: ./build.sh --no-build --ci --test -p:RunFlakyTests=true
         displayName: Run Flaky Tests
         continueOnError: true
+      - task: PublishTestResults@2
+        displayName: Publish Flaky Test Results
+        inputs:
+          testResultsFormat: 'xUnit'
+          testResultsFiles: '*.xml'
+          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
       artifacts:
       - name: MacOS_Test_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: MacOS_Test_Results
         path: artifacts/TestResults/
         publishOnError: true
+        includeForks: true
 
   - template: jobs/default-build.yml
     parameters:
@@ -502,13 +529,21 @@ stages:
       - bash: ./build.sh --no-build --ci --test -p:RunFlakyTests=true
         displayName: Run Flaky Tests
         continueOnError: true
+      - task: PublishTestResults@2
+        displayName: Publish Flaky Test Results
+        inputs:
+          testResultsFormat: 'xUnit'
+          testResultsFiles: '*.xml'
+          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
       artifacts:
       - name: Linux_Test_Logs
         path: artifacts/log/
         publishOnError: true
+        includeForks: true
       - name: Linux_Test_Results
         path: artifacts/TestResults/
         publishOnError: true
+        includeForks: true
 
   # Source build
   - job: Source_Build
diff --git a/.azure/pipelines/jobs/codesign-xplat.yml b/.azure/pipelines/jobs/codesign-xplat.yml
index b0d9a584ea..abf1512540 100644
--- a/.azure/pipelines/jobs/codesign-xplat.yml
+++ b/.azure/pipelines/jobs/codesign-xplat.yml
@@ -44,5 +44,6 @@ jobs:
     - name: CodeSign_Xplat_${{ parameters.inputName }}_Logs
       path: artifacts/log/
       publishOnError: true
+      includeForks: true
     - name: ${{ parameters.inputName }}_Packages_Signed
       path: artifacts/packages/