Changes per PR comments

Reformatting parameter identation

src/Microsoft.AspNet.JsonPatch/Converters/TypedJsonPatchDocumentConverter.cs

@@ -14,7 +14,10 @@ namespace Microsoft.AspNet.JsonPatch.Converters
 {
     public class TypedJsonPatchDocumentConverter : JsonPatchDocumentConverter
     {
-        public override object ReadJson(JsonReader reader, Type objectType, object existingValue,
+        public override object ReadJson(
+            JsonReader reader,
+            Type objectType,
+            object existingValue,
             JsonSerializer serializer)
         {
             try

src/Microsoft.AspNet.JsonPatch/Helpers/ExpandoObjectDictionaryExtensions.cs

@@ -9,8 +9,10 @@ namespace Microsoft.AspNet.JsonPatch.Helpers
     // Helper methods to allow case-insensitive key search
     internal static class ExpandoObjectDictionaryExtensions
     {
-        internal static void SetValueForCaseInsensitiveKey(this IDictionary<string, object> propertyDictionary,
+        internal static void SetValueForCaseInsensitiveKey(
-        string key, object value)
+            this IDictionary<string, object> propertyDictionary,
+            string key,
+            object value)
         {
             foreach (KeyValuePair<string, object> kvp in propertyDictionary)
             {
@@ -22,7 +24,8 @@ namespace Microsoft.AspNet.JsonPatch.Helpers
             }
         }
 
-        internal static void RemoveValueForCaseInsensitiveKey(this IDictionary<string, object> propertyDictionary,
+        internal static void RemoveValueForCaseInsensitiveKey(
+            this IDictionary<string, object> propertyDictionary,
             string key)
         {
             string realKey = null;
@@ -41,7 +44,8 @@ namespace Microsoft.AspNet.JsonPatch.Helpers
             }
         }
 
-        internal static object GetValueForCaseInsensitiveKey(this IDictionary<string, object> propertyDictionary,
+        internal static object GetValueForCaseInsensitiveKey(
+            this IDictionary<string, object> propertyDictionary,
             string key)
         {
             foreach (KeyValuePair<string, object> kvp in propertyDictionary)
@@ -55,7 +59,8 @@ namespace Microsoft.AspNet.JsonPatch.Helpers
             throw new ArgumentException(Resources.FormatDictionaryKeyNotFound(key));
         }
 
-        internal static bool ContainsCaseInsensitiveKey(this IDictionary<string, object> propertyDictionary,
+        internal static bool ContainsCaseInsensitiveKey(
+            this IDictionary<string, object> propertyDictionary,
             string key)
         {
             foreach (KeyValuePair<string, object> kvp in propertyDictionary)
@@ -65,8 +70,8 @@ namespace Microsoft.AspNet.JsonPatch.Helpers
                     return true;
                 }
             }
-            return false;
 
+            return false;
         }
     }
 }

src/Microsoft.AspNet.Mvc.Abstractions/ModelBinding/Validation/ClientModelValidationContext.cs

@@ -8,7 +8,8 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Validation
 {
     public class ClientModelValidationContext
     {
-        public ClientModelValidationContext([NotNull] ModelMetadata metadata,
+        public ClientModelValidationContext(
+            [NotNull] ModelMetadata metadata,
             [NotNull] IModelMetadataProvider metadataProvider,
             [NotNull] IServiceProvider requestServices)
         {

src/Microsoft.AspNet.Mvc.Abstractions/ModelBinding/Validation/ModelClientValidationRule.cs

@@ -17,7 +17,8 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Validation
         {
         }
 
-        public ModelClientValidationRule([NotNull] string validationType,
+        public ModelClientValidationRule(
+            [NotNull] string validationType,
             [NotNull] string errorMessage)
         {
             ValidationType = validationType;

src/Microsoft.AspNet.Mvc.Core/Actions/ControllerActionDescriptorBuilder.cs

@@ -802,7 +802,8 @@ namespace Microsoft.AspNet.Mvc.Actions
         private class MethodToActionMap :
             Dictionary<MethodInfo, IDictionary<ActionModel, IList<ControllerActionDescriptor>>>
         {
-            public void AddToMethodInfo(ActionModel action,
+            public void AddToMethodInfo(
+                ActionModel action,
                 IList<ControllerActionDescriptor> actionDescriptors)
             {
                 IDictionary<ActionModel, IList<ControllerActionDescriptor>> actionsForMethod = null;

src/Microsoft.AspNet.Mvc.Core/Actions/DefaultControllerTypeProvider.cs

@@ -46,7 +46,8 @@ namespace Microsoft.AspNet.Mvc.Actions
         /// <param name="typeInfo">The <see cref="TypeInfo"/>.</param>
         /// <param name="candidateAssemblies">The set of candidate assemblies.</param>
         /// <returns><c>true</c> if the <paramref name="typeInfo"/> is a controller. Otherwise <c>false</c>.</returns>
-        protected internal virtual bool IsController([NotNull] TypeInfo typeInfo,
+        protected internal virtual bool IsController(
+            [NotNull] TypeInfo typeInfo,
             [NotNull] ISet<Assembly> candidateAssemblies)
         {
             if (!typeInfo.IsClass)

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/ActionModel.cs

@@ -16,7 +16,8 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
                      " Route: {AttributeRouteModel?.Template}, Filters: {Filters.Count}")]
     public class ActionModel
     {
-        public ActionModel([NotNull] MethodInfo actionMethod,
+        public ActionModel(
+            [NotNull] MethodInfo actionMethod,
             [NotNull] IReadOnlyList<object> attributes)
         {
             ActionMethod = actionMethod;

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/ControllerModel.cs

@@ -16,7 +16,8 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
                      " Routes: {AttributeRoutes.Count}, Filters: {Filters.Count}")]
     public class ControllerModel
     {
-        public ControllerModel([NotNull] TypeInfo controllerType,
+        public ControllerModel(
+            [NotNull] TypeInfo controllerType,
             [NotNull] IReadOnlyList<object> attributes)
         {
             ControllerType = controllerType;

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/ParameterModel.cs

@@ -12,7 +12,8 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
     [DebuggerDisplay("ParameterModel: Name={ParameterName}")]
     public class ParameterModel
     {
-        public ParameterModel([NotNull] ParameterInfo parameterInfo,
+        public ParameterModel(
+            [NotNull] ParameterInfo parameterInfo,
             [NotNull] IReadOnlyList<object> attributes)
         {
             ParameterInfo = parameterInfo;

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/PropertyModel.cs

@@ -20,7 +20,8 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
         /// </summary>
         /// <param name="propertyInfo">The <see cref="PropertyInfo"/> for the underlying property.</param>
         /// <param name="attributes">Any attributes which are annotated on the property.</param>
-        public PropertyModel([NotNull] PropertyInfo propertyInfo,
+        public PropertyModel(
+            [NotNull] PropertyInfo propertyInfo,
             [NotNull] IReadOnlyList<object> attributes)
         {
             PropertyInfo = propertyInfo;

src/Microsoft.AspNet.Mvc.Core/CreatedAtActionResult.cs

@@ -25,7 +25,8 @@ namespace Microsoft.AspNet.Mvc
         /// <param name="controllerName">The name of the controller to use for generating the URL.</param>
         /// <param name="routeValues">The route data to use for generating the URL.</param>
         /// <param name="value">The value to format in the entity body.</param>
-        public CreatedAtActionResult(string actionName,
+        public CreatedAtActionResult(
+            string actionName,
             string controllerName,
             object routeValues,
             object value)

src/Microsoft.AspNet.Mvc.Core/CreatedAtRouteResult.cs

@@ -36,7 +36,8 @@ namespace Microsoft.AspNet.Mvc
         /// <param name="routeName">The name of the route to use for generating the URL.</param>
         /// <param name="routeValues">The route data to use for generating the URL.</param>
         /// <param name="value">The value to format in the entity body.</param>
-        public CreatedAtRouteResult(string routeName,
+        public CreatedAtRouteResult(
+            string routeName,
             object routeValues,
             object value)
             : base(value)

src/Microsoft.AspNet.Mvc.Core/Internal/NonDisposableStream.cs

@@ -107,8 +107,12 @@ namespace Microsoft.AspNet.Mvc.Internal
         }
 #if DNX451
         /// <inheritdoc />
-        public override IAsyncResult BeginRead(byte[] buffer, int offset, int count,
+        public override IAsyncResult BeginRead(
-            AsyncCallback callback, object state)
+            byte[] buffer,
+            int offset,
+            int count,
+            AsyncCallback callback,
+            object state)
         {
             return _innerStream.BeginRead(buffer, offset, count, callback, state);
         }
@@ -162,8 +166,12 @@ namespace Microsoft.AspNet.Mvc.Internal
         }
 #if DNX451
         /// <inheritdoc />
-        public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count,
+        public override IAsyncResult BeginWrite(
-            AsyncCallback callback, object state)
+            byte[] buffer,
+            int offset,
+            int count,
+            AsyncCallback callback,
+            object state)
         {
             return _innerStream.BeginWrite(buffer, offset, count, callback, state);
         }

src/Microsoft.AspNet.Mvc.Core/ModelBindingHelper.cs

@@ -457,7 +457,8 @@ namespace Microsoft.AspNet.Mvc
             }
         }
 
-        internal static void ValidateBindingContext(ModelBindingContext bindingContext,
+        internal static void ValidateBindingContext(
+            ModelBindingContext bindingContext,
             Type requiredType,
             bool allowNullModel)
         {

src/Microsoft.AspNet.Mvc.Core/Routing/KnownRouteValueConstraint.cs

@@ -17,7 +17,8 @@ namespace Microsoft.AspNet.Mvc.Routing
     {
         private RouteValuesCollection _cachedValuesCollection;
 
-        public bool Match([NotNull] HttpContext httpContext,
+        public bool Match(
+            [NotNull] HttpContext httpContext,
             [NotNull] IRouter route,
             [NotNull] string routeKey,
             [NotNull] IDictionary<string, object> values,

src/Microsoft.AspNet.Mvc.DataAnnotations/DataTypeAttributeAdapter.cs

@@ -15,7 +15,8 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Validation
     /// </summary>
     public class DataTypeAttributeAdapter : DataAnnotationsClientModelValidator<DataTypeAttribute>
     {
-        public DataTypeAttributeAdapter(DataTypeAttribute attribute,
+        public DataTypeAttributeAdapter(
+            DataTypeAttribute attribute,
             [NotNull] string ruleName)
             : base(attribute)
         {

src/Microsoft.AspNet.Mvc.DataAnnotations/ModelClientValidationEqualToRule.cs

@@ -13,7 +13,8 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Validation
         private const string EqualToValidationType = "equalto";
         private const string EqualToValidationParameter = "other";
 
-        public ModelClientValidationEqualToRule([NotNull] string errorMessage,
+        public ModelClientValidationEqualToRule(
+            [NotNull] string errorMessage,
             [NotNull] object other)
             : base(EqualToValidationType, errorMessage)
         {

src/Microsoft.AspNet.Mvc.DataAnnotations/ModelClientValidationRangeRule.cs

@@ -11,7 +11,8 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Validation
         private const string MinValidationParameter = "min";
         private const string MaxValidationParameter = "max";
 
-        public ModelClientValidationRangeRule([NotNull] string errorMessage,
+        public ModelClientValidationRangeRule(
+            [NotNull] string errorMessage,
             [NotNull] object minValue,
             [NotNull] object maxValue)
             : base(RangeValidationType, errorMessage)

src/Microsoft.AspNet.Mvc.Formatters.Xml/XmlDataContractSerializerOutputFormatter.cs

@@ -156,7 +156,8 @@ namespace Microsoft.AspNet.Mvc.Formatters
         /// </summary>
         /// <param name="writeStream">The stream on which the XmlWriter should operate on.</param>
         /// <returns>A new instance of <see cref="XmlWriter"/></returns>
-        public virtual XmlWriter CreateXmlWriter([NotNull] Stream writeStream,
+        public virtual XmlWriter CreateXmlWriter(
+            [NotNull] Stream writeStream,
             [NotNull] XmlWriterSettings xmlWriterSettings)
         {
             return XmlWriter.Create(

src/Microsoft.AspNet.Mvc.Formatters.Xml/XmlSerializerOutputFormatter.cs

@@ -131,7 +131,8 @@ namespace Microsoft.AspNet.Mvc.Formatters
         /// </summary>
         /// <param name="writeStream">The stream on which the XmlWriter should operate on.</param>
         /// <returns>A new instance of <see cref="XmlWriter"/></returns>
-        public virtual XmlWriter CreateXmlWriter([NotNull] Stream writeStream,
+        public virtual XmlWriter CreateXmlWriter(
+            [NotNull] Stream writeStream,
             [NotNull] XmlWriterSettings xmlWriterSettings)
         {
             return XmlWriter.Create(

src/Microsoft.AspNet.Mvc.Razor.Host/Directives/DefaultChunkTreeCache.cs

@@ -31,7 +31,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Directives
         }
 
         // Internal for unit testing
-        internal DefaultChunkTreeCache(IFileProvider fileProvider,
+        internal DefaultChunkTreeCache(
+            IFileProvider fileProvider,
             MemoryCacheOptions options)
         {
             _fileProvider = fileProvider;

src/Microsoft.AspNet.Mvc.Razor.Host/InjectChunkVisitor.cs

@@ -12,7 +12,8 @@ namespace Microsoft.AspNet.Mvc.Razor
     {
         private readonly string _injectAttribute;
 
-        public InjectChunkVisitor(CSharpCodeWriter writer,
+        public InjectChunkVisitor(
+            CSharpCodeWriter writer,
             CodeGeneratorContext context,
             string injectAttributeName)
             : base(writer, context)

src/Microsoft.AspNet.Mvc.Razor.Host/MvcCSharpChunkVisitor.cs

@@ -10,7 +10,8 @@ namespace Microsoft.AspNet.Mvc.Razor
 {
     public abstract class MvcCSharpChunkVisitor : CodeVisitor<CSharpCodeWriter>
     {
-        public MvcCSharpChunkVisitor(CSharpCodeWriter writer,
+        public MvcCSharpChunkVisitor(
+            CSharpCodeWriter writer,
             CodeGeneratorContext context)
             : base(writer, context)
         {

src/Microsoft.AspNet.Mvc.Razor/Compilation/CompilerCache.cs

@@ -49,11 +49,6 @@ namespace Microsoft.AspNet.Mvc.Razor.Compilation
             IDictionary<string, Type> precompiledViews)
             : this(fileProvider)
         {
-            if (fileProvider == null)
-            {
-                throw new ArgumentNullException(nameof(fileProvider));
-            }
-
             if (precompiledViews == null)
             {
                 throw new ArgumentNullException(nameof(precompiledViews));

src/Microsoft.AspNet.Mvc.Razor/Precompilation/RazorPreCompiler.cs

@@ -331,7 +331,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Precompilation
 
         private class PrecompileRazorFileInfoCollection : RazorFileInfoCollection
         {
-            public PrecompileRazorFileInfoCollection(string assemblyResourceName,
+            public PrecompileRazorFileInfoCollection(
+                string assemblyResourceName,
                 string symbolsResourceName,
                 IReadOnlyList<RazorFileInfo> fileInfos)
             {

src/Microsoft.AspNet.Mvc.Razor/RazorView.cs

@@ -81,11 +81,6 @@ namespace Microsoft.AspNet.Mvc.Razor
                 throw new ArgumentNullException(nameof(context));
             }
 
-            if (context == null)
-            {
-                throw new ArgumentNullException(nameof(context));
-            }
-
             _pageExecutionFeature = context.HttpContext.Features.Get<IPageExecutionListenerFeature>();
 
             // Partials don't execute _ViewStart pages, but may execute Layout pages if the Layout property

src/Microsoft.AspNet.Mvc.Razor/RazorViewEngineOptionsSetup.cs

@@ -22,7 +22,8 @@ namespace Microsoft.AspNet.Mvc
         {
         }
 
-        private static void ConfigureRazor(RazorViewEngineOptions razorOptions,
+        private static void ConfigureRazor(
+            RazorViewEngineOptions razorOptions,
             IApplicationEnvironment applicationEnvironment)
         {
             razorOptions.FileProvider = new PhysicalFileProvider(applicationEnvironment.ApplicationBasePath);

src/Microsoft.AspNet.Mvc.Razor/ViewLocationCacheResult.cs

@@ -30,11 +30,6 @@ namespace Microsoft.AspNet.Mvc.Razor
                 throw new ArgumentNullException(nameof(foundLocation));
             }
 
-            if (searchedLocations == null)
-            {
-                throw new ArgumentNullException(nameof(searchedLocations));
-            }
-
             ViewLocation = foundLocation;
             SearchedLocations = searchedLocations;
             IsFoundResult = true;

src/Microsoft.AspNet.Mvc.Razor/ViewLocationExpanderContext.cs

@@ -17,7 +17,8 @@ namespace Microsoft.AspNet.Mvc.Razor
         /// <param name="actionContext">The <see cref="Mvc.ActionContext"/> for the current executing action.</param>
         /// <param name="viewName">The view name.</param>
         /// <param name="isPartial">Determines if the view being discovered is a partial.</param>
-        public ViewLocationExpanderContext(ActionContext actionContext,
+        public ViewLocationExpanderContext(
+            ActionContext actionContext,
             string viewName,
             bool isPartial)
         {

src/Microsoft.AspNet.Mvc.TagHelpers/CacheTagHelper.cs

@@ -237,7 +237,8 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
             return options;
         }
 
-        private static void AddStringCollectionKey(StringBuilder builder,
+        private static void AddStringCollectionKey(
+            StringBuilder builder,
             string keyName,
             string value,
             IReadableStringCollection sourceCollection)

src/Microsoft.AspNet.Mvc.ViewFeatures/Controller.cs

@@ -570,7 +570,9 @@ namespace Microsoft.AspNet.Mvc
         /// <param name="routeValues">The parameters for a route.</param>
         /// <returns>The created <see cref="RedirectToActionResult"/> for the response.</returns>
         [NonAction]
-        public virtual RedirectToActionResult RedirectToAction(string actionName, string controllerName,
+        public virtual RedirectToActionResult RedirectToAction(
+            string actionName,
+            string controllerName,
             object routeValues)
         {
             return new RedirectToActionResult(actionName, controllerName, PropertyHelper.ObjectToDictionary(routeValues))
@@ -627,7 +629,9 @@ namespace Microsoft.AspNet.Mvc
         /// <param name="routeValues">The parameters for a route.</param>
         /// <returns>The created <see cref="RedirectToActionResult"/> for the response.</returns>
         [NonAction]
-        public virtual RedirectToActionResult RedirectToActionPermanent(string actionName, string controllerName,
+        public virtual RedirectToActionResult RedirectToActionPermanent(
+            string actionName,
+            string controllerName,
             object routeValues)
         {
             return new RedirectToActionResult(
@@ -984,7 +988,8 @@ namespace Microsoft.AspNet.Mvc
         /// <param name="value">The content value to format in the entity body.</param>
         /// <returns>The created <see cref="CreatedAtRouteResult"/> for the response.</returns>
         [NonAction]
-        public virtual CreatedAtActionResult CreatedAtAction(string actionName,
+        public virtual CreatedAtActionResult CreatedAtAction(
+            string actionName,
             string controllerName,
             object routeValues,
             object value)

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewEngines/CompositeViewEngine.cs

@@ -24,20 +24,23 @@ namespace Microsoft.AspNet.Mvc.ViewEngines
         public IReadOnlyList<IViewEngine> ViewEngines { get; }
 
         /// <inheritdoc />
-        public ViewEngineResult FindPartialView([NotNull] ActionContext context,
+        public ViewEngineResult FindPartialView(
+            [NotNull] ActionContext context,
             [NotNull] string partialViewName)
         {
             return FindView(context, partialViewName, partial: true);
         }
 
         /// <inheritdoc />
-        public ViewEngineResult FindView([NotNull] ActionContext context,
+        public ViewEngineResult FindView(
+            [NotNull] ActionContext context,
             [NotNull] string viewName)
         {
             return FindView(context, viewName, partial: false);
         }
 
-        private ViewEngineResult FindView(ActionContext context,
+        private ViewEngineResult FindView(
+            ActionContext context,
             string viewName,
             bool partial)
         {

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewEngines/ViewEngineResult.cs

@@ -25,7 +25,8 @@ namespace Microsoft.AspNet.Mvc.ViewEngines
             get { return View != null; }
         }
 
-        public static ViewEngineResult NotFound([NotNull] string viewName,
+        public static ViewEngineResult NotFound(
+            [NotNull] string viewName,
             [NotNull] IEnumerable<string> searchedLocations)
         {
             return new ViewEngineResult

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/HtmlHelper.cs

@@ -283,7 +283,8 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures
         }
 
         /// <inheritdoc />
-        public IHtmlContent Display(string expression,
+        public IHtmlContent Display(
+            string expression,
             string templateName,
             string htmlFieldName,
             object additionalViewData)

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/TemplateBuilder.cs

@@ -23,7 +23,8 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures.Internal
         private bool _readOnly;
         private object _additionalViewData;
 
-        public TemplateBuilder([NotNull] IViewEngine viewEngine,
+        public TemplateBuilder(
+            [NotNull] IViewEngine viewEngine,
             [NotNull] ViewContext viewContext,
             [NotNull] ViewDataDictionary viewData,
             [NotNull] ModelExplorer modelExplorer,

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/UnobtrusiveValidationAttributesGenerator.cs

@@ -45,8 +45,10 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures
             return results;
         }
 
-        private static void ValidateUnobtrusiveValidationRule(ModelClientValidationRule rule,
+        private static void ValidateUnobtrusiveValidationRule(
-            IDictionary<string, object> resultsDictionary, string dictionaryKey)
+            ModelClientValidationRule rule,
+            IDictionary<string, object> resultsDictionary,
+            string dictionaryKey)
         {
             if (string.IsNullOrEmpty(rule.ValidationType))
             {

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/ViewDataDictionary.cs

@@ -28,7 +28,8 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures
         /// </param>
         /// <param name="modelState"><see cref="ModelStateDictionary"/> instance for this scope.</param>
         /// <remarks>For use when creating a <see cref="ViewDataDictionary"/> for a new top-level scope.</remarks>
-        public ViewDataDictionary([NotNull] IModelMetadataProvider metadataProvider,
+        public ViewDataDictionary(
+            [NotNull] IModelMetadataProvider metadataProvider,
             [NotNull] ModelStateDictionary modelState)
             : this(metadataProvider, modelState, declaredModelType: typeof(object))
         {

src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/ViewExecutor.cs

@@ -28,7 +28,8 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures
         /// <param name="viewData">The <see cref="ViewDataDictionary"/> for the view being rendered.</param>
         /// <param name="tempData">The <see cref="ITempDataDictionary"/> for the view being rendered.</param>
         /// <returns>A <see cref="Task"/> that represents the asynchronous rendering.</returns>
-        public static async Task ExecuteAsync([NotNull] IView view,
+        public static async Task ExecuteAsync(
+            [NotNull] IView view,
             [NotNull] ActionContext actionContext,
             [NotNull] ViewDataDictionary viewData,
             [NotNull] ITempDataDictionary tempData,

src/Microsoft.AspNet.Mvc.WebApiCompatShim/ContentNegotiator/StringWithQualityHeaderValueComparer.cs

@@ -40,7 +40,8 @@ namespace System.Net.Http.Formatting
         /// <param name="stringWithQuality1">The first value to compare.</param>
         /// <param name="stringWithQuality2">The second value to compare</param>
         /// <returns>The result of the comparison.</returns>
-        public int Compare(StringWithQualityHeaderValue stringWithQuality1,
+        public int Compare(
+            StringWithQualityHeaderValue stringWithQuality1,
             StringWithQualityHeaderValue stringWithQuality2)
         {
             Debug.Assert(stringWithQuality1 != null);

test/Microsoft.AspNet.Mvc.Core.Test/Formatters/NoContentFormatterTests.cs

@@ -33,7 +33,8 @@ namespace Microsoft.AspNet.Mvc.Formatters
 
         [Theory]
         [MemberData(nameof(OutputFormatterContextValues_CanWriteType))]
-        public void CanWriteResult_ByDefault_ReturnsTrue_IfTheValueIsNull(object value,
+        public void CanWriteResult_ByDefault_ReturnsTrue_IfTheValueIsNull(
+            object value,
             bool declaredTypeAsString,
             bool expectedCanwriteResult,
             bool useNonNullContentType)

test/Microsoft.AspNet.Mvc.Core.Test/Formatters/OutputFormatterTests.cs

@@ -42,7 +42,8 @@ namespace Microsoft.AspNet.Mvc.Formatters
 
         [Theory]
         [MemberData(nameof(SelectResponseCharacterEncodingData))]
-        public void SelectResponseCharacterEncoding_SelectsEncoding(string acceptCharsetHeaders,
+        public void SelectResponseCharacterEncoding_SelectsEncoding(
+            string acceptCharsetHeaders,
             string requestEncoding,
             string[] supportedEncodings,
             string expectedEncoding)

test/Microsoft.AspNet.Mvc.Core.Test/RedirectResultTest.cs

@@ -45,7 +45,8 @@ namespace Microsoft.AspNet.Mvc
         [Theory]
         [InlineData("", "/Home/About", "/Home/About")]
         [InlineData("/myapproot", "/test", "/test")]
-        public void Execute_ReturnsContentPath_WhenItDoesNotStartWithTilde(string appRoot,
+        public void Execute_ReturnsContentPath_WhenItDoesNotStartWithTilde(
+            string appRoot,
             string contentPath,
             string expectedPath)
         {
@@ -72,7 +73,8 @@ namespace Microsoft.AspNet.Mvc
         [InlineData("/", "~/", "/")]
         [InlineData("", "~/Home/About", "/Home/About")]
         [InlineData("/myapproot", "~/", "/myapproot/")]
-        public void Execute_ReturnsAppRelativePath_WhenItStartsWithTilde(string appRoot,
+        public void Execute_ReturnsAppRelativePath_WhenItStartsWithTilde(
+            string appRoot,
             string contentPath,
             string expectedPath)
         {
@@ -110,7 +112,8 @@ namespace Microsoft.AspNet.Mvc
             return serviceCollection.BuildServiceProvider();
         }
 
-        private static HttpContext GetHttpContext(string appRoot,
+        private static HttpContext GetHttpContext(
+            string appRoot,
             string contentPath,
             string expectedPath,
             HttpResponse response)

test/Microsoft.AspNet.Mvc.Core.Test/Routing/UrlHelperTest.cs

@@ -25,7 +25,8 @@ namespace Microsoft.AspNet.Mvc.Routing
         [InlineData("/myapproot", null, null)]
         [InlineData("", "/Home/About", "/Home/About")]
         [InlineData("/myapproot", "/test", "/test")]
-        public void Content_ReturnsContentPath_WhenItDoesNotStartWithToken(string appRoot,
+        public void Content_ReturnsContentPath_WhenItDoesNotStartWithToken(
+            string appRoot,
             string contentPath,
             string expectedPath)
         {
@@ -49,7 +50,8 @@ namespace Microsoft.AspNet.Mvc.Routing
         [InlineData("", "~/Home/About", "/Home/About")]
         [InlineData("/", "~", "/")]
         [InlineData("/myapproot", "~/Content/bootstrap.css", "/myapproot/Content/bootstrap.css")]
-        public void Content_ReturnsAppRelativePath_WhenItStartsWithToken(string appRoot,
+        public void Content_ReturnsAppRelativePath_WhenItStartsWithToken(
+            string appRoot,
             string contentPath,
             string expectedPath)
         {

test/Microsoft.AspNet.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs

@@ -598,7 +598,9 @@ namespace Microsoft.AspNet.Mvc.Formatters.Xml
             XmlAssert.Equal(expectedOutput, content);
         }
 
-        private OutputFormatterContext GetOutputFormatterContext(object outputValue, Type outputType,
+        private OutputFormatterContext GetOutputFormatterContext(
+            object outputValue,
+            Type outputType,
             string contentType = "application/xml; charset=utf-8")
         {
             return new OutputFormatterContext

test/Microsoft.AspNet.Mvc.Razor.Host.Test/MvcCSharpRazorCodeParserTest.cs

@@ -64,7 +64,8 @@ namespace Microsoft.AspNet.Mvc.Razor
         [InlineData("Foo?", "Foo?")]
         [InlineData("Foo[[]][]", "Foo[[]][]")]
         [InlineData("$rootnamespace$.MyModel", "$rootnamespace$.MyModel")]
-        public void ParseModelKeyword_InfersBaseType_FromModelName(string modelName,
+        public void ParseModelKeyword_InfersBaseType_FromModelName(
+            string modelName,
             string expectedModel)
         {
             // Arrange
@@ -270,7 +271,8 @@ namespace Microsoft.AspNet.Mvc.Razor
         [InlineData("  Microsoft.AspNet.Mvc.IHtmlHelper<MyNullableModel[]?>  MyHelper  ",
                     "Microsoft.AspNet.Mvc.IHtmlHelper<MyNullableModel[]?>", "MyHelper")]
         [InlineData("    TestService    @class ", "TestService", "@class")]
-        public void ParseInjectKeyword_InfersTypeAndPropertyName(string injectStatement,
+        public void ParseInjectKeyword_InfersTypeAndPropertyName(
+            string injectStatement,
             string expectedService,
             string expectedPropertyName)
         {
@@ -348,7 +350,8 @@ namespace Microsoft.AspNet.Mvc.Razor
         [Theory]
         [InlineData("IMyService              Service                ", "IMyService", "Service")]
         [InlineData("           TestService    @namespace  ", "TestService", "@namespace")]
-        public void ParseInjectKeyword_ParsesUpToNewLine(string injectStatement,
+        public void ParseInjectKeyword_ParsesUpToNewLine(
+            string injectStatement,
             string expectedService,
             string expectedPropertyName)
         {
@@ -514,7 +517,8 @@ namespace Microsoft.AspNet.Mvc.Razor
             Assert.Equal(expectedErrors, errors);
         }
 
-        private static List<Span> ParseDocument(string documentContents,
+        private static List<Span> ParseDocument(
+            string documentContents,
             List<RazorError> errors = null,
             List<LineMapping> lineMappings = null)
         {

test/Microsoft.AspNet.Mvc.Razor.Host.Test/MvcRazorParserTest.cs

@@ -234,7 +234,8 @@ namespace Microsoft.AspNet.Mvc.Razor
 
         private class TestableMvcRazorParser : MvcRazorParser
         {
-            public TestableMvcRazorParser(RazorParser parser,
+            public TestableMvcRazorParser(
+                RazorParser parser,
                 IReadOnlyList<ChunkTree> chunkTrees,
                 IReadOnlyList<Chunk> defaultInheritedChunks)
                 : base(parser, chunkTrees, defaultInheritedChunks, typeof(ModelExpression).FullName)

test/Microsoft.AspNet.Mvc.Razor.Host.Test/MvcTagHelperAttributeValueCodeRendererTest.cs

@@ -14,7 +14,8 @@ namespace Microsoft.AspNet.Mvc.Razor
         [Theory]
         [InlineData("SomeType", "SomeType", "SomeMethod(__model => __model.MyValue)")]
         [InlineData("SomeType", "SomeType2", "MyValue")]
-        public void RenderAttributeValue_RendersModelExpressionsCorrectly(string modelExpressionType,
+        public void RenderAttributeValue_RendersModelExpressionsCorrectly(
+            string modelExpressionType,
             string propertyType,
             string expectedValue)
         {

test/Microsoft.AspNet.Mvc.Razor.Test/RazorPageTest.cs

@@ -700,7 +700,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                 p.WriteAttribute("href",
                                  new PositionTagged<string>("prefix", 0),
                                  new PositionTagged<string>("suffix", 10),
-                                 new AttributeValue(new PositionTagged<string>("", 6),
+                                 new AttributeValue(new PositionTagged<string>(string.Empty, 6),
                                                     new PositionTagged<object>("true", 6),
                                                     literal: false));
             });
@@ -756,7 +756,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     {
                         new AttributeValue[] {
                             new AttributeValue(
-                                new PositionTagged<string>("", 9),
+                                new PositionTagged<string>(string.Empty, 9),
                                 new PositionTagged<object>("Hello", 9),
                                 literal: true)
                         },
@@ -778,7 +778,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                                 new PositionTagged<object>(null, 10),
                                 literal: false)
                         },
-                        ""
+                        string.Empty
                     },
                     {
                         new AttributeValue[] {
@@ -806,7 +806,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     {
                         new AttributeValue[] {
                             new AttributeValue(
-                                new PositionTagged<string>("", 9),
+                                new PositionTagged<string>(string.Empty, 9),
                                 new PositionTagged<object>("prefix", 9),
                                 literal: true),
                             new AttributeValue(
@@ -859,7 +859,7 @@ namespace Microsoft.AspNet.Mvc.Razor
         }
 
         [Theory]
-        [InlineData(null, "")]
+        [InlineData(null, string.Empty)]
         [InlineData(false, "False")]
         public void AddHtmlAttributeValues_OnlyAddsToAllAttributesWhenAttributeRemoved(
             object attributeValue,
@@ -939,7 +939,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     {
                         new AttributeValue[] {
                             new AttributeValue(
-                                new PositionTagged<string>("", 9),
+                                new PositionTagged<string>(string.Empty, 9),
                                 new PositionTagged<object>(true, 9),
                                 literal: false)
                         },
@@ -948,20 +948,20 @@ namespace Microsoft.AspNet.Mvc.Razor
                     {
                         new AttributeValue[] {
                             new AttributeValue(
-                                new PositionTagged<string>("", 9),
+                                new PositionTagged<string>(string.Empty, 9),
                                 new PositionTagged<object>(false, 9),
                                 literal: false)
                         },
-                        ""
+                        string.Empty
                     },
                     {
                         new AttributeValue[] {
                             new AttributeValue(
-                                new PositionTagged<string>("", 9),
+                                new PositionTagged<string>(string.Empty, 9),
                                 new PositionTagged<object>(null, 9),
                                 literal: false)
                         },
-                        ""
+                        string.Empty
                     },
                     {
                         new AttributeValue[] {
@@ -1007,7 +1007,7 @@ namespace Microsoft.AspNet.Mvc.Razor
             page.HtmlEncoder = new CommonTestEncoder();
             var writer = new StringWriter();
             var prefix = new PositionTagged<string>("someattr=", 0);
-            var suffix = new PositionTagged<string>("", 0);
+            var suffix = new PositionTagged<string>(string.Empty, 0);
 
             // Act
             page.WriteAttributeTo(writer, "someattr", prefix, suffix, attributeValues);
@@ -1059,7 +1059,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.StartTagAndEndTag,
                             preElement:  null,
@@ -1358,7 +1358,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.StartTagAndEndTag,
                             preElement:  "Before",
@@ -1370,7 +1370,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList { { "test", "testVal" } },
                             tagMode: TagMode.SelfClosing,
                             preElement:  "Before",
@@ -1406,7 +1406,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList { { "test", "testVal" } },
                             tagMode: TagMode.StartTagOnly,
                             preElement:  "Before",
@@ -1454,7 +1454,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.StartTagAndEndTag,
                             preElement:  null,
@@ -1466,7 +1466,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList { { "test", "testVal" } },
                             tagMode: TagMode.SelfClosing,
                             preElement:  null,
@@ -1502,7 +1502,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList { { "test", "testVal" } },
                             tagMode: TagMode.StartTagOnly,
                             preElement:  null,
@@ -1574,7 +1574,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.SelfClosing,
                             preElement:  "Before",
@@ -1598,7 +1598,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.StartTagOnly,
                             preElement:  "Before",
@@ -1610,7 +1610,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList(),
                             tagMode: TagMode.StartTagAndEndTag,
                             preElement:  "Before",
@@ -1622,7 +1622,7 @@ namespace Microsoft.AspNet.Mvc.Razor
                     },
                     {
                         GetTagHelperOutput(
-                            tagName:     "",
+                            tagName:     string.Empty,
                             attributes:  new TagHelperAttributeList { { "test", "testVal" } },
                             tagMode: TagMode.StartTagAndEndTag,
                             preElement:  "Before",

test/Microsoft.AspNet.Mvc.Razor.Test/RazorViewEngineTest.cs

@@ -338,7 +338,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Test
 
         [Theory]
         [MemberData(nameof(ViewLocationExpanderTestData))]
-        public void FindView_UsesViewLocationExpandersToLocateViews(IDictionary<string, object> routeValues,
+        public void FindView_UsesViewLocationExpandersToLocateViews(
+            IDictionary<string, object> routeValues,
             IEnumerable<string> expectedSeeds)
         {
             // Arrange
@@ -589,7 +590,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Test
 
         [Theory]
         [MemberData(nameof(ViewLocationExpanderTestData))]
-        public void FindPage_UsesViewLocationExpander_ToExpandPaths(IDictionary<string, object> routeValues,
+        public void FindPage_UsesViewLocationExpander_ToExpandPaths(
+            IDictionary<string, object> routeValues,
             IEnumerable<string> expectedSeeds)
         {
             // Arrange
@@ -1082,7 +1084,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Test
             }
         }
 
-        private RazorViewEngine CreateViewEngine(IRazorPageFactory pageFactory = null,
+        private RazorViewEngine CreateViewEngine(
+            IRazorPageFactory pageFactory = null,
             IRazorViewFactory viewFactory = null,
             IEnumerable<IViewLocationExpander> expanders = null,
             IViewLocationCache cache = null)
@@ -1176,7 +1179,8 @@ namespace Microsoft.AspNet.Mvc.Razor.Test
 
         private class OverloadedLocationViewEngine : RazorViewEngine
         {
-            public OverloadedLocationViewEngine(IRazorPageFactory pageFactory,
+            public OverloadedLocationViewEngine(
+                IRazorPageFactory pageFactory,
                 IRazorViewFactory viewFactory,
                 IOptions<RazorViewEngineOptions> optionsAccessor,
                 IViewLocationCache cache)

test/Microsoft.AspNet.Mvc.TagHelpers.Test/CacheTagHelperTest.cs

@@ -777,7 +777,8 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
                                    new HtmlHelperOptions());
         }
 
-        private static TagHelperContext GetTagHelperContext(string id = "testid",
+        private static TagHelperContext GetTagHelperContext(
+            string id = "testid",
             string childContent = "some child content")
         {
             return new TagHelperContext(

test/Microsoft.AspNet.Mvc.TagHelpers.Test/LabelTagHelperTest.cs

@@ -233,7 +233,8 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
 
         public class TagHelperOutputContent
         {
-            public TagHelperOutputContent(string originalChildContent,
+            public TagHelperOutputContent(
+                string originalChildContent,
                 string outputContent,
                 string expectedContent,
                 string expectedId)

test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperPasswordTest.cs

@@ -41,7 +41,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
 
         [Theory]
         [MemberData(nameof(PasswordWithViewDataAndAttributesData))]
-        public void Password_UsesAttributeValueWhenValueArgumentIsNull(ViewDataDictionary<PasswordModel> vdd,
+        public void Password_UsesAttributeValueWhenValueArgumentIsNull(
+            ViewDataDictionary<PasswordModel> vdd,
             object attributes)
         {
             // Arrange
@@ -58,7 +59,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
 
         [Theory]
         [MemberData(nameof(PasswordWithViewDataAndAttributesData))]
-        public void Password_UsesExplicitValue_IfSpecified(ViewDataDictionary<PasswordModel> vdd,
+        public void Password_UsesExplicitValue_IfSpecified(
+            ViewDataDictionary<PasswordModel> vdd,
             object attributes)
         {
             // Arrange
@@ -219,7 +221,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
 
         [Theory]
         [MemberData(nameof(PasswordWithViewDataAndAttributesData))]
-        public void PasswordForWithAttributes_GeneratesExpectedValue(ViewDataDictionary<PasswordModel> vdd,
+        public void PasswordForWithAttributes_GeneratesExpectedValue(
+            ViewDataDictionary<PasswordModel> vdd,
             object htmlAttributes)
         {
             // Arrange

test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperTest.cs

@@ -137,7 +137,8 @@ namespace Microsoft.AspNet.Mvc.Rendering
 
         [Theory]
         [MemberData(nameof(IgnoreCaseTestData))]
-        public void AnonymousObjectToHtmlAttributes_IgnoresPropertyCase(object htmlAttributeObject,
+        public void AnonymousObjectToHtmlAttributes_IgnoresPropertyCase(
+            object htmlAttributeObject,
             KeyValuePair<string, object> expectedEntry)
         {
             // Act

test/Microsoft.AspNet.Mvc.ViewFeatures.Test/ViewFeatures/ViewDataDictionaryTest.cs

@@ -792,7 +792,8 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures
 
         private class TestViewDataDictionary : ViewDataDictionary
         {
-            public TestViewDataDictionary(IModelMetadataProvider modelMetadataProvider,
+            public TestViewDataDictionary(
+                IModelMetadataProvider modelMetadataProvider,
                 ModelStateDictionary modelState)
                 : base(modelMetadataProvider, modelState)
             {

test/Microsoft.AspNet.Mvc.WebApiCompatShimTest/TestUtils/TestDataSetAttribute.cs

@@ -28,38 +28,56 @@ namespace Microsoft.TestCommon
             ExtraDataSets = new List<Tuple<Type, string>>();
         }
 
-        public TestDataSetAttribute(Type declaringType, string propertyName,
+        public TestDataSetAttribute(
-                                    Type declaringType1, string propertyName1,
+            Type declaringType,
+            string propertyName,
+            Type declaringType1,
+            string propertyName1,
             TestDataVariations testDataVariations = TestCommon.TestDataVariations.All)
             : this(declaringType, propertyName, testDataVariations)
         {
             ExtraDataSets = new List<Tuple<Type, string>> { Tuple.Create(declaringType1, propertyName1) };
         }
 
-        public TestDataSetAttribute(Type declaringType, string propertyName,
+        public TestDataSetAttribute(
-            Type declaringType1, string propertyName1,
+            Type declaringType,
-            Type declaringType2, string propertyName2,
+            string propertyName,
+            Type declaringType1,
+            string propertyName1,
+            Type declaringType2,
+            string propertyName2,
             TestDataVariations testDataVariations = TestCommon.TestDataVariations.All)
             : this(declaringType, propertyName, testDataVariations)
         {
             ExtraDataSets = new List<Tuple<Type, string>> { Tuple.Create(declaringType1, propertyName1), Tuple.Create(declaringType2, propertyName2) };
         }
 
-        public TestDataSetAttribute(Type declaringType, string propertyName,
+        public TestDataSetAttribute(
-            Type declaringType1, string propertyName1,
+            Type declaringType,
-            Type declaringType2, string propertyName2,
+            string propertyName,
-            Type declaringType3, string propertyName3,
+            Type declaringType1,
+            string propertyName1,
+            Type declaringType2,
+            string propertyName2,
+            Type declaringType3,
+            string propertyName3,
             TestDataVariations testDataVariations = TestCommon.TestDataVariations.All)
             : this(declaringType, propertyName, testDataVariations)
         {
             ExtraDataSets = new List<Tuple<Type, string>> { Tuple.Create(declaringType1, propertyName1), Tuple.Create(declaringType2, propertyName2), Tuple.Create(declaringType3, propertyName3) };
         }
 
-        public TestDataSetAttribute(Type declaringType, string propertyName,
+        public TestDataSetAttribute(
-            Type declaringType1, string propertyName1,
+            Type declaringType,
-            Type declaringType2, string propertyName2,
+            string propertyName,
-            Type declaringType3, string propertyName3,
+            Type declaringType1,
-            Type declaringType4, string propertyName4,
+            string propertyName1,
+            Type declaringType2,
+            string propertyName2,
+            Type declaringType3,
+            string propertyName3,
+            Type declaringType4,
+            string propertyName4,
             TestDataVariations testDataVariations = TestCommon.TestDataVariations.All)
             : this(declaringType, propertyName, testDataVariations)
         {