Typos/spelling errors in XML doc comments and source. #Hacktoberfest (#3039)
This commit is contained in:
parent
713e224591
commit
78a0a68cd1
|
|
@ -68,7 +68,7 @@ namespace Microsoft.AspNetCore.SignalR.Crankier
|
||||||
await client.CreateAndStartConnectionAsync(targetAddress, transportType);
|
await client.CreateAndStartConnectionAsync(targetAddress, transportType);
|
||||||
}
|
}
|
||||||
|
|
||||||
Log("Connections connected succesfully");
|
Log("Connections connected successfully");
|
||||||
}
|
}
|
||||||
|
|
||||||
public Task StartTestAsync(TimeSpan sendInterval, int sendBytes)
|
public Task StartTestAsync(TimeSpan sendInterval, int sendBytes)
|
||||||
|
|
@ -80,7 +80,7 @@ namespace Microsoft.AspNetCore.SignalR.Crankier
|
||||||
client.StartTest(sendBytes, sendInterval);
|
client.StartTest(sendBytes, sendInterval);
|
||||||
}
|
}
|
||||||
|
|
||||||
Log("Test started succesfully");
|
Log("Test started successfully");
|
||||||
return Task.CompletedTask;
|
return Task.CompletedTask;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -98,7 +98,7 @@ namespace Microsoft.AspNetCore.SignalR.Crankier
|
||||||
}
|
}
|
||||||
|
|
||||||
_sendStatusCts.Cancel();
|
_sendStatusCts.Cancel();
|
||||||
Log("Connections stopped succesfully");
|
Log("Connections stopped successfully");
|
||||||
_targetConnectionCount = 0;
|
_targetConnectionCount = 0;
|
||||||
|
|
||||||
return Task.CompletedTask;
|
return Task.CompletedTask;
|
||||||
|
|
|
||||||
|
|
@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Internal
|
||||||
// remaining bits (%x0000000) are the lowest bits of the value. The most significant bit of the second
|
// remaining bits (%x0000000) are the lowest bits of the value. The most significant bit of the second
|
||||||
// byte is 0 meaning this is last byte of the VarInt. The actual value bits (%x0101001) need to be
|
// byte is 0 meaning this is last byte of the VarInt. The actual value bits (%x0101001) need to be
|
||||||
// prepended to the bits we already read so the values is %01010010000000 i.e. 0x1480 (5248)
|
// prepended to the bits we already read so the values is %01010010000000 i.e. 0x1480 (5248)
|
||||||
// We support paylads up to 2GB so the biggest number we support is 7fffffff which when encoded as
|
// We support payloads up to 2GB so the biggest number we support is 7fffffff which when encoded as
|
||||||
// VarInt is 0xFF 0xFF 0xFF 0xFF 0x07 - hence the maximum length prefix is 5 bytes.
|
// VarInt is 0xFF 0xFF 0xFF 0xFF 0x07 - hence the maximum length prefix is 5 bytes.
|
||||||
|
|
||||||
var length = 0U;
|
var length = 0U;
|
||||||
|
|
|
||||||
|
|
@ -155,7 +155,7 @@ namespace Microsoft.AspNetCore.Internal
|
||||||
|
|
||||||
public static bool ReadForType(JsonTextReader reader, Type type)
|
public static bool ReadForType(JsonTextReader reader, Type type)
|
||||||
{
|
{
|
||||||
// Explicity read values as dates from JSON with reader.
|
// Explicitly read values as dates from JSON with reader.
|
||||||
// We do this because otherwise dates are read as strings
|
// We do this because otherwise dates are read as strings
|
||||||
// and the JsonSerializer will use a conversion method that won't
|
// and the JsonSerializer will use a conversion method that won't
|
||||||
// preserve UTC in DateTime.Kind for UTC ISO8601 dates
|
// preserve UTC in DateTime.Kind for UTC ISO8601 dates
|
||||||
|
|
|
||||||
|
|
@ -34,7 +34,7 @@ namespace Microsoft.AspNetCore.SignalR.Internal
|
||||||
reader = new Utf8BufferTextReader();
|
reader = new Utf8BufferTextReader();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Taken off the the thread static
|
// Taken off the thread static
|
||||||
_cachedInstance = null;
|
_cachedInstance = null;
|
||||||
#if DEBUG
|
#if DEBUG
|
||||||
if (reader._inUse)
|
if (reader._inUse)
|
||||||
|
|
|
||||||
|
|
@ -43,7 +43,7 @@ namespace Microsoft.AspNetCore.Internal
|
||||||
writer = new Utf8BufferTextWriter();
|
writer = new Utf8BufferTextWriter();
|
||||||
}
|
}
|
||||||
|
|
||||||
// Taken off the the thread static
|
// Taken off the thread static
|
||||||
_cachedInstance = null;
|
_cachedInstance = null;
|
||||||
#if DEBUG
|
#if DEBUG
|
||||||
if (writer._inUse)
|
if (writer._inUse)
|
||||||
|
|
|
||||||
|
|
@ -529,7 +529,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Client
|
||||||
httpMessageHandler = new AccessTokenHttpMessageHandler(httpMessageHandler, this);
|
httpMessageHandler = new AccessTokenHttpMessageHandler(httpMessageHandler, this);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Wrap message handler after HttpMessageHandlerFactory to ensure not overriden
|
// Wrap message handler after HttpMessageHandlerFactory to ensure not overridden
|
||||||
httpMessageHandler = new LoggingHttpMessageHandler(httpMessageHandler, _loggerFactory);
|
httpMessageHandler = new LoggingHttpMessageHandler(httpMessageHandler, _loggerFactory);
|
||||||
|
|
||||||
var httpClient = new HttpClient(httpMessageHandler);
|
var httpClient = new HttpClient(httpMessageHandler);
|
||||||
|
|
|
||||||
|
|
@ -299,7 +299,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
|
||||||
// If the status code is a 204 it means the connection is done
|
// If the status code is a 204 it means the connection is done
|
||||||
if (context.Response.StatusCode == StatusCodes.Status204NoContent)
|
if (context.Response.StatusCode == StatusCodes.Status204NoContent)
|
||||||
{
|
{
|
||||||
// Cancel current request to release any waiting poll and let dispose aquire the lock
|
// Cancel current request to release any waiting poll and let dispose acquire the lock
|
||||||
currentRequestTcs.TrySetCanceled();
|
currentRequestTcs.TrySetCanceled();
|
||||||
|
|
||||||
// We should be able to safely dispose because there's no more data being written
|
// We should be able to safely dispose because there's no more data being written
|
||||||
|
|
@ -312,7 +312,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
|
||||||
}
|
}
|
||||||
else if (resultTask.IsFaulted)
|
else if (resultTask.IsFaulted)
|
||||||
{
|
{
|
||||||
// Cancel current request to release any waiting poll and let dispose aquire the lock
|
// Cancel current request to release any waiting poll and let dispose acquire the lock
|
||||||
currentRequestTcs.TrySetCanceled();
|
currentRequestTcs.TrySetCanceled();
|
||||||
|
|
||||||
// transport task was faulted, we should remove the connection
|
// transport task was faulted, we should remove the connection
|
||||||
|
|
|
||||||
|
|
@ -714,7 +714,7 @@ namespace Microsoft.AspNetCore.SignalR.Client
|
||||||
{
|
{
|
||||||
// Adjust consumed and examined to point to the end of the handshake
|
// Adjust consumed and examined to point to the end of the handshake
|
||||||
// response, this handles the case where invocations are sent in the same payload
|
// response, this handles the case where invocations are sent in the same payload
|
||||||
// as the the negotiate response.
|
// as the negotiate response.
|
||||||
consumed = buffer.Start;
|
consumed = buffer.Start;
|
||||||
examined = consumed;
|
examined = consumed;
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.SignalR.Protocol
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Initializes a new instance of the <see cref="HandshakeResponseMessage"/> class.
|
/// Initializes a new instance of the <see cref="HandshakeResponseMessage"/> class.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="error">An optional response error message. A <c>null</c> error message indicates a succesful handshake.</param>
|
/// <param name="error">An optional response error message. A <c>null</c> error message indicates a successful handshake.</param>
|
||||||
public HandshakeResponseMessage(string error)
|
public HandshakeResponseMessage(string error)
|
||||||
{
|
{
|
||||||
// Note that a response with an empty string for error in the JSON is considered an errored response
|
// Note that a response with an empty string for error in the JSON is considered an errored response
|
||||||
|
|
|
||||||
|
|
@ -12,7 +12,7 @@ namespace Microsoft.AspNetCore.SignalR
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gets the user ID for the specified connection.
|
/// Gets the user ID for the specified connection.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
/// <param name="connection">The connection get get the user ID for.</param>
|
/// <param name="connection">The connection to get the user ID for.</param>
|
||||||
/// <returns>The user ID for the specified connection.</returns>
|
/// <returns>The user ID for the specified connection.</returns>
|
||||||
string GetUserId(HubConnectionContext connection);
|
string GetUserId(HubConnectionContext connection);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -327,7 +327,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests
|
||||||
|
|
||||||
await sseTransport.Output.WriteAsync(new byte[] { 0x42 });
|
await sseTransport.Output.WriteAsync(new byte[] { 0x42 });
|
||||||
|
|
||||||
// For for send request to be in progress
|
// For send request to be in progress
|
||||||
await sendSyncPoint.WaitForSyncPoint();
|
await sendSyncPoint.WaitForSyncPoint();
|
||||||
|
|
||||||
var stopTask = sseTransport.StopAsync();
|
var stopTask = sseTransport.StopAsync();
|
||||||
|
|
|
||||||
|
|
@ -81,7 +81,7 @@ namespace Microsoft.AspNetCore.SignalR.Redis.Tests
|
||||||
// create and run docker container, remove automatically when stopped, map 6379 from the container to 6379 localhost
|
// create and run docker container, remove automatically when stopped, map 6379 from the container to 6379 localhost
|
||||||
// use static name 'redisTestContainer' so if the container doesn't get removed we don't keep adding more
|
// use static name 'redisTestContainer' so if the container doesn't get removed we don't keep adding more
|
||||||
// use redis base docker image
|
// use redis base docker image
|
||||||
// 20 second timeout to allow redis image to be downloaded, should be a rare occurance, only happening when a new version is released
|
// 20 second timeout to allow redis image to be downloaded, should be a rare occurrence, only happening when a new version is released
|
||||||
RunProcessAndThrowIfFailed(_path, $"run --rm -p 6379:6379 --name {_dockerContainerName} -d redis", "redis", logger, TimeSpan.FromSeconds(20));
|
RunProcessAndThrowIfFailed(_path, $"run --rm -p 6379:6379 --name {_dockerContainerName} -d redis", "redis", logger, TimeSpan.FromSeconds(20));
|
||||||
|
|
||||||
// inspect the redis docker image and extract the IPAddress. Necessary when running tests from inside a docker container, spinning up a new docker container for redis
|
// inspect the redis docker image and extract the IPAddress. Necessary when running tests from inside a docker container, spinning up a new docker container for redis
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue