diff --git a/eng/helix/vstest/runtests.cmd b/eng/helix/vstest/runtests.cmd index ef251d8978..9d52fd3429 100644 --- a/eng/helix/vstest/runtests.cmd +++ b/eng/helix/vstest/runtests.cmd @@ -1,14 +1,20 @@ set target=%1 set sdkVersion=%2 set runtimeVersion=%3 -set DOTNET_ROOT=%HELIX_CORRELATION_PAYLOAD%\sdk -powershell.exe -NoProfile -ExecutionPolicy unrestricted -Command "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; &([scriptblock]::Create((Invoke-WebRequest -useb 'https://dot.net/v1/dotnet-install.ps1'))) -Architecture x64 -Version %sdkVersion% -InstallDir %DOTNET_ROOT%" -powershell.exe -NoProfile -ExecutionPolicy unrestricted -Command "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; &([scriptblock]::Create((Invoke-WebRequest -useb 'https://dot.net/v1/dotnet-install.ps1'))) -Architecture x64 -Runtime dotnet -Version %runtimeVersion% -InstallDir %DOTNET_ROOT%" + +set DOTNET_HOME=%HELIX_CORRELATION_PAYLOAD%\sdk +set DOTNET_ROOT=%DOTNET_HOME%\x64 set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1 -set PATH=%DOTNET_ROOT%;%PATH% set DOTNET_MULTILEVEL_LOOKUP=0 set DOTNET_CLI_HOME=%HELIX_CORRELATION_PAYLOAD%\home -set helix=true -%DOTNET_ROOT%\dotnet vstest %target% --logger:trx + +set PATH=%DOTNET_ROOT%;%PATH% + +powershell.exe -NoProfile -ExecutionPolicy unrestricted -Command "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; &([scriptblock]::Create((Invoke-WebRequest -useb 'https://dot.net/v1/dotnet-install.ps1'))) -Architecture x64 -Version %sdkVersion% -InstallDir %DOTNET_ROOT%" +powershell.exe -NoProfile -ExecutionPolicy unrestricted -Command "[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; &([scriptblock]::Create((Invoke-WebRequest -useb 'https://dot.net/v1/dotnet-install.ps1'))) -Architecture x64 -Runtime dotnet -Version %runtimeVersion% -InstallDir %DOTNET_ROOT%" + +set HELIX=true + +%DOTNET_ROOT%\dotnet vstest %target% --logger:trx --logger:console;verbosity=normal diff --git a/eng/scripts/RunPowershell.cmd b/eng/scripts/RunPowershell.cmd index df7f639bbe..d80b1776d0 100644 --- a/eng/scripts/RunPowershell.cmd +++ b/eng/scripts/RunPowershell.cmd @@ -3,4 +3,9 @@ SET _TAIL=%* CALL SET _TAIL=%%_TAIL:*%1=%% -PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; try { & '%~dp0%1' %_TAIL%; exit $LASTEXITCODE } catch { write-host $_; exit 1 }" +SET POWERSHELL=%windir%\System32\WindowsPowerShell\v1.0\powershell.exe + +rem Force 64bit powershell +if /i "%PROCESSOR_ARCHITEW6432%" EQU "AMD64" SET POWERSHELL=%windir%\sysnative\WindowsPowerShell\v1.0\powershell.exe + +%POWERSHELL% -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; try { & '%~dp0%1' %_TAIL%; exit $LASTEXITCODE } catch { write-host $_; exit 1 }" diff --git a/eng/targets/Helix.Common.props b/eng/targets/Helix.Common.props index aa1f9872db..501a8fb692 100644 --- a/eng/targets/Helix.Common.props +++ b/eng/targets/Helix.Common.props @@ -1,4 +1,10 @@ + + + true + + + @@ -6,6 +12,7 @@ + diff --git a/eng/targets/Helix.targets b/eng/targets/Helix.targets index 40617f62fc..6860135ac7 100644 --- a/eng/targets/Helix.targets +++ b/eng/targets/Helix.targets @@ -29,11 +29,16 @@ - <_HelixProjectTargetQueue Include="%(HelixAvailibleTargetQueue.Identity)" Condition="'$(_SelectedPlatforms.Contains(%(Platform)))' == 'true' AND '%(Identity)' == '$(HelixTargetQueue)'" /> + + <_HelixProjectTargetQueue Include="%(HelixAvailibleTargetQueue.Identity)" Condition="'$(_SelectedPlatforms.Contains(%(Platform)))' == 'true' AND '%(EnableByDefault)' == 'true'" /> + + <_HelixProjectTargetQueue Include="%(HelixProjectTargetQueue.Identity)" /> + + <_HelixApplicableTargetQueue Include="%(_HelixProjectTargetQueue.Identity)" Condition="'%(Identity)' == '$(HelixTargetQueue)'" /> - false + false diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs index 9edd9d72ac..49dacb1911 100644 --- a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs +++ b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs @@ -31,7 +31,6 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests private readonly string _dotnetLocation = DotNetCommands.GetDotNetExecutable(RuntimeArchitecture.x64); - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 [ConditionalFact] [RequiresIIS(IISCapability.PoolEnvironmentVariables)] public async Task ExpandEnvironmentVariableInWebConfig() @@ -68,7 +67,6 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests Assert.Contains("HTTP Error 500.0 - ANCM In-Process Handler Load Failure", await response.Content.ReadAsStringAsync()); } - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 [ConditionalFact] public async Task StartsWithDotnetLocationWithoutExe() { @@ -80,7 +78,6 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests await StartAsync(deploymentParameters); } - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 [ConditionalFact] public async Task StartsWithDotnetLocationUppercase() { @@ -92,7 +89,6 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests await StartAsync(deploymentParameters); } - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 [ConditionalTheory] [InlineData("dotnet")] [InlineData("dotnet.EXE")] @@ -113,7 +109,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests } - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 + [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972 [ConditionalTheory] [InlineData(RuntimeArchitecture.x64)] [InlineData(RuntimeArchitecture.x86)] @@ -190,7 +186,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests await StartAsync(deploymentParameters); } - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/6549 + [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972 [ConditionalFact] [RequiresIIS(IISCapability.PoolEnvironmentVariables)] public async Task StartsWithPortableAndBootstraperExe() diff --git a/src/Servers/IIS/IIS/test/FunctionalTest.props b/src/Servers/IIS/IIS/test/FunctionalTest.props index c37d9df700..f9fb3067bb 100644 --- a/src/Servers/IIS/IIS/test/FunctionalTest.props +++ b/src/Servers/IIS/IIS/test/FunctionalTest.props @@ -12,11 +12,17 @@ + + + + + + diff --git a/src/Servers/IIS/IIS/test/IIS.BackwardsCompatibility.FunctionalTests/IIS.BackwardsCompatibility.FunctionalTests.csproj b/src/Servers/IIS/IIS/test/IIS.BackwardsCompatibility.FunctionalTests/IIS.BackwardsCompatibility.FunctionalTests.csproj index b1a2a048f3..3332b13ac4 100644 --- a/src/Servers/IIS/IIS/test/IIS.BackwardsCompatibility.FunctionalTests/IIS.BackwardsCompatibility.FunctionalTests.csproj +++ b/src/Servers/IIS/IIS/test/IIS.BackwardsCompatibility.FunctionalTests/IIS.BackwardsCompatibility.FunctionalTests.csproj @@ -1,14 +1,15 @@  - - netcoreapp3.0 IISBackwardsCompatibility.FunctionalTests True true + true + + diff --git a/src/Servers/IIS/IIS/test/IIS.ForwardsCompatibility.FunctionalTests/IIS.ForwardsCompatibility.FunctionalTests.csproj b/src/Servers/IIS/IIS/test/IIS.ForwardsCompatibility.FunctionalTests/IIS.ForwardsCompatibility.FunctionalTests.csproj index 5509a1f949..12bb180f41 100644 --- a/src/Servers/IIS/IIS/test/IIS.ForwardsCompatibility.FunctionalTests/IIS.ForwardsCompatibility.FunctionalTests.csproj +++ b/src/Servers/IIS/IIS/test/IIS.ForwardsCompatibility.FunctionalTests/IIS.ForwardsCompatibility.FunctionalTests.csproj @@ -1,14 +1,15 @@ - - netcoreapp3.0 IISForwardsCompatibility.FunctionalTests True true + true + + diff --git a/src/Servers/IIS/IIS/test/IIS.FunctionalTests/IIS.FunctionalTests.csproj b/src/Servers/IIS/IIS/test/IIS.FunctionalTests/IIS.FunctionalTests.csproj index aaf700f0f2..2ee13ffc7e 100644 --- a/src/Servers/IIS/IIS/test/IIS.FunctionalTests/IIS.FunctionalTests.csproj +++ b/src/Servers/IIS/IIS/test/IIS.FunctionalTests/IIS.FunctionalTests.csproj @@ -1,14 +1,16 @@ - netcoreapp3.0 IIS.FunctionalTests True true + true + + diff --git a/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs b/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs index b51d293845..f9e302160a 100644 --- a/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs +++ b/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/MofFileTests.cs @@ -15,6 +15,7 @@ namespace IIS.FunctionalTests [ConditionalFact] [OSSkipCondition(OperatingSystems.Linux | OperatingSystems.MacOSX)] [RequiresIIS(IISCapability.TracingModule)] + [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7972 public void CheckMofFile() { var path = Path.Combine(TestPathUtilities.GetSolutionRootDirectory("IISIntegration"), "aspnetcoremodulev2", "aspnetcore", "ancm.mof"); diff --git a/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/RequiresIISAttribute.cs b/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/RequiresIISAttribute.cs index 0476ced47a..8653c2b9ee 100644 --- a/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/RequiresIISAttribute.cs +++ b/src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/RequiresIISAttribute.cs @@ -59,7 +59,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests return; } - var ancmConfigPath = Path.Combine(Environment.SystemDirectory, "inetsrv", "config", "schema", "aspnetcore_schema_v2.xml"); + var ancmConfigPath = Path.Combine(Environment.SystemDirectory, "inetsrv", "config", "schema", "aspnetcore_schema.xml"); if (!File.Exists(ancmConfigPath) && !SkipInVSTSAttribute.RunningInVSTS) {