From 77f29142aa3649fec9246591acb9546cc8e7f105 Mon Sep 17 00:00:00 2001 From: Cesar Blum Silveira Date: Mon, 19 Oct 2015 23:54:49 -0700 Subject: [PATCH] Disable tests that randomly hang on Linux (#442). --- test/Microsoft.AspNet.TestHost.Tests/ClientHandlerTests.cs | 2 +- test/Microsoft.AspNet.TestHost.Tests/TestClientTests.cs | 4 +++- test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/Microsoft.AspNet.TestHost.Tests/ClientHandlerTests.cs b/test/Microsoft.AspNet.TestHost.Tests/ClientHandlerTests.cs index d4092e5ea2..ec7976d685 100644 --- a/test/Microsoft.AspNet.TestHost.Tests/ClientHandlerTests.cs +++ b/test/Microsoft.AspNet.TestHost.Tests/ClientHandlerTests.cs @@ -223,7 +223,7 @@ namespace Microsoft.AspNet.TestHost } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono)] + [OSSkipCondition(OperatingSystems.Linux, SkipReason = "Hangs randomly (issue #422).")] public async Task ExceptionAfterFirstWriteIsReported() { ManualResetEvent block = new ManualResetEvent(false); diff --git a/test/Microsoft.AspNet.TestHost.Tests/TestClientTests.cs b/test/Microsoft.AspNet.TestHost.Tests/TestClientTests.cs index e2ed03d89c..0d19dd88ef 100644 --- a/test/Microsoft.AspNet.TestHost.Tests/TestClientTests.cs +++ b/test/Microsoft.AspNet.TestHost.Tests/TestClientTests.cs @@ -11,6 +11,7 @@ using System.Threading; using System.Threading.Tasks; using Microsoft.AspNet.Builder; using Microsoft.AspNet.Http; +using Microsoft.AspNet.Testing.xunit; using Xunit; namespace Microsoft.AspNet.TestHost @@ -280,7 +281,8 @@ namespace Microsoft.AspNet.TestHost var exception = await Assert.ThrowsAnyAsync(async () => await tcs.Task); } - [Fact] + [ConditionalFact] + [FrameworkSkipCondition(RuntimeFrameworks.CoreCLR, SkipReason = "Hangs randomly (issue #422).")] public async Task ClientCancellationAbortsRequest() { // Arrange diff --git a/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs b/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs index ffbdb0c470..a422818802 100644 --- a/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs +++ b/test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs @@ -13,6 +13,7 @@ using Microsoft.AspNet.Hosting.Startup; using Microsoft.AspNet.Http; using Microsoft.AspNet.Http.Features; using Microsoft.AspNet.Http.Features.Internal; +using Microsoft.AspNet.Testing.xunit; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; @@ -388,7 +389,8 @@ namespace Microsoft.AspNet.TestHost await Assert.ThrowsAsync(() => server.CreateClient().GetAsync("/")); } - [Fact] + [ConditionalFact] + [FrameworkSkipCondition(RuntimeFrameworks.CoreCLR, SkipReason = "Hangs randomly (issue #422).")] public void CancelAborts() { TestServer server = TestServer.Create(app =>