huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

React to "Shrink StringValues" (#8864)

This commit is contained in:
Ben Adams 2019-04-05 20:12:08 +01:00 committed by David Fowler
parent 1b50085835
commit 77380fb27b
8 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Servers/Kestrel/Core/src/BadHttpRequestException.cs
View File

@ -128,7 +128,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
}
[StackTraceHidden]
internal static void Throw(RequestRejectionReason reason, in StringValues detail)
internal static void Throw(RequestRejectionReason reason, StringValues detail)
{
throw GetException(reason, detail.ToString());
}

2
src/Servers/Kestrel/Core/src/Internal/Http/Http1MessageBody.cs
View File

@ -145,7 +145,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
// status code and then close the connection.
if (transferCoding != TransferCoding.Chunked)
{
BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, in transferEncoding);
BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, transferEncoding);
}
// TODO may push more into the wrapper rather than just calling into the message body

20
src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs
View File

@ -1258,7 +1258,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return MaybeUnknown?.TryGetValue(key, out value) ?? false;
}
protected override void SetValueFast(string key, in StringValues value)
protected override void SetValueFast(string key, StringValues value)
{
switch (key.Length)
{
@ -1606,7 +1606,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
SetValueUnknown(key, value);
}
protected override bool AddValueFast(string key, in StringValues value)
protected override bool AddValueFast(string key, StringValues value)
{
switch (key.Length)
{
@ -5337,25 +5337,25 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
}
public void SetRawConnection(in StringValues value, byte[] raw)
public void SetRawConnection(StringValues value, byte[] raw)
{
_bits |= 0x2L;
_headers._Connection = value;
_headers._rawConnection = raw;
}
public void SetRawDate(in StringValues value, byte[] raw)
public void SetRawDate(StringValues value, byte[] raw)
{
_bits |= 0x4L;
_headers._Date = value;
_headers._rawDate = raw;
}
public void SetRawTransferEncoding(in StringValues value, byte[] raw)
public void SetRawTransferEncoding(StringValues value, byte[] raw)
{
_bits |= 0x40L;
_headers._TransferEncoding = value;
_headers._rawTransferEncoding = raw;
}
public void SetRawServer(in StringValues value, byte[] raw)
public void SetRawServer(StringValues value, byte[] raw)
{
_bits |= 0x2000000L;
_headers._Server = value;
@ -5776,7 +5776,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return MaybeUnknown?.TryGetValue(key, out value) ?? false;
}
protected override void SetValueFast(string key, in StringValues value)
protected override void SetValueFast(string key, StringValues value)
{
ValidateHeaderValueCharacters(value);
switch (key.Length)
@ -6081,7 +6081,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
SetValueUnknown(key, value);
}
protected override bool AddValueFast(string key, in StringValues value)
protected override bool AddValueFast(string key, StringValues value)
{
ValidateHeaderValueCharacters(value);
switch (key.Length)
@ -8589,7 +8589,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return MaybeUnknown?.TryGetValue(key, out value) ?? false;
}
protected override void SetValueFast(string key, in StringValues value)
protected override void SetValueFast(string key, StringValues value)
{
ValidateHeaderValueCharacters(value);
switch (key.Length)
@ -8609,7 +8609,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
SetValueUnknown(key, value);
}
protected override bool AddValueFast(string key, in StringValues value)
protected override bool AddValueFast(string key, StringValues value)
{
ValidateHeaderValueCharacters(value);
switch (key.Length)

12
src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs
View File

@ -121,7 +121,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
[MethodImpl(MethodImplOptions.NoInlining)]
protected static StringValues AppendValue(in StringValues existing, string append)
protected static StringValues AppendValue(StringValues existing, string append)
{
return StringValues.Concat(existing, append);
}
@ -157,10 +157,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
protected virtual bool TryGetValueFast(string key, out StringValues value)
{ throw new NotImplementedException(); }
protected virtual void SetValueFast(string key, in StringValues value)
protected virtual void SetValueFast(string key, StringValues value)
{ throw new NotImplementedException(); }
protected virtual bool AddValueFast(string key, in StringValues value)
protected virtual bool AddValueFast(string key, StringValues value)
{ throw new NotImplementedException(); }
protected virtual bool RemoveFast(string key)
@ -259,7 +259,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return TryGetValueFast(key, out value);
}
public static void ValidateHeaderValueCharacters(in StringValues headerValues)
public static void ValidateHeaderValueCharacters(StringValues headerValues)
{
var count = headerValues.Count;
for (var i = 0; i < count; i++)
@ -290,7 +290,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
}
public static unsafe ConnectionOptions ParseConnection(in StringValues connection)
public static unsafe ConnectionOptions ParseConnection(StringValues connection)
{
var connectionOptions = ConnectionOptions.None;
@ -392,7 +392,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return connectionOptions;
}
public static unsafe TransferCoding GetFinalTransferCoding(in StringValues transferEncoding)
public static unsafe TransferCoding GetFinalTransferCoding(StringValues transferEncoding)
{
var transferEncodingOptions = TransferCoding.None;

2
src/Servers/Kestrel/Core/src/Internal/Http/HttpRequestHeaders.cs
View File

@ -24,7 +24,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
[MethodImpl(MethodImplOptions.NoInlining)]
private void SetValueUnknown(string key, in StringValues value)
private void SetValueUnknown(string key, StringValues value)
{
Unknown[key] = value;
}

2
src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseHeaders.cs
View File

@ -64,7 +64,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
[MethodImpl(MethodImplOptions.NoInlining)]
private void SetValueUnknown(string key, in StringValues value)
private void SetValueUnknown(string key, StringValues value)
{
ValidateHeaderNameCharacters(key);
Unknown[key] = value;

2
src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseTrailers.cs
View File

@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}
[MethodImpl(MethodImplOptions.NoInlining)]
private void SetValueUnknown(string key, in StringValues value)
private void SetValueUnknown(string key, StringValues value)
{
ValidateHeaderNameCharacters(key);
Unknown[key] = value;

6
src/Servers/Kestrel/tools/CodeGenerator/KnownHeaders.cs
View File

@ -385,7 +385,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
}}")}
}}")}
{Each(loop.Headers.Where(header => header.EnhancedSetter), header => $@"
public void SetRaw{header.Identifier}(in StringValues value, byte[] raw)
public void SetRaw{header.Identifier}(StringValues value, byte[] raw)
{{
{header.SetBit()};
_headers._{header.Identifier} = value;
@ -425,7 +425,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
return MaybeUnknown?.TryGetValue(key, out value) ?? false;
}}
protected override void SetValueFast(string key, in StringValues value)
protected override void SetValueFast(string key, StringValues value)
{{{(loop.ClassName != "HttpRequestHeaders" ? @"
ValidateHeaderValueCharacters(value);" : "")}
switch (key.Length)
@ -447,7 +447,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
SetValueUnknown(key, value);
}}
protected override bool AddValueFast(string key, in StringValues value)
protected override bool AddValueFast(string key, StringValues value)
{{{(loop.ClassName != "HttpRequestHeaders" ? @"
ValidateHeaderValueCharacters(value);" : "")}
switch (key.Length)