From 762cbde4808bffa4e1aad2271f6eacdda2779fc7 Mon Sep 17 00:00:00 2001 From: Steve Sanderson Date: Sun, 29 Sep 2019 22:25:07 +0100 Subject: [PATCH] CR: Add some "in" plus clean up "using" --- src/Components/Components/src/CascadingValue.cs | 2 +- src/Components/Components/src/ParameterView.cs | 4 ++-- src/Components/Components/src/Rendering/ComponentState.cs | 2 +- src/Components/Components/src/Rendering/RenderBatchBuilder.cs | 1 - 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Components/Components/src/CascadingValue.cs b/src/Components/Components/src/CascadingValue.cs index 626dc89833..db03b3d416 100644 --- a/src/Components/Components/src/CascadingValue.cs +++ b/src/Components/Components/src/CascadingValue.cs @@ -168,7 +168,7 @@ namespace Microsoft.AspNetCore.Components _subscribers.Remove(subscriber); } - private void NotifySubscribers(ParameterViewLifetime lifetime) + private void NotifySubscribers(in ParameterViewLifetime lifetime) { foreach (var subscriber in _subscribers) { diff --git a/src/Components/Components/src/ParameterView.cs b/src/Components/Components/src/ParameterView.cs index 8dafe9c2c5..33f87a5062 100644 --- a/src/Components/Components/src/ParameterView.cs +++ b/src/Components/Components/src/ParameterView.cs @@ -28,12 +28,12 @@ namespace Microsoft.AspNetCore.Components private readonly int _ownerIndex; private readonly IReadOnlyList _cascadingParametersOrNull; - internal ParameterView(ParameterViewLifetime lifetime, RenderTreeFrame[] frames, int ownerIndex) + internal ParameterView(in ParameterViewLifetime lifetime, RenderTreeFrame[] frames, int ownerIndex) : this(lifetime, frames, ownerIndex, null) { } - private ParameterView(ParameterViewLifetime lifetime, RenderTreeFrame[] frames, int ownerIndex, IReadOnlyList cascadingParametersOrNull) + private ParameterView(in ParameterViewLifetime lifetime, RenderTreeFrame[] frames, int ownerIndex, IReadOnlyList cascadingParametersOrNull) { _lifetime = lifetime; _frames = frames; diff --git a/src/Components/Components/src/Rendering/ComponentState.cs b/src/Components/Components/src/Rendering/ComponentState.cs index 08ff8cafc4..dc372424b9 100644 --- a/src/Components/Components/src/Rendering/ComponentState.cs +++ b/src/Components/Components/src/Rendering/ComponentState.cs @@ -157,7 +157,7 @@ namespace Microsoft.AspNetCore.Components.Rendering _renderer.AddToPendingTasks(Component.SetParametersAsync(parameters)); } - public void NotifyCascadingValueChanged(ParameterViewLifetime lifetime) + public void NotifyCascadingValueChanged(in ParameterViewLifetime lifetime) { var directParams = _latestDirectParametersSnapshot != null ? new ParameterView(lifetime, _latestDirectParametersSnapshot.Buffer, 0) diff --git a/src/Components/Components/src/Rendering/RenderBatchBuilder.cs b/src/Components/Components/src/Rendering/RenderBatchBuilder.cs index fcb118e09a..d4223bbce2 100644 --- a/src/Components/Components/src/Rendering/RenderBatchBuilder.cs +++ b/src/Components/Components/src/Rendering/RenderBatchBuilder.cs @@ -3,7 +3,6 @@ using System; using System.Collections.Generic; -using System.Threading; using Microsoft.AspNetCore.Components.RenderTree; namespace Microsoft.AspNetCore.Components.Rendering