huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update comments

This commit is contained in:
Troy Dai 2016-08-05 22:00:37 -07:00
parent a344684d06
commit 74e5777435
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Microsoft.AspNetCore.Authentication.Cookies/CookieAuthenticationHandler.cs
View File

@ -164,7 +164,6 @@ namespace Microsoft.AspNetCore.Authentication.Cookies
return; return;
} }
// REVIEW: Should this check if there was an error, and then if that error was already handled??
var ticket = (await HandleAuthenticateOnceSafeAsync())?.Ticket; var ticket = (await HandleAuthenticateOnceSafeAsync())?.Ticket;
if (ticket != null) if (ticket != null)
{ {

13
src/Microsoft.AspNetCore.Authentication/AuthenticationHandler.cs
View File

@ -234,9 +234,8 @@ namespace Microsoft.AspNetCore.Authentication
} }
/// <summary> /// <summary>
/// Handle the authentication for once. /// Used to ensure HandleAuthenticateAsync is only invoked once. The subsequent calls
/// /// will return the same authenticate result.
/// If the authentication has been done before returns the last authentication result.
/// </summary> /// </summary>
protected Task<AuthenticateResult> HandleAuthenticateOnceAsync() protected Task<AuthenticateResult> HandleAuthenticateOnceAsync()
{ {
@ -249,11 +248,9 @@ namespace Microsoft.AspNetCore.Authentication
} }
/// <summary> /// <summary>
/// Handle the authentication for once. /// Used to ensure HandleAuthenticateAsync is only invoked once safely. The subsequent
/// /// calls will return the same authentication result. Any exceptions will be converted
/// If the authentication has been done before returns the last authentication result. /// into a failed authenticatoin result containing the exception.
/// This method won't throw exception. Any exception thrown during the authentication will be convert
/// to a AuthenticateResult.
/// </summary> /// </summary>
protected async Task<AuthenticateResult> HandleAuthenticateOnceSafeAsync() protected async Task<AuthenticateResult> HandleAuthenticateOnceSafeAsync()
{ {