Update comments
This commit is contained in:
parent
a344684d06
commit
74e5777435
|
|
@ -164,7 +164,6 @@ namespace Microsoft.AspNetCore.Authentication.Cookies
|
|||
return;
|
||||
}
|
||||
|
||||
// REVIEW: Should this check if there was an error, and then if that error was already handled??
|
||||
var ticket = (await HandleAuthenticateOnceSafeAsync())?.Ticket;
|
||||
if (ticket != null)
|
||||
{
|
||||
|
|
|
|||
|
|
@ -234,9 +234,8 @@ namespace Microsoft.AspNetCore.Authentication
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Handle the authentication for once.
|
||||
///
|
||||
/// If the authentication has been done before returns the last authentication result.
|
||||
/// Used to ensure HandleAuthenticateAsync is only invoked once. The subsequent calls
|
||||
/// will return the same authenticate result.
|
||||
/// </summary>
|
||||
protected Task<AuthenticateResult> HandleAuthenticateOnceAsync()
|
||||
{
|
||||
|
|
@ -249,11 +248,9 @@ namespace Microsoft.AspNetCore.Authentication
|
|||
}
|
||||
|
||||
/// <summary>
|
||||
/// Handle the authentication for once.
|
||||
///
|
||||
/// If the authentication has been done before returns the last authentication result.
|
||||
/// This method won't throw exception. Any exception thrown during the authentication will be convert
|
||||
/// to a AuthenticateResult.
|
||||
/// Used to ensure HandleAuthenticateAsync is only invoked once safely. The subsequent
|
||||
/// calls will return the same authentication result. Any exceptions will be converted
|
||||
/// into a failed authenticatoin result containing the exception.
|
||||
/// </summary>
|
||||
protected async Task<AuthenticateResult> HandleAuthenticateOnceSafeAsync()
|
||||
{
|
||||
|
|
|
|||
Loading…
Reference in New Issue