From 74d56ce02435a80dfb4cd59ec666ae82d9bdca6c Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Tue, 1 Jan 2019 19:51:29 -0800 Subject: [PATCH] Ignore markup comments in components Fixes: aspnet/AspNetCoredotnet/aspnetcore-tooling#6184 This gives us parity with the current behavior. Since comments aren't meaningful in a component/render-tree context, we ignore everything inside of them for codegen/lowering. \n\nCommit migrated from https://github.com/dotnet/aspnetcore-tooling/commit/7250dd262492e675661f011d5677a7d97182d52c --- .../src/DefaultRazorIntermediateNodeLoweringPhase.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs b/src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs index 84f4d12f8f..290b9d3bd9 100644 --- a/src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs +++ b/src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs @@ -1331,6 +1331,11 @@ namespace Microsoft.AspNetCore.Razor.Language }); } + public override void VisitMarkupCommentBlock(MarkupCommentBlockSyntax node) + { + // Comments are ignored by components. We skip over anything that appears inside. + } + public override void VisitCSharpTemplateBlock(CSharpTemplateBlockSyntax node) { var templateNode = new TemplateIntermediateNode();