huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update SocketOutputTests to account for the "immediate" Write param

This commit is contained in:
Stephen Halter 2015-07-29 20:03:04 -07:00
parent 6ff894bb19
commit 7446fe4cc7
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.AspNet.Server.Kestrel/Http/SocketOutput.cs
View File

@ -36,7 +36,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
_callbacksPending = new Queue<CallbackContext>();
}
public void Write(ArraySegment<byte> buffer, Action<Exception, object> callback, object state, bool immediate)
public void Write(ArraySegment<byte> buffer, Action<Exception, object> callback, object state, bool immediate = true)
{
//TODO: need buffering that works
var copy = new byte[buffer.Count];

6
test/Microsoft.AspNet.Server.KestrelTests/SocketOutputTests.cs
View File

@ -51,7 +51,7 @@ namespace Microsoft.AspNet.Server.KestrelTests
};
// Act
socketOutput.Write(buffer, onCompleted, state: null);
socketOutput.Write(buffer, onCompleted, null);
// Assert
Assert.True(completedWh.Wait(100));
@ -94,14 +94,14 @@ namespace Microsoft.AspNet.Server.KestrelTests
};
// Act
socketOutput.Write(buffer, onCompleted, state: null);
socketOutput.Write(buffer, onCompleted, null);
// Assert
// The first write should pre-complete since it is <= _maxBytesPreCompleted.
Assert.True(completedWh.Wait(100));
// Arrange
completedWh.Reset();
// Act
socketOutput.Write(buffer, onCompleted, state: null);
socketOutput.Write(buffer, onCompleted, null);
// Assert
// Too many bytes are already pre-completed for the second write to pre-complete.
Assert.False(completedWh.Wait(100));