Fix WebSocket race in E2E test (#809)

This commit is contained in:
BrennanConroy 2017-08-31 15:30:55 -07:00 committed by GitHub
parent 8ec2848646
commit 7418785a5e
1 changed files with 12 additions and 1 deletions

View File

@ -157,7 +157,18 @@ namespace Microsoft.AspNetCore.SignalR.Tests
}
logger.LogInformation("Sending {length} byte message", bytes.Length);
await connection.SendAsync(bytes).OrTimeout();
try
{
await connection.SendAsync(bytes).OrTimeout();
}
catch (OperationCanceledException)
{
// Because the server and client are run in the same process there is a race where websocket.SendAsync
// can send a message but before returning be suspended allowing the server to run the EchoEndpoint and
// send a close frame which triggers a cancellation token on the client and cancels the websocket.SendAsync.
// Our solution to this is to just catch OperationCanceledException from the sent message if the race happens
// because we know the send went through, and its safe to check the response.
}
logger.LogInformation("Sent message", bytes.Length);
logger.LogInformation("Receiving message");