From 732ae3d030feb425844c746b68fa651ea29ddce7 Mon Sep 17 00:00:00 2001 From: Chris Ross Date: Tue, 18 Mar 2014 12:01:57 -0700 Subject: [PATCH] Code review cleanup. --- src/Microsoft.AspNet.Abstractions/QueryString.cs | 6 +++--- .../DefaultCanHasRequestCookies.cs | 2 +- .../DefaultCanHasResponseCookies.cs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Microsoft.AspNet.Abstractions/QueryString.cs b/src/Microsoft.AspNet.Abstractions/QueryString.cs index 0bca5c7262..5109294bb6 100644 --- a/src/Microsoft.AspNet.Abstractions/QueryString.cs +++ b/src/Microsoft.AspNet.Abstractions/QueryString.cs @@ -23,7 +23,7 @@ namespace Microsoft.AspNet.Abstractions { if (!string.IsNullOrEmpty(value) && value[0] != '?') { - throw new ArgumentException("The leading '?' must be included for a non-empty query."); + throw new ArgumentException("The leading '?' must be included for a non-empty query.", "value"); } _value = value; } @@ -51,7 +51,7 @@ namespace Microsoft.AspNet.Abstractions /// public bool HasValue { - get { return !String.IsNullOrEmpty(_value); } + get { return !string.IsNullOrEmpty(_value); } } /// @@ -75,7 +75,7 @@ namespace Microsoft.AspNet.Abstractions public string ToUriComponent() { // Escape things properly so System.Uri doesn't mis-interpret the data. - return HasValue ? _value.Replace("#", "%23") : String.Empty; + return HasValue ? _value.Replace("#", "%23") : string.Empty; } /// diff --git a/src/Microsoft.AspNet.PipelineCore/DefaultCanHasRequestCookies.cs b/src/Microsoft.AspNet.PipelineCore/DefaultCanHasRequestCookies.cs index b6071c4d41..5aff939af5 100644 --- a/src/Microsoft.AspNet.PipelineCore/DefaultCanHasRequestCookies.cs +++ b/src/Microsoft.AspNet.PipelineCore/DefaultCanHasRequestCookies.cs @@ -11,7 +11,7 @@ namespace Microsoft.AspNet.PipelineCore public class DefaultCanHasRequestCookies : ICanHasRequestCookies { private readonly IFeatureCollection _features; - private FeatureReference _request = FeatureReference.Default; + private readonly FeatureReference _request = FeatureReference.Default; private string _cookiesHeader; private RequestCookiesCollection _cookiesCollection; private static readonly string[] ZeroHeaders = new string[0]; diff --git a/src/Microsoft.AspNet.PipelineCore/DefaultCanHasResponseCookies.cs b/src/Microsoft.AspNet.PipelineCore/DefaultCanHasResponseCookies.cs index c908b7fa11..c0b51b27cb 100644 --- a/src/Microsoft.AspNet.PipelineCore/DefaultCanHasResponseCookies.cs +++ b/src/Microsoft.AspNet.PipelineCore/DefaultCanHasResponseCookies.cs @@ -9,7 +9,7 @@ namespace Microsoft.AspNet.PipelineCore public class DefaultCanHasResponseCookies : ICanHasResponseCookies { private readonly IFeatureCollection _features; - private FeatureReference _request = FeatureReference.Default; + private readonly FeatureReference _request = FeatureReference.Default; private IResponseCookiesCollection _cookiesCollection; public DefaultCanHasResponseCookies(IFeatureCollection features) @@ -21,9 +21,9 @@ namespace Microsoft.AspNet.PipelineCore { get { - var headers = _request.Fetch(_features).Headers; if (_cookiesCollection == null) { + var headers = _request.Fetch(_features).Headers; _cookiesCollection = new ResponseCookiesCollection(new HeaderDictionary(headers)); }