From 7248ecbaf1a5e1b8a2ceba9b918e9b74109add12 Mon Sep 17 00:00:00 2001 From: Ryan Brandenburg Date: Wed, 27 Mar 2019 10:20:16 -0700 Subject: [PATCH] Make some skipped tests flaky (#8795) --- src/Hosting/test/FunctionalTests/ShutdownTests.cs | 2 +- .../test/InMemory.FunctionalTests/ConnectionLimitTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Hosting/test/FunctionalTests/ShutdownTests.cs b/src/Hosting/test/FunctionalTests/ShutdownTests.cs index ce075537ae..0d7210cd0d 100644 --- a/src/Hosting/test/FunctionalTests/ShutdownTests.cs +++ b/src/Hosting/test/FunctionalTests/ShutdownTests.cs @@ -28,6 +28,7 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests [ConditionalFact] [OSSkipCondition(OperatingSystems.Windows)] [OSSkipCondition(OperatingSystems.MacOSX)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1687", FlakyOn.AzP.Linux)] public async Task ShutdownTestRun() { await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run"); @@ -116,7 +117,6 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests } } - private static void SendSIGINT(int processId) { var startInfo = new ProcessStartInfo diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/ConnectionLimitTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/ConnectionLimitTests.cs index a8625bfb99..fc9c256112 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/ConnectionLimitTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/ConnectionLimitTests.cs @@ -147,7 +147,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests } [Fact] - [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "https://github.com/aspnet/KestrelHttpServer/issues/2282")] + [Flaky("https://github.com/aspnet/KestrelHttpServer/issues/2282", FlakyOn.AzP.macOS)] public async Task ConnectionCountingReturnsToZero() { const int count = 100;