huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Mark tests flaky instead of skipped (#8727) 

Mark tests flaky instead of skipped
This commit is contained in:
Ryan Brandenburg 2019-03-26 09:51:37 -07:00 committed by GitHub
parent 341cd25e05
commit 70cd5f5f9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
21 changed files with 73 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Components/test/E2ETest/Tests/EventTest.cs
View File

@ -135,7 +135,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
} }
[Fact] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1987", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1987", FlakyOn.AzP.Windows)]
public void InputEvent_RespondsOnKeystrokes() public void InputEvent_RespondsOnKeystrokes()
{ {
MountTestComponent<InputEventComponent>(); MountTestComponent<InputEventComponent>();

3
src/Hosting/test/FunctionalTests/ShutdownTests.cs
View File

@ -33,7 +33,8 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run"); await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run");
} }
[ConditionalFact(Skip = "https://github.com/aspnet/Hosting/issues/1214")] [ConditionalFact]
[Flaky("https://github.com/aspnet/Hosting/issues/1214", FlakyOn.All)]
[OSSkipCondition(OperatingSystems.Windows)] [OSSkipCondition(OperatingSystems.Windows)]
[OSSkipCondition(OperatingSystems.MacOSX)] [OSSkipCondition(OperatingSystems.MacOSX)]
public async Task ShutdownTestWaitForShutdown() public async Task ShutdownTestWaitForShutdown()

2
src/Identity/EntityFrameworkCore/test/EF.Test/UserStoreEncryptPersonalDataTest.cs
View File

@ -292,4 +292,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test
=> Task.CompletedTask; => Task.CompletedTask;
} }
} }

4
src/Middleware/WebSockets/test/UnitTests/WebSocketMiddlewareTests.cs
View File

@ -8,6 +8,7 @@ using System.Net.WebSockets;
using System.Text; using System.Text;
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.AspNetCore.WebSockets.Internal; using Microsoft.AspNetCore.WebSockets.Internal;
using Microsoft.Extensions.Logging.Testing; using Microsoft.Extensions.Logging.Testing;
@ -549,7 +550,8 @@ namespace Microsoft.AspNetCore.WebSockets.Test
} }
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8187")] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore/issues/8187", FlakyOn.Helix.All)]
public async Task OriginIsNotValidatedForNonWebSocketRequests() public async Task OriginIsNotValidatedForNonWebSocketRequests()
{ {
using (var server = KestrelWebSocketHelpers.CreateServer(LoggerFactory, out var port, context => using (var server = KestrelWebSocketHelpers.CreateServer(LoggerFactory, out var port, context =>

2
src/Mvc/Mvc.Core/test/ApplicationModels/DefaultApplicationModelProviderTest.cs
View File

@ -1004,7 +1004,7 @@ namespace Microsoft.AspNetCore.Mvc.ApplicationModels
Assert.Empty(action.Attributes); Assert.Empty(action.Attributes);
} }
[Theory(Skip = "See aspnet/AspNetCore#4417")] [Theory(Skip = "https://github.com/aspnet/AspNetCore/issues/4417")]
[InlineData(typeof(SingleRouteAttributeController))] [InlineData(typeof(SingleRouteAttributeController))]
[InlineData(typeof(MultipleRouteAttributeController))] [InlineData(typeof(MultipleRouteAttributeController))]
public void CreateActionModel_RouteOnController_CreatesOneActionInfoPerRouteTemplateOnAction(Type controller) public void CreateActionModel_RouteOnController_CreatesOneActionInfoPerRouteTemplateOnAction(Type controller)

2
src/Mvc/Mvc.Core/test/Formatters/SystemTextJsonInputFormatterTest.cs
View File

@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
{ {
return base.ReadAsync_UsesTryAddModelValidationErrorsToModelState(); return base.ReadAsync_UsesTryAddModelValidationErrorsToModelState();
} }
[Fact(Skip = "https://github.com/dotnet/corefx/issues/36026")] [Fact(Skip = "https://github.com/dotnet/corefx/issues/36026")]
public override Task ReadAsync_ReadsValidArray_AsCollectionOfT() public override Task ReadAsync_ReadsValidArray_AsCollectionOfT()
{ {

2
src/Mvc/test/Mvc.FunctionalTests/SystemTextJsonInputFormatterTest.cs
View File

@ -22,4 +22,4 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
return base.JsonInputFormatter_ReturnsDefaultValue_ForValueTypes(input); return base.JsonInputFormatter_ReturnsDefaultValue_ForValueTypes(input);
} }
} }
} }

8
src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesUsingCookieConsentTest.cs
View File

@ -8,6 +8,8 @@ using System.Net;
using System.Net.Http; using System.Net.Http;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.Net.Http.Headers; using Microsoft.Net.Http.Headers;
using Xunit; using Xunit;
@ -28,7 +30,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
private static void ConfigureWebHostBuilder(IWebHostBuilder builder) => private static void ConfigureWebHostBuilder(IWebHostBuilder builder) =>
builder.UseStartup<BasicWebSite.StartupWithCookieTempDataProviderAndCookieConsent>(); builder.UseStartup<BasicWebSite.StartupWithCookieTempDataProviderAndCookieConsent>();
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1803", FlakyOn.AzP.Windows)]
public async Task CookieTempDataProviderCookie_SetInResponse_OnGrantingConsent() public async Task CookieTempDataProviderCookie_SetInResponse_OnGrantingConsent()
{ {
// Arrange // Arrange
@ -61,7 +64,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1803", FlakyOn.AzP.Windows)]
public async Task CookieTempDataProviderCookie_NotSetInResponse_OnNoConsent() public async Task CookieTempDataProviderCookie_NotSetInResponse_OnNoConsent()
{ {
// Arrange // Arrange

13
src/Mvc/test/Mvc.FunctionalTests/ViewEngineTests.cs
View File

@ -464,19 +464,6 @@ Partial";
Assert.Equal(expected, responseContent, ignoreLineEndingDifferences: true); Assert.Equal(expected, responseContent, ignoreLineEndingDifferences: true);
} }
[Fact(Skip = "https://github.com/aspnet/Mvc/issues/8754")]
public async Task ViewEngine_ResolvesPathsWithSlashesThatDoNotHaveExtensions()
{
// Arrange
var expected = @"<embdedded-layout>Hello from EmbeddedHome\EmbeddedPartial</embdedded-layout>";
// Act
var responseContent = await Client.GetStringAsync("/EmbeddedViews/RelativeNonPath");
// Assert
Assert.Equal(expected, responseContent.Trim());
}
[Fact] [Fact]
public async Task ViewEngine_DiscoversViewsFromPagesSharedDirectory() public async Task ViewEngine_DiscoversViewsFromPagesSharedDirectory()
{ {

3
src/Servers/IIS/IIS/test/Common.FunctionalTests/AppOfflineTests.cs
View File

@ -221,7 +221,8 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
{ {
var deploymentResult = await AssertStarts(hostingModel); var deploymentResult = await AssertStarts(hostingModel);
var load = Helpers.StressLoad(deploymentResult.HttpClient, "/HelloWorld", response => { var load = Helpers.StressLoad(deploymentResult.HttpClient, "/HelloWorld", response =>
{
var statusCode = (int)response.StatusCode; var statusCode = (int)response.StatusCode;
// Test failure involves the stress load receiving a 400 Bad Request. // Test failure involves the stress load receiving a 400 Bad Request.
// We think it is due to IIS returning the 400 itself, but need to confirm the hypothesis. // We think it is due to IIS returning the 400 itself, but need to confirm the hypothesis.

9
src/Servers/IIS/IIS/test/Common.FunctionalTests/ConfigurationChangeTests.cs
View File

@ -34,7 +34,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
await deploymentResult.AssertStarts(); await deploymentResult.AssertStarts();
// Just "touching" web.config should be enough // Just "touching" web.config should be enough
deploymentResult.ModifyWebConfig(element => {}); deploymentResult.ModifyWebConfig(element => { });
await deploymentResult.AssertRecycledAsync(); await deploymentResult.AssertRecycledAsync();
} }
@ -49,7 +49,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
var processBefore = await deploymentResult.HttpClient.GetStringAsync("/ProcessId"); var processBefore = await deploymentResult.HttpClient.GetStringAsync("/ProcessId");
// Just "touching" web.config should be enough // Just "touching" web.config should be enough
deploymentResult.ModifyWebConfig(element => {}); deploymentResult.ModifyWebConfig(element => { });
// Have to retry here to allow ANCM to receive notification and react to it // Have to retry here to allow ANCM to receive notification and react to it
// Verify that worker process gets restarted with new process id // Verify that worker process gets restarted with new process id
@ -88,7 +88,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
var deploymentResult = await DeployAsync(Fixture.GetBaseDeploymentParameters(hostingModel)); var deploymentResult = await DeployAsync(Fixture.GetBaseDeploymentParameters(hostingModel));
await deploymentResult.AssertStarts(); await deploymentResult.AssertStarts();
var load = Helpers.StressLoad(deploymentResult.HttpClient, "/HelloWorld", response => { var load = Helpers.StressLoad(deploymentResult.HttpClient, "/HelloWorld", response =>
{
var statusCode = (int)response.StatusCode; var statusCode = (int)response.StatusCode;
Assert.True(statusCode == 200 || statusCode == 503, "Status code was " + statusCode); Assert.True(statusCode == 200 || statusCode == 503, "Status code was " + statusCode);
}); });
@ -97,7 +98,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
{ {
// ModifyWebConfig might fail if web.config is being read by IIS // ModifyWebConfig might fail if web.config is being read by IIS
RetryHelper.RetryOperation( RetryHelper.RetryOperation(
() => deploymentResult.ModifyWebConfig(element => {}), () => deploymentResult.ModifyWebConfig(element => { }),
e => Logger.LogError($"Failed to touch web.config : {e.Message}"), e => Logger.LogError($"Failed to touch web.config : {e.Message}"),
retryCount: 3, retryCount: 3,
retryDelayMilliseconds: RetryDelay.Milliseconds); retryDelayMilliseconds: RetryDelay.Milliseconds);

24
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs
View File

@ -430,42 +430,48 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
var pathWithSpace = "\u03c0 \u2260 3\u00b714"; var pathWithSpace = "\u03c0 \u2260 3\u00b714";
dictionary.Add("App in bin subdirectory full path to dll using exec and quotes", dictionary.Add("App in bin subdirectory full path to dll using exec and quotes",
parameters => { parameters =>
{
MoveApplication(parameters, "bin"); MoveApplication(parameters, "bin");
parameters.TransformArguments((arguments, root) => "exec " + Path.Combine(root, "bin", arguments)); parameters.TransformArguments((arguments, root) => "exec " + Path.Combine(root, "bin", arguments));
return ""; return "";
}); });
dictionary.Add("App in subdirectory with space", dictionary.Add("App in subdirectory with space",
parameters => { parameters =>
{
MoveApplication(parameters, pathWithSpace); MoveApplication(parameters, pathWithSpace);
parameters.TransformArguments((arguments, root) => Path.Combine(pathWithSpace, arguments)); parameters.TransformArguments((arguments, root) => Path.Combine(pathWithSpace, arguments));
return ""; return "";
}); });
dictionary.Add("App in subdirectory with space and full path to dll", dictionary.Add("App in subdirectory with space and full path to dll",
parameters => { parameters =>
{
MoveApplication(parameters, pathWithSpace); MoveApplication(parameters, pathWithSpace);
parameters.TransformArguments((arguments, root) => Path.Combine(root, pathWithSpace, arguments)); parameters.TransformArguments((arguments, root) => Path.Combine(root, pathWithSpace, arguments));
return ""; return "";
}); });
dictionary.Add("App in bin subdirectory with space full path to dll using exec and quotes", dictionary.Add("App in bin subdirectory with space full path to dll using exec and quotes",
parameters => { parameters =>
{
MoveApplication(parameters, pathWithSpace); MoveApplication(parameters, pathWithSpace);
parameters.TransformArguments((arguments, root) => "exec \"" + Path.Combine(root, pathWithSpace, arguments) + "\" extra arguments"); parameters.TransformArguments((arguments, root) => "exec \"" + Path.Combine(root, pathWithSpace, arguments) + "\" extra arguments");
return "extra|arguments"; return "extra|arguments";
}); });
dictionary.Add("App in bin subdirectory and quoted argument", dictionary.Add("App in bin subdirectory and quoted argument",
parameters => { parameters =>
{
MoveApplication(parameters, "bin"); MoveApplication(parameters, "bin");
parameters.TransformArguments((arguments, root) => Path.Combine("bin", arguments) + " \"extra argument\""); parameters.TransformArguments((arguments, root) => Path.Combine("bin", arguments) + " \"extra argument\"");
return "extra argument"; return "extra argument";
}); });
dictionary.Add("App in bin subdirectory full path to dll", dictionary.Add("App in bin subdirectory full path to dll",
parameters => { parameters =>
{
MoveApplication(parameters, "bin"); MoveApplication(parameters, "bin");
parameters.TransformArguments((arguments, root) => Path.Combine(root, "bin", arguments) + " extra arguments"); parameters.TransformArguments((arguments, root) => Path.Combine(root, "bin", arguments) + " extra arguments");
return "extra|arguments"; return "extra|arguments";
@ -495,7 +501,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
var pathWithSpace = "\u03c0 \u2260 3\u00b714"; var pathWithSpace = "\u03c0 \u2260 3\u00b714";
dictionary.Add("App in subdirectory", dictionary.Add("App in subdirectory",
parameters => { parameters =>
{
MoveApplication(parameters, pathWithSpace); MoveApplication(parameters, pathWithSpace);
parameters.TransformPath((path, root) => Path.Combine(pathWithSpace, path)); parameters.TransformPath((path, root) => Path.Combine(pathWithSpace, path));
parameters.TransformArguments((arguments, root) => "\"additional argument\""); parameters.TransformArguments((arguments, root) => "\"additional argument\"");
@ -503,7 +510,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
}); });
dictionary.Add("App in bin subdirectory full path", dictionary.Add("App in bin subdirectory full path",
parameters => { parameters =>
{
MoveApplication(parameters, pathWithSpace); MoveApplication(parameters, pathWithSpace);
parameters.TransformPath((path, root) => Path.Combine(root, pathWithSpace, path)); parameters.TransformPath((path, root) => Path.Combine(root, pathWithSpace, path));
parameters.TransformArguments((arguments, root) => "additional arguments"); parameters.TransformArguments((arguments, root) => "additional arguments");

5
src/Servers/IIS/IIS/test/Common.FunctionalTests/OutOfProcess/HelloWorldTest.cs
View File

@ -32,7 +32,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
{ {
var deploymentParameters = Fixture.GetBaseDeploymentParameters(variant); var deploymentParameters = Fixture.GetBaseDeploymentParameters(variant);
deploymentParameters.ServerConfigActionList.Add( deploymentParameters.ServerConfigActionList.Add(
(element, _) => { (element, _) =>
{
element element
.RequiredElement("system.webServer") .RequiredElement("system.webServer")
.RequiredElement("security") .RequiredElement("security")
@ -68,7 +69,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
Assert.Equal(deploymentResult.ContentRoot, await deploymentResult.HttpClient.GetStringAsync("/ContentRootPath")); Assert.Equal(deploymentResult.ContentRoot, await deploymentResult.HttpClient.GetStringAsync("/ContentRootPath"));
Assert.Equal(deploymentResult.ContentRoot + "\\wwwroot", await deploymentResult.HttpClient.GetStringAsync("/WebRootPath")); Assert.Equal(deploymentResult.ContentRoot + "\\wwwroot", await deploymentResult.HttpClient.GetStringAsync("/WebRootPath"));
var expectedDll = "aspnetcorev2.dll"; var expectedDll = "aspnetcorev2.dll";
Assert.Contains(deploymentResult.HostProcess.Modules.OfType<ProcessModule>(), m=> m.FileName.Contains(expectedDll)); Assert.Contains(deploymentResult.HostProcess.Modules.OfType<ProcessModule>(), m => m.FileName.Contains(expectedDll));
if (DeployerSelector.HasNewHandler && variant.HostingModel == HostingModel.InProcess) if (DeployerSelector.HasNewHandler && variant.HostingModel == HostingModel.InProcess)
{ {

5
src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
View File

@ -221,7 +221,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1817", FlakyOn.All)] [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1817", FlakyOn.AzP.Windows)]
public async Task ReaderThrowsResetExceptionOnInvalidBody() public async Task ReaderThrowsResetExceptionOnInvalidBody()
{ {
var requestStartedCompletionSource = CreateTaskCompletionSource(); var requestStartedCompletionSource = CreateTaskCompletionSource();
@ -319,7 +319,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
var requestAborted = CreateTaskCompletionSource(); var requestAborted = CreateTaskCompletionSource();
using (var testServer = await TestServer.Create( using (var testServer = await TestServer.Create(
async ctx => { async ctx =>
{
ctx.RequestAborted.Register(() => requestAborted.SetResult(true)); ctx.RequestAborted.Register(() => requestAborted.SetResult(true));
requestStarted.SetResult(true); requestStarted.SetResult(true);
await requestAborted.Task; await requestAborted.Task;

3
src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs
View File

@ -112,7 +112,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
private bool LargeUploadRetryPredicate(Exception e) private bool LargeUploadRetryPredicate(Exception e)
=> e is IOException && e.Message.Contains("Unable to read data from the transport connection: The I/O operation has been aborted because of either a thread exit or an application request"); => e is IOException && e.Message.Contains("Unable to read data from the transport connection: The I/O operation has been aborted because of either a thread exit or an application request");
[Theory(Skip = "https://github.com/aspnet/AspNetCore/issues/8054")] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore/issues/8054", FlakyOn.AzP.Windows)]
[RetryTest(nameof(LargeUploadRetryPredicate), [RetryTest(nameof(LargeUploadRetryPredicate),
"Active investigation into potential corefx sockets bug: https://github.com/dotnet/corefx/issues/30691", "Active investigation into potential corefx sockets bug: https://github.com/dotnet/corefx/issues/30691",
OperatingSystems.Windows, OperatingSystems.Windows,

3
src/Servers/Kestrel/test/FunctionalTests/ResponseTests.cs
View File

@ -341,7 +341,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
Assert.True(requestAborted.Task.IsCompleted); Assert.True(requestAborted.Task.IsCompleted);
} }
[Theory(Skip = "https://github.com/aspnet/AspNetCore/issues/7342")] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore/issues/7342", FlakyOn.All)]
[MemberData(nameof(ConnectionAdapterData))] [MemberData(nameof(ConnectionAdapterData))]
public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions) public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)
{ {

23
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs
View File

@ -128,7 +128,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
public async Task HEADERS_ReceivedWithoutAllCONTINUATIONs_WithinRequestHeadersTimeout_AbortsConnection() public async Task HEADERS_ReceivedWithoutAllCONTINUATIONs_WithinRequestHeadersTimeout_AbortsConnection()
{ {
var mockSystemClock = _serviceContext.MockSystemClock; var mockSystemClock = _serviceContext.MockSystemClock;
var limits = _serviceContext.ServerOptions.Limits;; var limits = _serviceContext.ServerOptions.Limits; ;
_timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks); _timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks);
@ -154,8 +154,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
Http2ErrorCode.INTERNAL_ERROR, Http2ErrorCode.INTERNAL_ERROR,
CoreStrings.BadRequest_RequestHeadersTimeout); CoreStrings.BadRequest_RequestHeadersTimeout);
_mockConnectionContext.Verify(c =>c.Abort(It.Is<ConnectionAbortedException>(e => _mockConnectionContext.Verify(c => c.Abort(It.Is<ConnectionAbortedException>(e =>
e.Message == CoreStrings.BadRequest_RequestHeadersTimeout)), Times.Once); e.Message == CoreStrings.BadRequest_RequestHeadersTimeout)), Times.Once);
_mockTimeoutHandler.VerifyNoOtherCalls(); _mockTimeoutHandler.VerifyNoOtherCalls();
_mockConnectionContext.VerifyNoOtherCalls(); _mockConnectionContext.VerifyNoOtherCalls();
@ -175,7 +175,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
await WaitForConnectionStopAsync(expectedLastStreamId: 0, ignoreNonGoAwayFrames: false); await WaitForConnectionStopAsync(expectedLastStreamId: 0, ignoreNonGoAwayFrames: false);
AdvanceClock(TimeSpan.FromSeconds(_bytesReceived / limits.MinResponseDataRate.BytesPerSecond) + AdvanceClock(TimeSpan.FromSeconds(_bytesReceived / limits.MinResponseDataRate.BytesPerSecond) +
limits.MinResponseDataRate.GracePeriod + Heartbeat.Interval - TimeSpan.FromSeconds(.5)); limits.MinResponseDataRate.GracePeriod + Heartbeat.Interval - TimeSpan.FromSeconds(.5));
_mockTimeoutHandler.Verify(h => h.OnTimeout(It.IsAny<TimeoutReason>()), Times.Never); _mockTimeoutHandler.Verify(h => h.OnTimeout(It.IsAny<TimeoutReason>()), Times.Never);
@ -185,14 +185,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
_mockTimeoutHandler.Verify(h => h.OnTimeout(TimeoutReason.WriteDataRate), Times.Once); _mockTimeoutHandler.Verify(h => h.OnTimeout(TimeoutReason.WriteDataRate), Times.Once);
_mockConnectionContext.Verify(c =>c.Abort(It.Is<ConnectionAbortedException>(e => _mockConnectionContext.Verify(c => c.Abort(It.Is<ConnectionAbortedException>(e =>
e.Message == CoreStrings.ConnectionTimedBecauseResponseMininumDataRateNotSatisfied)), Times.Once); e.Message == CoreStrings.ConnectionTimedBecauseResponseMininumDataRateNotSatisfied)), Times.Once);
_mockTimeoutHandler.VerifyNoOtherCalls(); _mockTimeoutHandler.VerifyNoOtherCalls();
_mockConnectionContext.VerifyNoOtherCalls(); _mockConnectionContext.VerifyNoOtherCalls();
} }
[Theory(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1879")] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1879", FlakyOn.AzP.Linux)]
[InlineData((int)Http2FrameType.DATA)] [InlineData((int)Http2FrameType.DATA)]
[InlineData((int)Http2FrameType.CONTINUATION)] [InlineData((int)Http2FrameType.CONTINUATION)]
public async Task AbortedStream_ResetsAndDrainsRequest_RefusesFramesAfterCooldownExpires(int intFinalFrameType) public async Task AbortedStream_ResetsAndDrainsRequest_RefusesFramesAfterCooldownExpires(int intFinalFrameType)
@ -267,7 +268,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7000 [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7000
public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod() public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod()
{ {
var mockSystemClock = _serviceContext.MockSystemClock; var mockSystemClock = _serviceContext.MockSystemClock;
@ -282,7 +283,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
_timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks); _timeoutControl.Initialize(mockSystemClock.UtcNow.Ticks);
await InitializeConnectionAsync(_echoApplication); await InitializeConnectionAsync(_echoApplication);
await StartStreamAsync(1, _browserRequestHeaders, endStream: false); await StartStreamAsync(1, _browserRequestHeaders, endStream: false);
await SendDataAsync(1, _helloWorldBytes, endStream: true); await SendDataAsync(1, _helloWorldBytes, endStream: true);
@ -316,8 +317,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
Http2ErrorCode.INTERNAL_ERROR, Http2ErrorCode.INTERNAL_ERROR,
null); null);
_mockConnectionContext.Verify(c =>c.Abort(It.Is<ConnectionAbortedException>(e => _mockConnectionContext.Verify(c => c.Abort(It.Is<ConnectionAbortedException>(e =>
e.Message == CoreStrings.ConnectionTimedBecauseResponseMininumDataRateNotSatisfied)), Times.Once); e.Message == CoreStrings.ConnectionTimedBecauseResponseMininumDataRateNotSatisfied)), Times.Once);
_mockTimeoutHandler.VerifyNoOtherCalls(); _mockTimeoutHandler.VerifyNoOtherCalls();
_mockConnectionContext.VerifyNoOtherCalls(); _mockConnectionContext.VerifyNoOtherCalls();

3
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionAdapterTests.cs
View File

@ -459,7 +459,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
} }
} }
[Theory(Skip = "https://github.com/aspnet/AspNetCore/issues/7265")] [Theory]
[Flaky("https://github.com/aspnet/AspNetCore/issues/7265", FlakyOn.All)]
[InlineData(ClientCertificateMode.AllowCertificate)] [InlineData(ClientCertificateMode.AllowCertificate)]
[InlineData(ClientCertificateMode.RequireCertificate)] [InlineData(ClientCertificateMode.RequireCertificate)]
public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode) public async Task ClientCertificateValidationGetsCalledWithNotNullParameters(ClientCertificateMode mode)

4
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
View File

@ -23,6 +23,7 @@ using Microsoft.AspNetCore.Http.Endpoints;
using Microsoft.AspNetCore.Http.Features; using Microsoft.AspNetCore.Http.Features;
using Microsoft.AspNetCore.Http.Internal; using Microsoft.AspNetCore.Http.Internal;
using Microsoft.AspNetCore.SignalR.Tests; using Microsoft.AspNetCore.SignalR.Tests;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging;
@ -2081,7 +2082,8 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
} }
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8138")] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore/issues/8138", FlakyOn.All)]
public async Task ErrorDuringPollWillCloseConnection() public async Task ErrorDuringPollWillCloseConnection()
{ {
bool ExpectedErrors(WriteContext writeContext) bool ExpectedErrors(WriteContext writeContext)

6
src/SignalR/server/SignalR/test/EndToEndTests.cs
View File

@ -14,6 +14,7 @@ using Microsoft.AspNetCore.Http.Connections;
using Microsoft.AspNetCore.Http.Connections.Client; using Microsoft.AspNetCore.Http.Connections.Client;
using Microsoft.AspNetCore.Http.Connections.Client.Internal; using Microsoft.AspNetCore.Http.Connections.Client.Internal;
using Microsoft.AspNetCore.SignalR.Client; using Microsoft.AspNetCore.SignalR.Client;
using Microsoft.AspNetCore.Testing;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.AspNetCore.WebUtilities; using Microsoft.AspNetCore.WebUtilities;
using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging;
@ -307,7 +308,8 @@ namespace Microsoft.AspNetCore.SignalR.Tests
} }
} }
[ConditionalTheory(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1383")] [ConditionalTheory]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1383", FlakyOn.All)]
[WebSocketsSupportedCondition] [WebSocketsSupportedCondition]
[InlineData(5 * 4096)] [InlineData(5 * 4096)]
[InlineData(1000 * 4096 + 32)] [InlineData(1000 * 4096 + 32)]
@ -530,7 +532,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
} }
} }
// Serves a fake transport that lets us verify fallback behavior // Serves a fake transport that lets us verify fallback behavior
private class TestTransportFactory : ITransportFactory private class TestTransportFactory : ITransportFactory
{ {
private ITransport _transport; private ITransport _transport;

5
src/Tools/dotnet-watch/test/DotNetWatcherTests.cs
View File

@ -2,13 +2,13 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System; using System;
using System.Collections.Generic;
using System.IO; using System.IO;
using System.Globalization; using System.Globalization;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
using Xunit.Abstractions; using Xunit.Abstractions;
using Microsoft.AspNetCore.Testing;
namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
{ {
@ -36,7 +36,8 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
Assert.Equal("1", envValue); Assert.Equal("1", envValue);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1826")] [Fact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1826", FlakyOn.All)]
public async Task RunsWithIterationEnvVariable() public async Task RunsWithIterationEnvVariable()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();