From 707d79d3a131211ad14faac7f884729d98abad8a Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Tue, 17 Apr 2018 21:28:06 +1200 Subject: [PATCH] Comment --- .../ServerLogScope.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs b/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs index 33d050a0a5..702d43f706 100644 --- a/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs +++ b/test/Microsoft.AspNetCore.SignalR.Tests.Utils/ServerLogScope.cs @@ -17,12 +17,14 @@ namespace Microsoft.AspNetCore.SignalR.Tests public ServerLogScope(ServerFixture serverFixture, ILoggerFactory loggerFactory, IDisposable wrappedDisposable) { - _serverLoggers = new ConcurrentDictionary(StringComparer.Ordinal); _loggerFactory = loggerFactory; - _wrappedDisposable = wrappedDisposable; - _scopeLogger = loggerFactory.CreateLogger(nameof(ServerLogScope)); - _serverFixture = serverFixture; + _wrappedDisposable = wrappedDisposable; + + _serverLoggers = new ConcurrentDictionary(StringComparer.Ordinal); + _scopeLogger = _loggerFactory.CreateLogger(nameof(ServerLogScope)); + + // Attach last after everything else is initialized because a logged error can happen at any time _serverFixture.ServerLogged += ServerFixtureOnServerLogged; _scopeLogger.LogInformation("Server log scope started.");