PR feedback

This commit is contained in:
Kiran Challa 2018-07-24 17:17:08 -07:00
parent 71cb933a08
commit 6f4c10a664
1 changed files with 6 additions and 6 deletions

View File

@ -179,22 +179,22 @@ namespace Microsoft.AspNetCore.Routing.Internal
var sb = new StringBuilder(); var sb = new StringBuilder();
var branchStack = new Stack<string>(); var branchStack = new Stack<string>();
branchStack.Push(string.Empty); branchStack.Push(string.Empty);
FlattenTree(_root, branchStack, sb); FlattenTree(branchStack, sb, _root);
return sb.ToString(); return sb.ToString();
} }
} }
private void FlattenTree(DecisionTreeNode<OutboundMatch> node, Stack<string> branchStack, StringBuilder sb) private void FlattenTree(Stack<string> branchStack, StringBuilder sb, DecisionTreeNode<OutboundMatch> node)
{ {
// leaf node // leaf node
if (node.Criteria.Count == 0) if (node.Criteria.Count == 0)
{ {
var temp = new StringBuilder(); var matchesSb = new StringBuilder();
foreach (var branch in branchStack) foreach (var branch in branchStack)
{ {
temp.Insert(0, branch); matchesSb.Insert(0, branch);
} }
sb.Append(temp.ToString()); sb.Append(matchesSb.ToString());
sb.Append(" (Matches: "); sb.Append(" (Matches: ");
sb.Append(string.Join(", ", node.Matches.Select(m => m.Entry.RouteTemplate.TemplateText))); sb.Append(string.Join(", ", node.Matches.Select(m => m.Entry.RouteTemplate.TemplateText)));
sb.AppendLine(")"); sb.AppendLine(")");
@ -205,7 +205,7 @@ namespace Microsoft.AspNetCore.Routing.Internal
foreach (var branch in criterion.Branches) foreach (var branch in criterion.Branches)
{ {
branchStack.Push($" => {criterion.Key}: {branch.Key}"); branchStack.Push($" => {criterion.Key}: {branch.Key}");
FlattenTree(branch.Value, branchStack, sb); FlattenTree(branchStack, sb, branch.Value);
branchStack.Pop(); branchStack.Pop();
} }
} }