From 6d3b5f197803f68b87fe60aecf224e46852de1f2 Mon Sep 17 00:00:00 2001 From: Doug Bunting Date: Mon, 4 Jan 2016 21:12:30 -0800 Subject: [PATCH] See if a few skips are incorrectly associated w/ aspnet/External#18 --- .../SerializableErrorTests.cs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs index d277704f93..83d01a76c0 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs @@ -8,7 +8,6 @@ using System.Text; using System.Threading.Tasks; using Microsoft.AspNetCore.Mvc.Formatters.Xml; using Microsoft.AspNetCore.Testing; -using Microsoft.AspNetCore.Testing.xunit; using Xunit; namespace Microsoft.AspNetCore.Mvc.FunctionalTests @@ -62,11 +61,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests XmlAssert.Equal(expectedXml, responseData); } - [ConditionalTheory] - // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18??? - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] - [InlineData("application/xml-xmlser")] - [InlineData("application/xml-dcs")] + [Theory] + [MemberData(nameof(AcceptHeadersData))] public async Task PostedSerializableError_IsBound(string acceptHeader) { // Arrange @@ -87,11 +83,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests XmlAssert.Equal(expectedXml, responseData); } - [ConditionalTheory] - // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18??? - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] - [InlineData("application/xml-xmlser")] - [InlineData("application/xml-dcs")] + [Theory] + [MemberData(nameof(AcceptHeadersData))] public async Task IsReturnedInExpectedFormat(string acceptHeader) { // Arrange