huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove obsolete session apis (#4609) 

* Remove obsolete session apis

* Add breaking changes json updates
This commit is contained in:
John Luo 2018-12-12 17:35:40 -08:00 committed by GitHub
parent 49d5525352
commit 6d2f2483d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 53 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
src/Middleware/Session/src/SessionOptions.cs
View File

@ -43,66 +43,6 @@ namespace Microsoft.AspNetCore.Builder
/// </summary>
public TimeSpan IOTimeout { get; set; } = TimeSpan.FromMinutes(1);
#region Obsolete API
/// <summary>
/// <para>
/// This property is obsolete and will be removed in a future version. The recommended alternative is <seealso cref="CookieBuilder.Name"/> on <see cref="Cookie"/>.
/// </para>
/// <para>
/// Determines the cookie name used to persist the session ID.
/// </para>
/// </summary>
[Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Name) + ".")]
public string CookieName { get => Cookie.Name; set => Cookie.Name = value; }
/// <summary>
/// <para>
/// This property is obsolete and will be removed in a future version. The recommended alternative is <seealso cref="CookieBuilder.Domain"/> on <see cref="Cookie"/>.
/// </para>
/// <para>
/// Determines the domain used to create the cookie. Is not provided by default.
/// </para>
/// </summary>
[Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Domain) + ".")]
public string CookieDomain { get => Cookie.Domain; set => Cookie.Domain = value; }
/// <summary>
/// <para>
/// This property is obsolete and will be removed in a future version. The recommended alternative is <seealso cref="CookieBuilder.Path"/> on <see cref="Cookie"/>.
/// </para>
/// <para>
/// Determines the path used to create the cookie.
/// Defaults to <see cref="SessionDefaults.CookiePath"/>.
/// </para>
/// </summary>
[Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.Path) + ".")]
public string CookiePath { get => Cookie.Path; set => Cookie.Path = value; }
/// <summary>
/// <para>
/// This property is obsolete and will be removed in a future version. The recommended alternative is <seealso cref="CookieBuilder.HttpOnly"/> on <see cref="Cookie"/>.
/// </para>
/// <para>
/// Determines if the browser should allow the cookie to be accessed by client-side JavaScript. The
/// default is true, which means the cookie will only be passed to HTTP requests and is not made available
/// to script on the page.
/// </para>
/// </summary>
[Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.HttpOnly) + ".")]
public bool CookieHttpOnly { get => Cookie.HttpOnly; set => Cookie.HttpOnly = value; }
/// <summary>
/// <para>
/// This property is obsolete and will be removed in a future version. The recommended alternative is <seealso cref="CookieBuilder.SecurePolicy"/> on <see cref="Cookie"/>.
/// </para>
/// <para>
/// Determines if the cookie should only be transmitted on HTTPS requests.
/// </para>
/// </summary>
[Obsolete("This property is obsolete and will be removed in a future version. The recommended alternative is " + nameof(Cookie) + "." + nameof(CookieBuilder.SecurePolicy) + ".")]
public CookieSecurePolicy CookieSecure { get => Cookie.SecurePolicy; set => Cookie.SecurePolicy = value; }
#endregion
private class SessionCookieBuilder : CookieBuilder
{
public SessionCookieBuilder()

2
src/Middleware/Session/src/baseline.netcore.json
View File

@ -1,5 +1,5 @@
{
"AssemblyIdentity": "Microsoft.AspNetCore.Session, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60",
"AssemblyIdentity": "Microsoft.AspNetCore.Session, Version=2.2.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60",
"Types": [
{
"Name": "Microsoft.Extensions.DependencyInjection.SessionServiceCollectionExtensions",

52
src/Middleware/Session/src/breakingchanges.netcore.json Normal file
View File

@ -0,0 +1,52 @@
[
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public Microsoft.AspNetCore.Http.CookieSecurePolicy get_CookieSecure()",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Boolean get_CookieHttpOnly()",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.String get_CookieDomain()",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.String get_CookieName()",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.String get_CookiePath()",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Void set_CookieDomain(System.String value)",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Void set_CookieHttpOnly(System.Boolean value)",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Void set_CookieName(System.String value)",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Void set_CookiePath(System.String value)",
"Kind": "Removal"
},
{
"TypeId": "public class Microsoft.AspNetCore.Builder.SessionOptions",
"MemberId": "public System.Void set_CookieSecure(Microsoft.AspNetCore.Http.CookieSecurePolicy value)",
"Kind": "Removal"
}
]