huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed flaky test 'CanInfluenceHeadDuringPrerender'. (#24624)

This commit is contained in:
Mackinnon Buck 2020-08-06 14:02:30 -07:00 committed by GitHub
parent 9d783c5b76
commit 6c35e2e84d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/Components/test/E2ETest/ServerExecutionTests/PrerenderingTest.cs
View File

@ -88,44 +88,31 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
Navigate("/prerendered/prerendered-head"); Navigate("/prerendered/prerendered-head");
var metaWithBindings = Browser.FindElement(By.Id("meta-with-bindings"));
var metaNoBindings = Browser.FindElement(By.Id("meta-no-bindings"));
// Validate updated head during prerender // Validate updated head during prerender
Browser.Equal("Initial title", () => Browser.Title); Browser.Equal("Initial title", () => Browser.Title);
Browser.Equal("Initial meta content", () => metaWithBindings.GetAttribute("content")); Browser.Equal("Initial meta content", () => GetMetaWithBindings().GetAttribute("content"));
Browser.Equal("Immutable meta content", () => metaNoBindings.GetAttribute("content")); Browser.Equal("Immutable meta content", () => GetMetaWithoutBindings().GetAttribute("content"));
BeginInteractivity(); BeginInteractivity();
// Wait for elements to be recreated with internal ids to permit mutation // Wait until the component has rerendered
metaWithBindings = WaitForNewElement(metaWithBindings, "meta-with-bindings"); Browser.Exists(By.Id("interactive-indicator"));
metaNoBindings = WaitForNewElement(metaNoBindings, "meta-no-bindings");
// Validate updated head after prerender // Validate updated head after prerender
Browser.Equal("Initial title", () => Browser.Title); Browser.Equal("Initial title", () => Browser.Title);
Browser.Equal("Initial meta content", () => metaWithBindings.GetAttribute("content")); Browser.Equal("Initial meta content", () => GetMetaWithBindings().GetAttribute("content"));
Browser.Equal("Immutable meta content", () => metaNoBindings.GetAttribute("content")); Browser.Equal("Immutable meta content", () => GetMetaWithoutBindings().GetAttribute("content"));
// Change parameter of meta component // Change parameter of meta component
var inputMetaBinding = Browser.FindElement(By.Id("input-meta-binding")); var inputMetaBinding = Browser.FindElement(By.Id("input-meta-binding"));
inputMetaBinding.Clear(); inputMetaBinding.Clear();
inputMetaBinding.SendKeys("Updated meta content\n"); inputMetaBinding.SendKeys("Updated meta content\n");
// Wait for meta tag to be recreated with new attributes
metaWithBindings = WaitForNewElement(metaWithBindings, "meta-with-bindings");
// Validate new meta content attribute // Validate new meta content attribute
Browser.Equal("Updated meta content", () => metaWithBindings.GetAttribute("content")); Browser.Equal("Updated meta content", () => GetMetaWithBindings().GetAttribute("content"));
IWebElement WaitForNewElement(IWebElement existingElement, string id) IWebElement GetMetaWithBindings() => Browser.FindElement(By.Id("meta-with-bindings"));
{ IWebElement GetMetaWithoutBindings() => Browser.FindElement(By.Id("meta-no-bindings"));
var newElement = existingElement;
Browser.NotEqual(existingElement, () => newElement = Browser.FindElement(By.Id(id)) ?? newElement);
return newElement;
}
} }
[Fact] [Fact]

16
src/Components/test/testassets/BasicTestApp/PrerenderedHeadComponent.razor
View File

@ -23,7 +23,23 @@
<Meta id="meta-no-bindings" content="Immutable meta content" /> <Meta id="meta-no-bindings" content="Immutable meta content" />
@if (isInteractive)
{
<span id="interactive-indicator">Interactive mode enabled.</span>
}
@code { @code {
private string title = "Initial title"; private string title = "Initial title";
private string metaContent = "Initial meta content"; private string metaContent = "Initial meta content";
private bool isInteractive;
protected override void OnAfterRender(bool firstRender)
{
if (firstRender)
{
isInteractive = true;
StateHasChanged();
}
}
} }