Hosting API review # 2

1. Moving HostingUtilities and PipelineInstance into internal namespaces.
2. Renaming some properties in IHostingEnvironment
3. Renaming IHttpContextAccessor HttpContext into Value.

Addresses:
https://github.com/aspnet/Hosting/issues/159
https://github.com/aspnet/Hosting/issues/157
https://github.com/aspnet/Hosting/issues/161

src/Microsoft.AspNet.Hosting.Interfaces/IHostingEnvironment.cs

@@ -9,8 +9,8 @@ namespace Microsoft.AspNet.Hosting
     {
         string EnvironmentName { get; set; }
 
-        string WebRoot { get; }
+        string WebRootPath { get; }
 
-        IFileProvider WebRootFileProvider { get; set; }
+        IFileProvider WebRootFileProvider { get; }
     }
 }

src/Microsoft.AspNet.Hosting/HostingEngine.cs

@@ -6,6 +6,7 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using Microsoft.AspNet.Hosting.Builder;
+using Microsoft.AspNet.Hosting.Internal;
 using Microsoft.AspNet.Hosting.Server;
 using Microsoft.AspNet.Hosting.Startup;
 

src/Microsoft.AspNet.Hosting/HostingEnvironment.cs

@@ -3,6 +3,7 @@
 
 using System.Collections.Generic;
 using Microsoft.AspNet.FileProviders;
+using Microsoft.AspNet.Hosting.Internal;
 using Microsoft.Framework.Runtime;
 
 namespace Microsoft.AspNet.Hosting
@@ -14,8 +15,8 @@ namespace Microsoft.AspNet.Hosting
         public HostingEnvironment(IApplicationEnvironment appEnvironment, IEnumerable<IConfigureHostingEnvironment> configures)
         {
             EnvironmentName = DefaultEnvironmentName;
-            WebRoot = HostingUtilities.GetWebRoot(appEnvironment.ApplicationBasePath);
+            WebRootPath = HostingUtilities.GetWebRoot(appEnvironment.ApplicationBasePath);
-            WebRootFileProvider = new PhysicalFileProvider(WebRoot);
+            WebRootFileProvider = new PhysicalFileProvider(WebRootPath);
             foreach (var configure in configures)
             {
                 configure.Configure(this);
@@ -24,8 +25,8 @@ namespace Microsoft.AspNet.Hosting
 
         public string EnvironmentName { get; set; }
 
-        public string WebRoot { get; private set; }
+        public string WebRootPath { get; private set; }
 
-        public IFileProvider WebRootFileProvider { get; set; }
+        public IFileProvider WebRootFileProvider { get; private set; }
     }
 }

src/Microsoft.AspNet.Hosting/Internal/HostingUtilities.cs

@@ -6,7 +6,7 @@ using System.IO;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
-namespace Microsoft.AspNet.Hosting
+namespace Microsoft.AspNet.Hosting.Internal
 {
     public static class HostingUtilities
     {

src/Microsoft.AspNet.Hosting/Internal/PipelineInstance.cs

@@ -7,7 +7,7 @@ using Microsoft.AspNet.Builder;
 using Microsoft.AspNet.FeatureModel;
 using Microsoft.AspNet.Hosting.Builder;
 
-namespace Microsoft.AspNet.Hosting
+namespace Microsoft.AspNet.Hosting.Internal
 {
     public class PipelineInstance : IDisposable
     {

src/Microsoft.AspNet.Hosting/Server/ServerLoader.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Linq;
 using System.Reflection;
+using Microsoft.AspNet.Hosting.Internal;
 using Microsoft.Framework.DependencyInjection;
 
 namespace Microsoft.AspNet.Hosting.Server

src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs

@@ -92,7 +92,7 @@ namespace Microsoft.AspNet.Hosting.Startup
         {
             if (string.IsNullOrEmpty(applicationName))
             {
-                throw new ArgumentException("applicationName");
+                throw new ArgumentException("Value cannot be null or empty.", "applicationName");
             }
 
             var assembly = Assembly.Load(new AssemblyName(applicationName));

test/Microsoft.AspNet.Hosting.Tests/HostingEngineTests.cs

@@ -60,7 +60,7 @@ namespace Microsoft.AspNet.Hosting
         {
             var services = HostingServices.Create().BuildServiceProvider();
             var env = services.GetRequiredService<IHostingEnvironment>();
-            Assert.Equal(Path.GetFullPath("testroot"), env.WebRoot);
+            Assert.Equal(Path.GetFullPath("testroot"), env.WebRootPath);
             Assert.True(env.WebRootFileProvider.GetFileInfo("TextFile.txt").Exists);
         }
 

test/Microsoft.AspNet.Hosting.Tests/HostingUtilitiesTests.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using Microsoft.AspNet.Hosting.Internal;
 using Xunit;
 
 namespace Microsoft.AspNet.Hosting.Tests

test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs

@@ -75,7 +75,7 @@ namespace Microsoft.AspNet.TestHost
             TestServer server = TestServer.Create(app =>
             {
                 var env = app.ApplicationServices.GetRequiredService<IHostingEnvironment>();
-                Assert.Equal(Directory.GetCurrentDirectory(), env.WebRoot);
+                Assert.Equal(Directory.GetCurrentDirectory(), env.WebRootPath);
             });
         }