From 6beb419a02a6efa102c9ce7fe3213beca4c30082 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 8 May 2018 21:02:29 -0700 Subject: [PATCH] Upgrade metapackages, shared framework, and installers to netcoreapp2.2 --- build/PackageArchive.targets | 2 +- build/Publish.targets | 2 +- build/SharedFx.props | 11 +++++----- build/SharedFx.targets | 22 +++++++++---------- build/SharedFxInstaller.targets | 10 ++++----- build/dependencies.props | 2 +- build/repo.props | 7 ++---- build/repo.targets | 1 + build/tools/templates/Archive/Archive.csproj | 3 +-- .../tools/templates/SharedFx/SharedFx.csproj | 2 +- .../Microsoft.AspNetCore.All.csproj | 2 +- .../Microsoft.AspNetCore.All.targets | 4 ++-- .../Microsoft.AspNetCore.App.csproj | 2 +- .../Microsoft.AspNetCore.App.targets | 4 ++-- 14 files changed, 36 insertions(+), 38 deletions(-) diff --git a/build/PackageArchive.targets b/build/PackageArchive.targets index ed6c1bc52e..376542e1a4 100644 --- a/build/PackageArchive.targets +++ b/build/PackageArchive.targets @@ -45,7 +45,7 @@ + Properties="RestorePackagesPath=$(FallbackStagingDir);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp22PackageVersion);DotNetRestoreSourcePropsPath=$(GeneratedFallbackRestoreSourcesPropsPath);DotNetBuildOffline=true;AspNetUniverseBuildOffline=true" /> diff --git a/build/Publish.targets b/build/Publish.targets index 123678d0f3..8493ed3e27 100644 --- a/build/Publish.targets +++ b/build/Publish.targets @@ -34,7 +34,7 @@ - + aspnetcore-runtime @@ -38,11 +39,11 @@ $(PublicCoreFeedPrefix) dotnet-runtime - $(DotnetRuntimePackageName)-$(MicrosoftNETCoreApp21PackageVersion) - 2.1 - $(MicrosoftNETCoreApp21PackageVersion.Split('-')[0]) - $(DotnetRuntimePackageName)-$(MicrosoftNETCoreApp21IdVersion) - $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreApp21PackageVersion)/$(DotnetRuntimeInstallerPrefix) + $(DotnetRuntimePackageName)-$(MicrosoftNETCoreApp22PackageVersion) + 2.2 + $(MicrosoftNETCoreApp22PackageVersion.Split('-')[0]) + $(DotnetRuntimePackageName)-$(MicrosoftNETCoreApp22IdVersion) + $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreApp22PackageVersion)/$(DotnetRuntimeInstallerPrefix) $(_SharedFxSourceDir)$(SharedFxIntermediateArchiveBaseName)-$(PackageVersion) diff --git a/build/SharedFx.targets b/build/SharedFx.targets index 0f2ae1fab4..918aa988d1 100644 --- a/build/SharedFx.targets +++ b/build/SharedFx.targets @@ -47,7 +47,7 @@ $(CommonProps);DotNetRestoreSourcePropsPath=$(GeneratedRestoreSourcesPropsPath) $(CommonProps);DotNetBuildOffline=true $(CommonProps);AspNetUniverseBuildOffline=true - $(CommonProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp21PackageVersion) + $(CommonProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp22PackageVersion) $(CommonProps);AppMetapackageVersion=$(PackageVersion) @@ -173,10 +173,10 @@ SharedFxWorkDirectory=$(AppSharedFxWorkDirectory) - $(AppSharedFxProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp21PackageVersion) + $(AppSharedFxProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp22PackageVersion) $(AppSharedFxProps);SharedFxPackage=Microsoft.AspNetCore.App SharedFxWorkDirectory=$(AllSharedFxWorkDirectory) - $(AllSharedFxProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp21PackageVersion) + $(AllSharedFxProps);RuntimeFrameworkVersion=$(MicrosoftNETCoreApp22PackageVersion) $(AllSharedFxProps);SharedFxPackage=Microsoft.AspNetCore.All $(AllSharedFxProps);SharedFxDep=Microsoft.AspNetCore.App $(AllSharedFxProps);SharedFxDepVersion=$(PackageVersion) @@ -456,41 +456,41 @@ Condition="Exists('$(_SymbolsSourceDir)%(AllPortablePDBsToPublish.SymbolsPackageFilename)')" /> diff --git a/build/SharedFxInstaller.targets b/build/SharedFxInstaller.targets index edd3b61bac..75247f3993 100644 --- a/build/SharedFxInstaller.targets +++ b/build/SharedFxInstaller.targets @@ -148,8 +148,8 @@ - - + + @@ -259,14 +259,14 @@ - $(MicrosoftNETCoreApp21PackageVersion) + $(MicrosoftNETCoreApp22PackageVersion) - $(NETCoreApp21DebVersion.Substring(0, $(NETCoreApp21DebVersion.IndexOf('-'))))~$(NETCoreApp21DebVersion.Substring($([MSBuild]::Add($(NETCoreApp21DebVersion.IndexOf('-')), 1)))) + $(DotnetCoreDebianPackageVersion.Substring(0, $(DotnetCoreDebianPackageVersion.IndexOf('-'))))~$(DotnetCoreDebianPackageVersion.Substring($([MSBuild]::Add($(DotnetCoreDebianPackageVersion.IndexOf('-')), 1)))) <_DebNonUpgradeableSharedFxDependencies Include="$(DotnetRuntimeInstallerPrefix)"/> - <_DebSharedFxDependencies Include="$(DotnetRuntimeUpgradeableInstallerPrefix)" Version="$(NETCoreApp21DebVersion)"/> + <_DebSharedFxDependencies Include="$(DotnetRuntimeUpgradeableInstallerPrefix)" Version="$(DotnetCoreDebianPackageVersion)"/> diff --git a/build/dependencies.props b/build/dependencies.props index 8dba43114e..a76396548f 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -3,7 +3,7 @@ 4.5.0-preview3-26423-04 2.2.0-preview1-26424-04 - + 2.2.0-preview1-26424-04 2.2.0-preview1-26424-04 4.5.0-preview3-26423-04 diff --git a/build/repo.props b/build/repo.props index 296beb9480..9f8383ba5e 100644 --- a/build/repo.props +++ b/build/repo.props @@ -45,15 +45,12 @@ - - - - diff --git a/build/repo.targets b/build/repo.targets index 32e0796db9..f0b0c9f336 100644 --- a/build/repo.targets +++ b/build/repo.targets @@ -33,6 +33,7 @@ MicrosoftNETCoreAppPackageVersion=$(MicrosoftNETCoreAppPackageVersion); + $(DesignTimeBuildProps);MicrosoftNETCoreApp22PackageVersion=$(MicrosoftNETCoreApp22PackageVersion); $(DesignTimeBuildProps);MicrosoftNETCoreApp21PackageVersion=$(MicrosoftNETCoreApp21PackageVersion); $(DesignTimeBuildProps);MicrosoftNETCoreApp20PackageVersion=$(MicrosoftNETCoreApp20PackageVersion); diff --git a/build/tools/templates/Archive/Archive.csproj b/build/tools/templates/Archive/Archive.csproj index 3699f0e4bc..7bc1b04c5a 100644 --- a/build/tools/templates/Archive/Archive.csproj +++ b/build/tools/templates/Archive/Archive.csproj @@ -3,9 +3,8 @@ - netcoreapp2.1 + netcoreapp2.2 false - netcoreapp2.1 $(RestoreSources);$(DotNetRestoreSources); true diff --git a/build/tools/templates/SharedFx/SharedFx.csproj b/build/tools/templates/SharedFx/SharedFx.csproj index 24bd3aad7e..4dc8e0f27a 100644 --- a/build/tools/templates/SharedFx/SharedFx.csproj +++ b/build/tools/templates/SharedFx/SharedFx.csproj @@ -3,7 +3,7 @@ - netcoreapp2.1 + netcoreapp2.2 true true $(RestoreSources);$(DotNetRestoreSources); diff --git a/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj b/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj index 6df70d6f22..83c56c30b8 100644 --- a/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj +++ b/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj @@ -5,7 +5,7 @@ false false - netcoreapp2.1 + netcoreapp2.2 aspnetcore Microsoft.AspNetCore.All false diff --git a/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets b/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets index 69c476529b..ff8736382c 100644 --- a/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets +++ b/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets @@ -12,7 +12,7 @@ + Text="This version of Microsoft.AspNetCore.All is only compatible with the netcoreapp2.2 target framework. Please target netcoreapp2.2 or choose a version of Microsoft.AspNetCore.All compatible with $(TargetFramework)." + Condition="'$(TargetFramework)' != 'netcoreapp2.2'"/> diff --git a/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj b/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj index d87e940d0c..2a0e3f8403 100644 --- a/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj +++ b/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj @@ -5,7 +5,7 @@ false false - netcoreapp2.1 + netcoreapp2.2 aspnetcore Microsoft.AspNetCore.App false diff --git a/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets b/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets index 35bce0f129..2ba815e5da 100644 --- a/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets +++ b/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets @@ -12,7 +12,7 @@ + Text="This version of Microsoft.AspNetCore.App is only compatible with the netcoreapp2.2 target framework. Please target netcoreapp2.2 or choose a version of Microsoft.AspNetCore.App compatible with $(TargetFramework)." + Condition="'$(TargetFramework)' != 'netcoreapp2.2'"/>