huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FeatureModel should use Type.IsInstanceOf rather than direct type equality.

This commit is contained in:
GrabYourPitchforks 2014-02-14 16:26:13 -08:00
parent a34826d90b
commit 69addcac86
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Microsoft.AspNet.FeatureModel/FeatureCollection.cs
View File

@ -1,6 +1,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Reflection;
using System.Threading;
using Microsoft.AspNet.FeatureModel.Implementation;
@ -42,11 +43,7 @@ namespace Microsoft.AspNet.FeatureModel
{
if (_featureByFeatureType.TryGetValue(actualType, out feature))
{
#if NET45
var isInstanceOfType = type.IsInstanceOfType(feature);
#else
var isInstanceOfType = feature != null && type == feature.GetType();
#endif
if (isInstanceOfType)
{
@ -54,6 +51,8 @@ namespace Microsoft.AspNet.FeatureModel
}
#if NET45
return Converter.Convert(type, actualType, feature);
#else
return null;
#endif
}
}

2
src/Microsoft.AspNet.FeatureModel/FeatureObject.cs
View File

@ -27,12 +27,12 @@ namespace Microsoft.AspNet.FeatureModel
public object GetInterface(Type type)
{
#if NET45
if (type.IsInstanceOfType(_instance))
{
return _instance;
}
#if NET45
foreach (var interfaceType in _instance.GetType().GetInterfaces())
{
if (interfaceType.FullName == type.FullName)