#59 - Use Task.GetAwaiter().GetResult() instead of Task.Result.

This commit is contained in:
Chris Ross 2014-10-10 12:12:48 -07:00
parent e315a545cb
commit 6965a66f18
7 changed files with 10 additions and 10 deletions

View File

@ -36,7 +36,7 @@ namespace Microsoft.AspNet.Security.Cookies
protected override AuthenticationTicket AuthenticateCore()
{
return AuthenticateCoreAsync().Result;
return AuthenticateCoreAsync().GetAwaiter().GetResult();
}
protected override async Task<AuthenticationTicket> AuthenticateCoreAsync()
@ -124,7 +124,7 @@ namespace Microsoft.AspNet.Security.Cookies
protected override void ApplyResponseGrant()
{
ApplyResponseGrantAsync().Wait();
ApplyResponseGrantAsync().GetAwaiter().GetResult();
}
protected override async Task ApplyResponseGrantAsync()

View File

@ -84,7 +84,7 @@ namespace Microsoft.AspNet.Security.OAuth
protected override AuthenticationTicket AuthenticateCore()
{
return AuthenticateCoreAsync().Result;
return AuthenticateCoreAsync().GetAwaiter().GetResult();
}
protected override async Task<AuthenticationTicket> AuthenticateCoreAsync()

View File

@ -21,7 +21,7 @@ namespace Microsoft.AspNet.Security.OAuth
protected override AuthenticationTicket AuthenticateCore()
{
return AuthenticateCoreAsync().Result;
return AuthenticateCoreAsync().GetAwaiter().GetResult();
}
protected override async Task<AuthenticationTicket> AuthenticateCoreAsync()

View File

@ -46,7 +46,7 @@ namespace Microsoft.AspNet.Security.Twitter
protected override AuthenticationTicket AuthenticateCore()
{
return AuthenticateCoreAsync().Result;
return AuthenticateCoreAsync().GetAwaiter().GetResult();
}
protected override async Task<AuthenticationTicket> AuthenticateCoreAsync()
@ -124,7 +124,7 @@ namespace Microsoft.AspNet.Security.Twitter
}
protected override void ApplyResponseChallenge()
{
ApplyResponseChallengeAsync().Wait();
ApplyResponseChallengeAsync().GetAwaiter().GetResult();
}
protected override async Task ApplyResponseChallengeAsync()

View File

@ -84,7 +84,7 @@ namespace Microsoft.AspNet.Security
public bool Authorize(IEnumerable<Claim> claims, ClaimsPrincipal user, object resource)
{
return AuthorizeAsync(claims, user, resource).Result;
return AuthorizeAsync(claims, user, resource).GetAwaiter().GetResult();
}
private bool ClaimsMatch([NotNull] IEnumerable<Claim> x, [NotNull] IEnumerable<Claim> y)

View File

@ -183,7 +183,7 @@ namespace Microsoft.AspNet.Security.Infrastructure
() =>
{
return Task.FromResult(AuthenticateCore());
}).Result;
}).GetAwaiter().GetResult();
}
protected abstract AuthenticationTicket AuthenticateCore();
@ -225,7 +225,7 @@ namespace Microsoft.AspNet.Security.Infrastructure
{
ApplyResponseCore();
return Task.FromResult(0);
}).Wait(); // Block if the async version is in progress.
}).GetAwaiter().GetResult(); // Block if the async version is in progress.
}
protected virtual void ApplyResponseCore()

View File

@ -242,7 +242,7 @@ namespace Microsoft.AspNet.Security.Test
// Act
// Assert
Exception ex = Assert.Throws<AggregateException>(() => authorizationService.Authorize(Enumerable.Empty<Claim>(), null));
Exception ex = Assert.Throws<InvalidOperationException>(() => authorizationService.Authorize(Enumerable.Empty<Claim>(), null));
}
[Fact]