diff --git a/build/dependencies.props b/build/dependencies.props index 67bd84a1a8..6eec44e338 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -8,30 +8,30 @@ 3.0.0-alpha1-10657 3.0.0-alpha1-20181011.3 1.10.0 - 3.0.0-alpha1-10660 + 3.0.0-alpha1-10670 3.0.0-alpha1-10657 3.0.0-alpha1-10657 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 3.0.0-alpha1-10657 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 - 3.0.0-alpha1-10660 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 2.1.1 2.1.3 2.2.0-rtm-27023-02 - 3.0.0-alpha1-10660 + 3.0.0-alpha1-10670 15.6.1 4.10.0 2.0.3 diff --git a/test/Kestrel.Transport.FunctionalTests/RequestTests.cs b/test/Kestrel.Transport.FunctionalTests/RequestTests.cs index 4c1fea6660..b0693ab7a2 100644 --- a/test/Kestrel.Transport.FunctionalTests/RequestTests.cs +++ b/test/Kestrel.Transport.FunctionalTests/RequestTests.cs @@ -220,41 +220,30 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var connectionReset = new SemaphoreSlim(0); var loggedHigherThanDebug = false; - var mockLogger = new Mock(); - mockLogger - .Setup(logger => logger.IsEnabled(It.IsAny())) - .Returns(true); - mockLogger - .Setup(logger => logger.Log(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny>())) - .Callback>((logLevel, eventId, state, exception, formatter) => + TestSink.MessageLogged += context => { + if (context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets") { - Logger.Log(logLevel, eventId, state, exception, formatter); - if (eventId.Id == _connectionStartedEventId) - { - connectionStarted.Release(); - } - else if (eventId.Id == _connectionResetEventId) - { - connectionReset.Release(); - } + return; + } - if (logLevel > LogLevel.Debug) - { - loggedHigherThanDebug = true; - } - }); + if (context.EventId.Id == _connectionStartedEventId) + { + connectionStarted.Release(); + } + else if (context.EventId.Id == _connectionResetEventId) + { + connectionReset.Release(); + } - var mockLoggerFactory = new Mock(); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsAny())) - .Returns(Logger); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsIn("Microsoft.AspNetCore.Server.Kestrel", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets"))) - .Returns(mockLogger.Object); + if (context.LogLevel > LogLevel.Debug) + { + loggedHigherThanDebug = true; + } + }; - using (var server = new TestServer(context => Task.CompletedTask, new TestServiceContext(mockLoggerFactory.Object))) + using (var server = new TestServer(context => Task.CompletedTask, new TestServiceContext(LoggerFactory))) { using (var connection = server.CreateConnection()) { @@ -280,37 +269,26 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var connectionReset = new SemaphoreSlim(0); var loggedHigherThanDebug = false; - var mockLogger = new Mock(); - mockLogger - .Setup(logger => logger.IsEnabled(It.IsAny())) - .Returns(true); - mockLogger - .Setup(logger => logger.Log(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny>())) - .Callback>((logLevel, eventId, state, exception, formatter) => + TestSink.MessageLogged += context => { + if (context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets") { - Logger.Log(logLevel, eventId, state, exception, formatter); - if (eventId.Id == _connectionResetEventId) - { - connectionReset.Release(); - } + return; + } - if (logLevel > LogLevel.Debug) - { - loggedHigherThanDebug = true; - } - }); + if (context.LogLevel > LogLevel.Debug) + { + loggedHigherThanDebug = true; + } - var mockLoggerFactory = new Mock(); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsAny())) - .Returns(Logger); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsIn("Microsoft.AspNetCore.Server.Kestrel", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets"))) - .Returns(mockLogger.Object); + if (context.EventId.Id == _connectionResetEventId) + { + connectionReset.Release(); + } + }; - using (var server = new TestServer(context => Task.CompletedTask, new TestServiceContext(mockLoggerFactory.Object))) + using (var server = new TestServer(context => Task.CompletedTask, new TestServiceContext(LoggerFactory))) { using (var connection = server.CreateConnection()) { @@ -351,43 +329,31 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var connectionClosing = new SemaphoreSlim(0); var loggedHigherThanDebug = false; - var mockLogger = new Mock(); - mockLogger - .Setup(logger => logger.IsEnabled(It.IsAny())) - .Returns(true); - mockLogger - .Setup(logger => logger.Log(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny>())) - .Callback>((logLevel, eventId, state, exception, formatter) => + TestSink.MessageLogged += context => { + if (context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets") { - Logger.Log(logLevel, eventId, state, exception, formatter); + return; + } - if (eventId.Id == _connectionResetEventId) - { - connectionReset.Release(); - } + if (context.LogLevel > LogLevel.Debug) + { + loggedHigherThanDebug = true; + } - if (logLevel > LogLevel.Debug) - { - loggedHigherThanDebug = true; - } - }); - - var mockLoggerFactory = new Mock(); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsAny())) - .Returns(Logger); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsIn("Microsoft.AspNetCore.Server.Kestrel", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets"))) - .Returns(mockLogger.Object); + if (context.EventId.Id == _connectionResetEventId) + { + connectionReset.Release(); + } + }; using (var server = new TestServer(async context => { requestStarted.Release(); await connectionClosing.WaitAsync(); }, - new TestServiceContext(mockLoggerFactory.Object))) + new TestServiceContext(LoggerFactory))) { using (var connection = server.CreateConnection()) { @@ -732,37 +698,25 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var serverClosedConnection = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); var appFuncCompleted = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); - var mockLogger = new Mock(); - mockLogger - .Setup(logger => logger.IsEnabled(It.IsAny())) - .Returns(true); - mockLogger - .Setup(logger => logger.Log(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny>())) - .Callback>((logLevel, eventId, state, exception, formatter) => + TestSink.MessageLogged += context => { + if (context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets") { - if (eventId.Id == connectionPausedEventId) - { - readCallbackUnwired.TrySetResult(null); - } - else if (eventId.Id == connectionFinSentEventId) - { - serverClosedConnection.SetResult(null); - } + return; + } - Logger.Log(logLevel, eventId, state, exception, formatter); - }); - - var mockLoggerFactory = new Mock(); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsAny())) - .Returns(Logger); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsIn("Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets"))) - .Returns(mockLogger.Object); + if (context.EventId.Id == connectionPausedEventId) + { + readCallbackUnwired.TrySetResult(null); + } + else if (context.EventId == connectionFinSentEventId) + { + serverClosedConnection.SetResult(null); + } + }; var mockKestrelTrace = new Mock(); - var testContext = new TestServiceContext(mockLoggerFactory.Object, mockKestrelTrace.Object) + var testContext = new TestServiceContext(LoggerFactory, mockKestrelTrace.Object) { ServerOptions = { diff --git a/test/Kestrel.Transport.FunctionalTests/ResponseTests.cs b/test/Kestrel.Transport.FunctionalTests/ResponseTests.cs index d9aa983cac..40f1ba8b6b 100644 --- a/test/Kestrel.Transport.FunctionalTests/ResponseTests.cs +++ b/test/Kestrel.Transport.FunctionalTests/ResponseTests.cs @@ -253,33 +253,22 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests var clientClosedConnection = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); var writeTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); - var mockKestrelTrace = new Mock(); - var mockLogger = new Mock(); - mockLogger - .Setup(logger => logger.IsEnabled(It.IsAny())) - .Returns(true); - mockLogger - .Setup(logger => logger.Log(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny>())) - .Callback>((logLevel, eventId, state, exception, formatter) => + TestSink.MessageLogged += context => { + if (context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" && + context.LoggerName != "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets") { - if (eventId.Id == connectionPausedEventId) - { - readCallbackUnwired.TrySetResult(null); - } + return; + } - Logger.Log(logLevel, eventId, state, exception, formatter); - }); + if (context.EventId.Id == connectionPausedEventId) + { + readCallbackUnwired.TrySetResult(null); + } + }; - var mockLoggerFactory = new Mock(); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsAny())) - .Returns(Logger); - mockLoggerFactory - .Setup(factory => factory.CreateLogger(It.IsIn("Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", - "Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets"))) - .Returns(mockLogger.Object); + var mockKestrelTrace = new Mock(); - var testContext = new TestServiceContext(mockLoggerFactory.Object, mockKestrelTrace.Object) + var testContext = new TestServiceContext(LoggerFactory, mockKestrelTrace.Object) { ServerOptions = {