diff --git a/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/Startup.cs b/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/Startup.cs index 7945c1d58f..a73137de4f 100644 --- a/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/Startup.cs +++ b/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/Startup.cs @@ -3,6 +3,7 @@ using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Mvc; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using ApiAuthSample.Data; @@ -23,7 +24,9 @@ namespace ApiAuthSample public void ConfigureServices(IServiceCollection services) { services.AddDbContext(options => - options.UseSqlite(Configuration.GetConnectionString("DefaultConnection"))); + options + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseSqlite(Configuration.GetConnectionString("DefaultConnection"))); services.AddDefaultIdentity() .AddEntityFrameworkStores(); diff --git a/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/InMemoryStoreWithGenericsTest.cs b/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/InMemoryStoreWithGenericsTest.cs index 48b71e970b..95e5750d41 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/InMemoryStoreWithGenericsTest.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/InMemoryStoreWithGenericsTest.cs @@ -10,6 +10,7 @@ using System.Threading.Tasks; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Identity.Test; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -24,7 +25,10 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test { var services = new ServiceCollection(); services.AddHttpContextAccessor(); - services.AddDbContext(options => options.UseInMemoryDatabase("Scratch")); + services.AddDbContext( + options => options + .UseInMemoryDatabase("Scratch") + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))); _context = services.BuildServiceProvider().GetRequiredService(); } @@ -330,4 +334,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test } #endregion -} \ No newline at end of file +} diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/DbUtil.cs b/src/Identity/EntityFrameworkCore/test/EF.Test/DbUtil.cs index 608b115276..0ca87b629d 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/DbUtil.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/DbUtil.cs @@ -5,7 +5,9 @@ using System; using System.Data.SqlClient; using System.Linq; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.DependencyInjection; +using Microsoft.Extensions.Logging; using Xunit; namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test @@ -21,7 +23,9 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test services.AddHttpContextAccessor(); services.AddDbContext(options => { - options.UseSqlServer(connectionString); + options + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseSqlServer(connectionString); }); return services; } @@ -101,4 +105,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test } } -} \ No newline at end of file +} diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/DefaultPocoTest.cs b/src/Identity/EntityFrameworkCore/test/EF.Test/DefaultPocoTest.cs index e845e0395a..66d0d41470 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/DefaultPocoTest.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/DefaultPocoTest.cs @@ -6,6 +6,7 @@ using Microsoft.AspNetCore.Builder.Internal; using Microsoft.AspNetCore.Identity.Test; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -23,7 +24,9 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test services .AddSingleton(new ConfigurationBuilder().Build()) - .AddDbContext(o => o.UseSqlServer(fixture.ConnectionString)) + .AddDbContext(o => + o.UseSqlServer(fixture.ConnectionString) + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))) .AddIdentity() .AddEntityFrameworkStores(); @@ -58,4 +61,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test IdentityResultAssert.IsSuccess(await userManager.DeleteAsync(user)); } } -} \ No newline at end of file +} diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/MaxKeyLengthSchemaTest.cs b/src/Identity/EntityFrameworkCore/test/EF.Test/MaxKeyLengthSchemaTest.cs index 8825fea1e2..e2d782a5f1 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/MaxKeyLengthSchemaTest.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/MaxKeyLengthSchemaTest.cs @@ -5,6 +5,7 @@ using System.Data.SqlClient; using Microsoft.AspNetCore.Builder.Internal; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -22,7 +23,9 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test services .AddSingleton(new ConfigurationBuilder().Build()) - .AddDbContext(o => o.UseSqlServer(fixture.ConnectionString)) + .AddDbContext(o => + o.UseSqlServer(fixture.ConnectionString) + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))) .AddIdentity(o => o.Stores.MaxLengthForKeys = 128) .AddEntityFrameworkStores(); @@ -76,4 +79,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test } } } -} \ No newline at end of file +} diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyCustomContextTest.cs b/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyCustomContextTest.cs index 0b20d17ff4..47d1e30d5c 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyCustomContextTest.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyCustomContextTest.cs @@ -6,6 +6,7 @@ using Microsoft.AspNetCore.Builder.Internal; using Microsoft.AspNetCore.Identity.Test; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -67,7 +68,9 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test services .AddSingleton(new ConfigurationBuilder().Build()) - .AddDbContext(o => o.UseSqlServer(fixture.ConnectionString)) + .AddDbContext(o => + o.UseSqlServer(fixture.ConnectionString) + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))) .AddIdentityCore(o => { }) .AddEntityFrameworkStores(); @@ -103,4 +106,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test } } -} \ No newline at end of file +} diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyTest.cs b/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyTest.cs index 4f957016c7..c19711e34a 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyTest.cs +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/UserOnlyTest.cs @@ -6,6 +6,7 @@ using Microsoft.AspNetCore.Builder.Internal; using Microsoft.AspNetCore.Identity.Test; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -28,7 +29,9 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test services .AddSingleton(new ConfigurationBuilder().Build()) - .AddDbContext(o => o.UseSqlServer(fixture.ConnectionString)) + .AddDbContext( + o => o.UseSqlServer(fixture.ConnectionString) + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))) .AddIdentityCore(o => { }) .AddEntityFrameworkStores(); @@ -63,4 +66,4 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test IdentityResultAssert.IsSuccess(await userManager.DeleteAsync(user)); } } -} \ No newline at end of file +} diff --git a/src/Identity/samples/IdentitySample.DefaultUI/Startup.cs b/src/Identity/samples/IdentitySample.DefaultUI/Startup.cs index 76962038f4..2fd942e066 100644 --- a/src/Identity/samples/IdentitySample.DefaultUI/Startup.cs +++ b/src/Identity/samples/IdentitySample.DefaultUI/Startup.cs @@ -3,6 +3,7 @@ using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; @@ -29,7 +30,8 @@ namespace IdentitySample.DefaultUI { // Add framework services. services.AddDbContext( - options => options.UseSqlServer(Configuration.GetConnectionString("DefaultConnection"), + options => options.ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseSqlServer(Configuration.GetConnectionString("DefaultConnection"), x => x.MigrationsAssembly("IdentitySample.DefaultUI"))); services.AddMvc(); @@ -39,7 +41,7 @@ namespace IdentitySample.DefaultUI .AddEntityFrameworkStores(); } - + // This method gets called by the runtime. Use this method to configure the HTTP request pipeline. public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory) { @@ -65,4 +67,4 @@ namespace IdentitySample.DefaultUI }); } } -} \ No newline at end of file +} diff --git a/src/Identity/samples/IdentitySample.Mvc/Startup.cs b/src/Identity/samples/IdentitySample.Mvc/Startup.cs index 6f6134a62e..15db01da7f 100644 --- a/src/Identity/samples/IdentitySample.Mvc/Startup.cs +++ b/src/Identity/samples/IdentitySample.Mvc/Startup.cs @@ -4,6 +4,7 @@ using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Identity; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; @@ -30,7 +31,8 @@ namespace IdentitySample { // Add framework services. services.AddDbContext(options => - options.UseSqlServer(Configuration.GetConnectionString("DefaultConnection"))); + options.ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseSqlServer(Configuration.GetConnectionString("DefaultConnection"))); services.AddMvc(); @@ -77,4 +79,4 @@ namespace IdentitySample }); } } -} \ No newline at end of file +} diff --git a/src/Identity/test/Identity.FunctionalTests/Infrastructure/FunctionalTestsServiceCollectionExtensions.cs b/src/Identity/test/Identity.FunctionalTests/Infrastructure/FunctionalTestsServiceCollectionExtensions.cs index 93ecf771b6..50f67cad09 100644 --- a/src/Identity/test/Identity.FunctionalTests/Infrastructure/FunctionalTestsServiceCollectionExtensions.cs +++ b/src/Identity/test/Identity.FunctionalTests/Infrastructure/FunctionalTestsServiceCollectionExtensions.cs @@ -11,6 +11,7 @@ using Microsoft.AspNetCore.Identity.EntityFrameworkCore; using Microsoft.AspNetCore.Identity.UI.Services; using Microsoft.AspNetCore.Mvc.Authorization; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.DependencyInjection; namespace Microsoft.AspNetCore.Identity.FunctionalTests @@ -19,7 +20,8 @@ namespace Microsoft.AspNetCore.Identity.FunctionalTests { public static IServiceCollection SetupTestDatabase(this IServiceCollection services, string databaseName) where TContext : DbContext => services.AddDbContext(options => - options.UseInMemoryDatabase(databaseName, memoryOptions => { })); + options.ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseInMemoryDatabase(databaseName, memoryOptions => { })); public static IServiceCollection SetupTestThirdPartyLogin(this IServiceCollection services) => services.AddAuthentication() diff --git a/src/Identity/testassets/Identity.DefaultUI.WebSite/StartupBase.cs b/src/Identity/testassets/Identity.DefaultUI.WebSite/StartupBase.cs index c73d12f7ad..3fb53fa2e8 100644 --- a/src/Identity/testassets/Identity.DefaultUI.WebSite/StartupBase.cs +++ b/src/Identity/testassets/Identity.DefaultUI.WebSite/StartupBase.cs @@ -6,6 +6,7 @@ using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Identity; using Microsoft.AspNetCore.Identity.UI; using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore.Diagnostics; using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.FileProviders; @@ -35,10 +36,12 @@ namespace Identity.DefaultUI.WebSite }); services.AddDbContext(options => - options.UseSqlServer( - Configuration.GetConnectionString("DefaultConnection"), - sqlOptions => sqlOptions.MigrationsAssembly("Identity.DefaultUI.WebSite") - )); + options + .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning)) + .UseSqlServer( + Configuration.GetConnectionString("DefaultConnection"), + sqlOptions => sqlOptions.MigrationsAssembly("Identity.DefaultUI.WebSite") + )); services.AddDefaultIdentity() .AddDefaultUI(Framework)