From 6436538068d19c475d5f7c9ce3d0080d2314f69d Mon Sep 17 00:00:00 2001
From: Doug Bunting <dougbu@microsoft.com>
Date: Sun, 26 Mar 2017 22:35:18 -0700
Subject: [PATCH] Rename `IHtmlHelper.TextBox()` parameter (for consistency) -
 #5394

---
 .../Internal/DefaultEditorTemplates.cs              |  2 +-
 .../Rendering/IHtmlHelper.cs                        | 12 ++++++------
 .../exceptions.net45.json                           | 13 ++++++++++++-
 .../exceptions.netcore.json                         | 13 ++++++++++++-
 4 files changed, 31 insertions(+), 9 deletions(-)

diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultEditorTemplates.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultEditorTemplates.cs
index 1fce1dc8d5..6248883489 100644
--- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultEditorTemplates.cs
+++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Internal/DefaultEditorTemplates.cs
@@ -437,7 +437,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal
         private static IHtmlContent GenerateTextBox(IHtmlHelper htmlHelper, object value, object htmlAttributes)
         {
             return htmlHelper.TextBox(
-                current: null,
+                expression: null,
                 value: value,
                 format: null,
                 htmlAttributes: htmlAttributes);
diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/IHtmlHelper.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/IHtmlHelper.cs
index c757db49f9..0a31ca723a 100644
--- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/IHtmlHelper.cs
+++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/IHtmlHelper.cs
@@ -634,16 +634,16 @@ namespace Microsoft.AspNetCore.Mvc.Rendering
         IHtmlContent TextArea(string expression, string value, int rows, int columns, object htmlAttributes);
 
         /// <summary>
-        /// Returns an &lt;input&gt; element of type "text" for the specified <paramref name="current"/>. Adds a
+        /// Returns an &lt;input&gt; element of type "text" for the specified <paramref name="expression"/>. Adds a
         /// "value" attribute to the element containing the first non-<c>null</c> value found in:
         /// the <see cref="ActionContext.ModelState"/> entry with full name,
         /// the <paramref name="value"/> parameter,
         /// the <see cref="ViewData"/> entry with full name,
-        /// the <paramref name="current"/> evaluated against <see cref="ViewDataDictionary.Model"/>, or
+        /// the <paramref name="expression"/> evaluated against <see cref="ViewDataDictionary.Model"/>, or
         /// the <paramref name="htmlAttributes"/> dictionary entry with key "value".
         /// See <see cref="Name"/> for more information about a "full name".
         /// </summary>
-        /// <param name="current">Expression name, relative to the current model.</param>
+        /// <param name="expression">Expression name, relative to the current model.</param>
         /// <param name="value">If non-<c>null</c>, value to include in the element.</param>
         /// <param name="format">
         /// The format string (see https://msdn.microsoft.com/en-us/library/txafckwd.aspx) used to format the "value"
@@ -655,11 +655,11 @@ namespace Microsoft.AspNetCore.Mvc.Rendering
         /// </param>
         /// <returns>A new <see cref="IHtmlContent"/> containing the &lt;input&gt; element.</returns>
         /// <remarks>
-        /// Combines <see cref="TemplateInfo.HtmlFieldPrefix"/> and <paramref name="current"/> to set
-        /// &lt;input&gt; element's "name" attribute. Sanitizes <paramref name="current"/> to set element's "id"
+        /// Combines <see cref="TemplateInfo.HtmlFieldPrefix"/> and <paramref name="expression"/> to set
+        /// &lt;input&gt; element's "name" attribute. Sanitizes <paramref name="expression"/> to set element's "id"
         /// attribute.
         /// </remarks>
-        IHtmlContent TextBox(string current, object value, string format, object htmlAttributes);
+        IHtmlContent TextBox(string expression, object value, string format, object htmlAttributes);
 
         /// <summary>
         /// Returns the validation message if an error exists in the <see cref="ModelStateDictionary"/> object
diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.net45.json b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.net45.json
index 3f5e07c865..d3c60e975f 100644
--- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.net45.json
+++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.net45.json
@@ -1,10 +1,21 @@
 [
+    {
+        "OldTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "OldMemberId": "Microsoft.AspNetCore.Html.IHtmlContent TextBox(System.String current, System.Object value, System.String format, System.Object htmlAttributes)",
+        "Kind": "Removal"
+    },
+    {
+        "OldTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "NewTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "NewMemberId": "Microsoft.AspNetCore.Html.IHtmlContent TextBox(System.String expression, System.Object value, System.String format, System.Object htmlAttributes)",
+        "Kind": "Addition"
+    },
     {
         "OldTypeId": "public class Microsoft.AspNetCore.Mvc.ViewComponentResult : Microsoft.AspNetCore.Mvc.ActionResult",
         "OldMemberId": "public Microsoft.AspNetCore.Mvc.ViewEngines.IViewEngine get_ViewEngine()",
         "Kind": "Removal"
     },
-     {
+    {
         "OldTypeId": "public class Microsoft.AspNetCore.Mvc.ViewComponentResult : Microsoft.AspNetCore.Mvc.ActionResult",
         "OldMemberId": "public System.Void set_ViewEngine(Microsoft.AspNetCore.Mvc.ViewEngines.IViewEngine value)",
         "Kind": "Removal"
diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.netcore.json b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.netcore.json
index 3f5e07c865..d3c60e975f 100644
--- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.netcore.json
+++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/exceptions.netcore.json
@@ -1,10 +1,21 @@
 [
+    {
+        "OldTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "OldMemberId": "Microsoft.AspNetCore.Html.IHtmlContent TextBox(System.String current, System.Object value, System.String format, System.Object htmlAttributes)",
+        "Kind": "Removal"
+    },
+    {
+        "OldTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "NewTypeId": "public interface Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper",
+        "NewMemberId": "Microsoft.AspNetCore.Html.IHtmlContent TextBox(System.String expression, System.Object value, System.String format, System.Object htmlAttributes)",
+        "Kind": "Addition"
+    },
     {
         "OldTypeId": "public class Microsoft.AspNetCore.Mvc.ViewComponentResult : Microsoft.AspNetCore.Mvc.ActionResult",
         "OldMemberId": "public Microsoft.AspNetCore.Mvc.ViewEngines.IViewEngine get_ViewEngine()",
         "Kind": "Removal"
     },
-     {
+    {
         "OldTypeId": "public class Microsoft.AspNetCore.Mvc.ViewComponentResult : Microsoft.AspNetCore.Mvc.ActionResult",
         "OldMemberId": "public System.Void set_ViewEngine(Microsoft.AspNetCore.Mvc.ViewEngines.IViewEngine value)",
         "Kind": "Removal"