huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use Node https module for https requests (#3171)

This commit is contained in:
BrennanConroy 2018-10-23 08:21:54 -07:00 committed by GitHub
parent 2bea4608fa
commit 63900a462b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clients/ts/signalr/src/NodeHttpClient.ts
View File

@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
import * as http from "http"; import * as http from "http";
import * as https from "https";
import { URL } from "url"; import { URL } from "url";
import { AbortError, HttpError, TimeoutError } from "./Errors"; import { AbortError, HttpError, TimeoutError } from "./Errors";
@ -33,7 +34,12 @@ export class NodeHttpClient extends HttpClient {
port: url.port, port: url.port,
}; };
const req = http.request(options, (res: http.IncomingMessage) => { // "any" is used here because require() can't be correctly resolved by the compiler
// when httpOrHttps is typeof http | typeof https. Change to http when editing to get
// intellisense.
const httpOrHttps: any = url.protocol === "https" ? https : http;
const req = httpOrHttps.request(options, (res: http.IncomingMessage) => {
const data: Buffer[] = []; const data: Buffer[] = [];
let dataLength = 0; let dataLength = 0;
res.on("data", (chunk: any) => { res.on("data", (chunk: any) => {
@ -76,7 +82,7 @@ export class NodeHttpClient extends HttpClient {
}); });
} }
req.on("error", (e) => { req.on("error", (e: Error) => {
this.logger.log(LogLevel.Warning, `Error from HTTP request. ${e}`); this.logger.log(LogLevel.Warning, `Error from HTTP request. ${e}`);
reject(e); reject(e);
}); });