huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Unskip skipped tests

This commit is contained in:
Pranav K 2018-05-29 11:20:35 -07:00
parent 8e31319215
commit 632425d0e6
3 changed files with 12 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/Microsoft.AspNetCore.Mvc.Core.Test/FileResultTest.cs
View File

@ -30,8 +30,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal("text/plain", result.ContentType.ToString()); Assert.Equal("text/plain", result.ContentType.ToString());
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task ContentDispositionHeader_IsEncodedCorrectly() public async Task ContentDispositionHeader_IsEncodedCorrectly()
{ {
// See comment in FileResult.cs detailing how the FileDownloadName should be encoded. // See comment in FileResult.cs detailing how the FileDownloadName should be encoded.
@ -55,8 +54,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(@"attachment; filename=""some\\file""; filename*=UTF-8''some%5Cfile", httpContext.Response.Headers["Content-Disposition"]); Assert.Equal(@"attachment; filename=""some\\file""; filename*=UTF-8''some%5Cfile", httpContext.Response.Headers["Content-Disposition"]);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task ContentDispositionHeader_IsEncodedCorrectly_ForUnicodeCharacters() public async Task ContentDispositionHeader_IsEncodedCorrectly_ForUnicodeCharacters()
{ {
// Arrange // Arrange
@ -78,8 +76,7 @@ namespace Microsoft.AspNetCore.Mvc
httpContext.Response.Headers["Content-Disposition"]); httpContext.Response.Headers["Content-Disposition"]);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task ExecuteResultAsync_DoesNotSetContentDisposition_IfNotSpecified() public async Task ExecuteResultAsync_DoesNotSetContentDisposition_IfNotSpecified()
{ {
// Arrange // Arrange
@ -104,8 +101,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(Stream.Null, httpContext.Response.Body); Assert.Equal(Stream.Null, httpContext.Response.Body);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task ExecuteResultAsync_SetsContentDisposition_IfSpecified() public async Task ExecuteResultAsync_SetsContentDisposition_IfSpecified()
{ {
// Arrange // Arrange
@ -126,8 +122,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal("attachment; filename=filename.ext; filename*=UTF-8''filename.ext", httpContext.Response.Headers["Content-Disposition"]); Assert.Equal("attachment; filename=filename.ext; filename*=UTF-8''filename.ext", httpContext.Response.Headers["Content-Disposition"]);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task ExecuteResultAsync_ThrowsException_IfCannotResolveLoggerFactory() public async Task ExecuteResultAsync_ThrowsException_IfCannotResolveLoggerFactory()
{ {
// Arrange // Arrange
@ -234,8 +229,7 @@ namespace Microsoft.AspNetCore.Mvc
Assert.Equal(expectedOutput, actual); Assert.Equal(expectedOutput, actual);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public async Task SetsAcceptRangeHeader() public async Task SetsAcceptRangeHeader()
{ {
// Arrange // Arrange
@ -538,4 +532,4 @@ namespace Microsoft.AspNetCore.Mvc
} }
} }
} }
} }

6
test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerCacheTest.cs
View File

@ -21,8 +21,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
{ {
public class ControllerActionInvokerCacheTest public class ControllerActionInvokerCacheTest
{ {
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetControllerActionMethodExecutor_CachesFilters() public void GetControllerActionMethodExecutor_CachesFilters()
{ {
// Arrange // Arrange
@ -43,8 +42,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
Assert.Equal(cacheEntry1.filters, cacheEntry2.filters); Assert.Equal(cacheEntry1.filters, cacheEntry2.filters);
} }
[ConditionalFact] [Fact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
public void GetControllerActionMethodExecutor_CachesEntry() public void GetControllerActionMethodExecutor_CachesEntry()
{ {
// Arrange // Arrange

9
test/Microsoft.AspNetCore.Mvc.RazorPages.Test/Internal/PageRouteModelFactoryTest.cs
View File

@ -165,8 +165,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
}); });
} }
[ConditionalTheory] [Theory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[InlineData("/Areas/About.cshtml")] [InlineData("/Areas/About.cshtml")]
[InlineData("/Areas/MyArea/Index.cshtml")] [InlineData("/Areas/MyArea/Index.cshtml")]
public void TryParseAreaPath_ReturnsFalse_IfPathDoesNotConform(string path) public void TryParseAreaPath_ReturnsFalse_IfPathDoesNotConform(string path)
@ -182,8 +181,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
Assert.False(success); Assert.False(success);
} }
[ConditionalTheory] [Theory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[InlineData("/Areas/MyArea/Views/About.cshtml")] [InlineData("/Areas/MyArea/Views/About.cshtml")]
[InlineData("/Areas/MyArea/SubDir/Pages/Index.cshtml")] [InlineData("/Areas/MyArea/SubDir/Pages/Index.cshtml")]
[InlineData("/Areas/MyArea/NotPages/SubDir/About.cshtml")] [InlineData("/Areas/MyArea/NotPages/SubDir/About.cshtml")]
@ -200,8 +198,7 @@ namespace Microsoft.AspNetCore.Mvc.RazorPages.Internal
Assert.False(success); Assert.False(success);
} }
[ConditionalTheory] [Theory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "Fails due to dotnet/standard#567")]
[InlineData("/Areas/MyArea/Pages/Index.cshtml", "MyArea", "/Index")] [InlineData("/Areas/MyArea/Pages/Index.cshtml", "MyArea", "/Index")]
[InlineData("/Areas/Accounts/Pages/Manage/Edit.cshtml", "Accounts", "/Manage/Edit")] [InlineData("/Areas/Accounts/Pages/Manage/Edit.cshtml", "Accounts", "/Manage/Edit")]
public void TryParseAreaPath_ParsesAreaPath( public void TryParseAreaPath_ParsesAreaPath(