huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add comments cautioning against changing DeveloperCertificates.XPlat (#19923) 

* Add comments cautioning against changing DeveloperCertificates.XPlat

* Fix bad comment ending
This commit is contained in:
William Godbe 2020-03-19 12:27:28 -07:00 committed by GitHub
parent ced13c28cc
commit 6301eefbc3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
eng/Publishing.props
View File

@ -34,6 +34,7 @@
<!-- <!--
This target is defined in eng/targets/Packaging.targets and included in every C# and F# project. This target is defined in eng/targets/Packaging.targets and included in every C# and F# project.
We use Microsoft.AspNetCore.DeveloperCertificates.XPlat because it is a nonshipping package, and we need a non-stable version string to use as our publish location. We use Microsoft.AspNetCore.DeveloperCertificates.XPlat because it is a nonshipping package, and we need a non-stable version string to use as our publish location.
If Microsoft.AspNetCore.DeveloperCertificates.XPlat ever becomes a shipping package, this logic will break, so be careful
--> -->
<MSBuild Projects="$(RepoRoot)src\Tools\FirstRunCertGenerator\src\Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj" <MSBuild Projects="$(RepoRoot)src\Tools\FirstRunCertGenerator\src\Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj"
Targets="_GetPackageVersionInfo" Targets="_GetPackageVersionInfo"

4
src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj
View File

@ -7,6 +7,10 @@
<PackageTags>aspnet;cli</PackageTags> <PackageTags>aspnet;cli</PackageTags>
<!-- This package contains API for the .NET CLI to generate the aspnet HTTPs dev cert during CLI first-run initialization. --> <!-- This package contains API for the .NET CLI to generate the aspnet HTTPs dev cert during CLI first-run initialization. -->
<!-- Our publishing logic depends on this particular package being NonShipping - if this ever becomes a Shipping project, we will incorrectly calculate the repo's version string,
which will cause us to publish installers & checksums to the wrong place. If this ever becomes a Shipping project, we also need to update the following line to reference a different NonShipping project:
https://github.com/dotnet/aspnetcore/blob/99c9b8ace1d1d916109882d3f983a26ea4e9b66a/eng/Publishing.props#L38 -->
<IsShippingPackage>false</IsShippingPackage> <IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly> <HasReferenceAssembly>false</HasReferenceAssembly>
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>