huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove async from WriteAsync in SocketOutput (#1531) 

- SocketOutput.WriteAsync will be synchronous for a majority of cases
(until you reach the limit) so no need to pay the async state machine
cost until then.
This commit is contained in:
David Fowler 2017-03-21 09:52:24 -07:00 committed by GitHub
parent 32d6b42964
commit 5fad3c7a3e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/SocketOutput.cs
View File

@ -59,7 +59,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
_onFlushCallback = OnFlush;
}
public async Task WriteAsync(
public Task WriteAsync(
ArraySegment<byte> buffer,
CancellationToken cancellationToken,
bool chunk = false)
@ -72,12 +72,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
{
_log.ConnectionDisconnectedWrite(_connectionId, buffer.Count, _lastWriteError);
return;
return TaskCache.CompletedTask;
}
if (_completed)
{
return;
return TaskCache.CompletedTask;
}
writableBuffer = _pipe.Writer.Alloc();
@ -100,7 +100,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
writableBuffer.Commit();
}
await FlushAsync(writableBuffer);
return FlushAsync(writableBuffer);
}
public void End(ProduceEndType endType)