From 5e883827e0c1ed18bdf0badeebb863a315b24098 Mon Sep 17 00:00:00 2001 From: Ben Adams Date: Mon, 2 Nov 2015 01:50:17 +0000 Subject: [PATCH] Explain why dispose can't be used --- src/Microsoft.AspNet.Server.Kestrel/Http/FrameRequestStream.cs | 2 ++ src/Microsoft.AspNet.Server.Kestrel/Http/FrameResponseStream.cs | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/Microsoft.AspNet.Server.Kestrel/Http/FrameRequestStream.cs b/src/Microsoft.AspNet.Server.Kestrel/Http/FrameRequestStream.cs index 90ebe8601e..6545b09e9b 100644 --- a/src/Microsoft.AspNet.Server.Kestrel/Http/FrameRequestStream.cs +++ b/src/Microsoft.AspNet.Server.Kestrel/Http/FrameRequestStream.cs @@ -121,6 +121,8 @@ namespace Microsoft.AspNet.Server.Kestrel.Http public void StopAcceptingReads() { + // Can't use dispose (or close) as can be disposed too early by user code + // As exampled in EngineTests.ZeroContentLengthNotSetAutomaticallyForCertainStatusCodes _stopped = true; } } diff --git a/src/Microsoft.AspNet.Server.Kestrel/Http/FrameResponseStream.cs b/src/Microsoft.AspNet.Server.Kestrel/Http/FrameResponseStream.cs index 813ef23ba4..465e5fe3d2 100644 --- a/src/Microsoft.AspNet.Server.Kestrel/Http/FrameResponseStream.cs +++ b/src/Microsoft.AspNet.Server.Kestrel/Http/FrameResponseStream.cs @@ -91,6 +91,8 @@ namespace Microsoft.AspNet.Server.Kestrel.Http public void StopAcceptingWrites() { + // Can't use dispose (or close) as can be disposed too early by user code + // As exampled in EngineTests.ZeroContentLengthNotSetAutomaticallyForCertainStatusCodes _stopped = true; } }