From 5d6fcb07da752931416fc2a2cbf38376b7607573 Mon Sep 17 00:00:00 2001 From: Mikael Mengistu Date: Fri, 4 Nov 2016 17:59:04 -0700 Subject: [PATCH] Throw for trackAllCaptures --- .../IISUrlRewrite/UrlRewriteFileParser.cs | 4 ++++ .../FormatExceptionHandlingTests.cs | 21 +++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs b/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs index c8d20bedb8..889d3e209a 100644 --- a/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs +++ b/src/Microsoft.AspNetCore.Rewrite/Internal/IISUrlRewrite/UrlRewriteFileParser.cs @@ -110,6 +110,10 @@ namespace Microsoft.AspNetCore.Rewrite.Internal.IISUrlRewrite var grouping = ParseEnum(conditions, RewriteTags.LogicalGrouping, LogicalGrouping.MatchAll); var trackAllCaptures = ParseBool(conditions, RewriteTags.TrackAllCaptures, defaultValue: false); + if (trackAllCaptures) + { + throw new NotSupportedException("Support for trackAllCaptures has not been implemented yet"); + } builder.AddUrlConditions(grouping, trackAllCaptures); foreach (var cond in conditions.Elements(RewriteTags.Add)) diff --git a/test/Microsoft.AspNetCore.Rewrite.Tests/IISUrlRewrite/FormatExceptionHandlingTests.cs b/test/Microsoft.AspNetCore.Rewrite.Tests/IISUrlRewrite/FormatExceptionHandlingTests.cs index c14f062e64..575135b543 100644 --- a/test/Microsoft.AspNetCore.Rewrite.Tests/IISUrlRewrite/FormatExceptionHandlingTests.cs +++ b/test/Microsoft.AspNetCore.Rewrite.Tests/IISUrlRewrite/FormatExceptionHandlingTests.cs @@ -264,5 +264,26 @@ namespace Microsoft.AspNetCore.Rewrite.Tests.UrlRewrite var ex = Assert.Throws(() => new UrlRewriteFileParser().Parse(new StringReader(input))); Assert.Equal(expected, ex.Message); } + + [Theory] + [InlineData( +@" + + + + + + + + + +", + "Support for trackAllCaptures has not been implemented yet")] + public void ThrowNotSupportedExceptionWithCorrectMessage(string input, string expected) + { + // Arrange, Act, Assert + var ex = Assert.Throws(() => new UrlRewriteFileParser().Parse(new StringReader(input))); + Assert.Equal(expected, ex.Message); + } } }