Small Refactorings

Use nameof
Replace with single call to SingleOrDefault
Replace with single call to FirstOrDefault
Simplify conditionals

src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/BindingSource.cs

@@ -183,7 +183,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
         /// <inheritdoc />
         public bool Equals(BindingSource other)
         {
-            return other == null ? false : string.Equals(other.Id, Id, StringComparison.Ordinal);
+            return string.Equals(other?.Id, Id, StringComparison.Ordinal);
         }
 
         /// <inheritdoc />

src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/ValueProviderResult.cs

@@ -96,7 +96,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
         public override bool Equals(object obj)
         {
             var other = obj as ValueProviderResult?;
-            return other.HasValue ? Equals(other.Value) : false;
+            return other.HasValue && Equals(other.Value);
         }
 
         /// <inheritdoc />

src/Microsoft.AspNetCore.Mvc.Core/Internal/AttributeRoute.cs

@@ -220,8 +220,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
             ActionDescriptor action)
         {
             var constraint = action.RouteConstraints
-                .Where(c => c.RouteKey == TreeRouter.RouteGroupKey)
+                .FirstOrDefault(c => c.RouteKey == TreeRouter.RouteGroupKey);
-                .FirstOrDefault();
             if (constraint == null ||
                 constraint.KeyHandling != RouteKeyHandling.RequireKey ||
                 constraint.RouteValue == null)

src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultApplicationModelProvider.cs

@@ -592,8 +592,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
             var routeTemplateProvider =
                 attributes
                 .OfType<IRouteTemplateProvider>()
-                .Where(a => !IsSilentRouteAttribute(a))
+                .SingleOrDefault(a => !IsSilentRouteAttribute(a));
-                .SingleOrDefault();
 
             if (routeTemplateProvider != null)
             {

src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/JQueryFormValueProviderFactory.cs

@@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
             {
                 throw new ArgumentNullException(nameof(context));
             }
-            
+
             var request = context.ActionContext.HttpContext.Request;
             if (request.HasFormContentType)
             {
@@ -106,7 +106,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
                 {
                     throw new ArgumentException(
                         message: Resources.FormatJQueryFormValueProviderFactory_MissingClosingBracket(key),
-                        paramName: "key");
+                        paramName: nameof(key));
                 }
 
                 if (indexClose == indexOpen + 1)