Addressed feedback

This commit is contained in:
Ajay Bhargav Baaskaran 2016-09-16 11:01:51 -07:00
parent 0cfd5363f8
commit 5ad5f7a3f9
4 changed files with 10 additions and 15 deletions

View File

@ -47,7 +47,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Host.Internal
public string ViewContextTypeName { get; set; } public string ViewContextTypeName { get; set; }
/// <summary> /// <summary>
/// Name of the ViewContextAttribute type for view execution. /// Name of the ViewContextAttribute type.
/// </summary> /// </summary>
public string ViewContextAttributeTypeName { get; set; } public string ViewContextAttributeTypeName { get; set; }
} }

View File

@ -165,10 +165,8 @@ namespace Microsoft.Extensions.DependencyInjection
services.TryAddSingleton<ITagHelperTypeResolver, TagHelperTypeResolver>(); services.TryAddSingleton<ITagHelperTypeResolver, TagHelperTypeResolver>();
services.TryAddSingleton<ITagHelperDescriptorFactory>(s => new TagHelperDescriptorFactory(designTime: false)); services.TryAddSingleton<ITagHelperDescriptorFactory>(s => new TagHelperDescriptorFactory(designTime: false));
services.TryAddSingleton<TagHelperDescriptorResolver, TagHelperDescriptorResolver>(); services.TryAddSingleton<TagHelperDescriptorResolver>();
services.TryAddSingleton<ViewComponentTagHelperDescriptorResolver>();
// And ViewComponentTagHelper resolver.
services.TryAddSingleton<ViewComponentTagHelperDescriptorResolver, ViewComponentTagHelperDescriptorResolver>();
services.TryAddSingleton<ITagHelperDescriptorResolver, CompositeTagHelperDescriptorResolver>(); services.TryAddSingleton<ITagHelperDescriptorResolver, CompositeTagHelperDescriptorResolver>();
// Caches compilation artifacts across the lifetime of the application. // Caches compilation artifacts across the lifetime of the application.

View File

@ -9,26 +9,23 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal
{ {
public class CompositeTagHelperDescriptorResolver : ITagHelperDescriptorResolver public class CompositeTagHelperDescriptorResolver : ITagHelperDescriptorResolver
{ {
public IList<TagHelperDescriptorResolver> _resolvers; private readonly TagHelperDescriptorResolver _tagHelperDescriptorResolver;
private readonly ViewComponentTagHelperDescriptorResolver _viewComponentTagHelperDescriptorResolver;
public CompositeTagHelperDescriptorResolver( public CompositeTagHelperDescriptorResolver(
TagHelperDescriptorResolver tagHelperDescriptorResolver, TagHelperDescriptorResolver tagHelperDescriptorResolver,
ViewComponentTagHelperDescriptorResolver viewComponentTagHelperDescriptorResolver) ViewComponentTagHelperDescriptorResolver viewComponentTagHelperDescriptorResolver)
{ {
_resolvers = new List<TagHelperDescriptorResolver>(); _tagHelperDescriptorResolver = tagHelperDescriptorResolver;
_resolvers.Add(tagHelperDescriptorResolver); _viewComponentTagHelperDescriptorResolver = viewComponentTagHelperDescriptorResolver;
_resolvers.Add(viewComponentTagHelperDescriptorResolver);
} }
public IEnumerable<TagHelperDescriptor> Resolve(TagHelperDescriptorResolutionContext resolutionContext) public IEnumerable<TagHelperDescriptor> Resolve(TagHelperDescriptorResolutionContext resolutionContext)
{ {
var descriptors = new List<TagHelperDescriptor>(); var descriptors = new List<TagHelperDescriptor>();
foreach (var resolver in _resolvers) descriptors.AddRange(_tagHelperDescriptorResolver.Resolve(resolutionContext));
{ descriptors.AddRange(_viewComponentTagHelperDescriptorResolver.Resolve(resolutionContext));
var currentDescriptors = resolver.Resolve(resolutionContext);
descriptors.AddRange(currentDescriptors);
}
return descriptors; return descriptors;
} }

View File

@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Mvc.Razor.Internal
{ {
public class ViewComponentTagHelperDescriptorResolver : TagHelperDescriptorResolver public class ViewComponentTagHelperDescriptorResolver : TagHelperDescriptorResolver
{ {
ViewComponentTagHelperDescriptorFactory _descriptorFactory; private readonly ViewComponentTagHelperDescriptorFactory _descriptorFactory;
public ViewComponentTagHelperDescriptorResolver( public ViewComponentTagHelperDescriptorResolver(
IViewComponentDescriptorProvider viewComponentDescriptorProvider) IViewComponentDescriptorProvider viewComponentDescriptorProvider)