Merge branch 'release/2.2'

This commit is contained in:
Chris Ross (ASP.NET) 2018-10-10 14:33:17 -07:00
commit 5a3c664566
4 changed files with 2 additions and 14 deletions

View File

@ -35,9 +35,7 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
+ $" --output \"{publishDirectory.FullName}\"" + $" --output \"{publishDirectory.FullName}\""
+ $" --framework {deploymentParameters.TargetFramework}" + $" --framework {deploymentParameters.TargetFramework}"
+ $" --configuration {deploymentParameters.Configuration}" + $" --configuration {deploymentParameters.Configuration}"
+ (deploymentParameters.RestoreOnPublish + " --no-restore -p:VerifyMatchingImplicitPackageVersion=false";
? string.Empty
: " --no-restore -p:VerifyMatchingImplicitPackageVersion=false");
// Set VerifyMatchingImplicitPackageVersion to disable errors when Microsoft.NETCore.App's version is overridden externally // Set VerifyMatchingImplicitPackageVersion to disable errors when Microsoft.NETCore.App's version is overridden externally
// This verification doesn't matter if we are skipping restore during tests. // This verification doesn't matter if we are skipping restore during tests.

View File

@ -35,11 +35,6 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
throw new InvalidOperationException("DeploymentParameters.PublishedApplicationRootPath not supported"); throw new InvalidOperationException("DeploymentParameters.PublishedApplicationRootPath not supported");
} }
if (deploymentParameters.RestoreOnPublish)
{
throw new InvalidOperationException("DeploymentParameters.RestoreOnPublish not supported");
}
var dotnetPublishParameters = new DotnetPublishParameters var dotnetPublishParameters = new DotnetPublishParameters
{ {
TargetFramework = deploymentParameters.TargetFramework, TargetFramework = deploymentParameters.TargetFramework,

View File

@ -147,11 +147,6 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
/// </summary> /// </summary>
public string AdditionalPublishParameters { get; set; } public string AdditionalPublishParameters { get; set; }
/// <summary>
/// Publish restores by default, this property opts out by default.
/// </summary>
public bool RestoreOnPublish { get; set; }
/// <summary> /// <summary>
/// To publish the application before deployment. /// To publish the application before deployment.
/// </summary> /// </summary>

View File

@ -9,7 +9,7 @@ namespace Microsoft.Extensions.Hosting
public interface IHostLifetime public interface IHostLifetime
{ {
/// <summary> /// <summary>
/// Called at the start of <see cref="IHost.StartAsync(CancellationToken)"/> which will wait until it's compete before /// Called at the start of <see cref="IHost.StartAsync(CancellationToken)"/> which will wait until it's complete before
/// continuing. This can be used to delay startup until signaled by an external event. /// continuing. This can be used to delay startup until signaled by an external event.
/// </summary> /// </summary>
Task WaitForStartAsync(CancellationToken cancellationToken); Task WaitForStartAsync(CancellationToken cancellationToken);