huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Move aspnet/External#18 comments into `SkipReason`

This commit is contained in:
Doug Bunting 2016-01-04 18:30:22 -08:00
parent d26cc11e13
commit 5a0fb8551b
13 changed files with 62 additions and 122 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerInputFormatterTest.cs
View File

@ -54,8 +54,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml", true)] [InlineData("application/xml", true)]
[InlineData("application/*", false)] [InlineData("application/*", false)]
[InlineData("*/*", false)] [InlineData("*/*", false)]
@ -91,8 +90,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public void XmlDataContractSerializer_CachesSerializerForType() public void XmlDataContractSerializer_CachesSerializerForType()
{ {
// Arrange // Arrange
@ -137,8 +135,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ReadsSimpleTypes() public async Task ReadAsync_ReadsSimpleTypes()
{ {
// Arrange // Arrange
@ -166,8 +163,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ReadsComplexTypes() public async Task ReadAsync_ReadsComplexTypes()
{ {
// Arrange // Arrange
@ -198,8 +194,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ReadsWhenMaxDepthIsModified() public async Task ReadAsync_ReadsWhenMaxDepthIsModified()
{ {
// Arrange // Arrange
@ -274,8 +269,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_VerifyStreamIsOpenAfterRead() public async Task ReadAsync_VerifyStreamIsOpenAfterRead()
{ {
// Arrange // Arrange
@ -296,8 +290,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_FallsbackToUTF8_WhenCharSet_NotInContentType() public async Task ReadAsync_FallsbackToUTF8_WhenCharSet_NotInContentType()
{ {
// Arrange // Arrange
@ -325,8 +318,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_UsesContentTypeCharSet_ToReadStream() public async Task ReadAsync_UsesContentTypeCharSet_ToReadStream()
{ {
// Arrange // Arrange
@ -358,8 +350,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_IgnoresBOMCharacters() public async Task ReadAsync_IgnoresBOMCharacters()
{ {
// Arrange // Arrange
@ -392,8 +383,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_AcceptsUTF16Characters() public async Task ReadAsync_AcceptsUTF16Characters()
{ {
// Arrange // Arrange
@ -432,8 +422,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ThrowsWhenNotConfiguredWithRootName() public async Task ReadAsync_ThrowsWhenNotConfiguredWithRootName()
{ {
// Arrange // Arrange
@ -453,8 +442,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ReadsWhenConfiguredWithRootName() public async Task ReadAsync_ReadsWhenConfiguredWithRootName()
{ {
// Arrange // Arrange
@ -492,8 +480,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ThrowsWhenNotConfiguredWithKnownTypes() public async Task ReadAsync_ThrowsWhenNotConfiguredWithKnownTypes()
{ {
// Arrange // Arrange
@ -514,8 +501,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ReadAsync_ReadsWhenConfiguredWithKnownTypes() public async Task ReadAsync_ReadsWhenConfiguredWithKnownTypes()
{ {
// Arrange // Arrange

58
test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs
View File

@ -94,8 +94,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[MemberData(nameof(BasicTypeValues))] [MemberData(nameof(BasicTypeValues))]
public async Task WriteAsync_CanWriteBasicTypes(object input, string expectedOutput) public async Task WriteAsync_CanWriteBasicTypes(object input, string expectedOutput)
{ {
@ -115,8 +114,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public void XmlDataContractSerializer_CachesSerializerForType() public void XmlDataContractSerializer_CachesSerializerForType()
{ {
// Arrange // Arrange
@ -135,8 +133,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public void DefaultConstructor_ExpectedWriterSettings_Created() public void DefaultConstructor_ExpectedWriterSettings_Created()
{ {
// Arrange and Act // Arrange and Act
@ -151,8 +148,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task SuppliedWriterSettings_TakeAffect() public async Task SuppliedWriterSettings_TakeAffect()
{ {
// Arrange // Arrange
@ -179,8 +175,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesSimpleTypes() public async Task WriteAsync_WritesSimpleTypes()
{ {
// Arrange // Arrange
@ -204,8 +199,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesComplexTypes() public async Task WriteAsync_WritesComplexTypes()
{ {
// Arrange // Arrange
@ -239,8 +233,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesOnModifiedWriterSettings() public async Task WriteAsync_WritesOnModifiedWriterSettings()
{ {
// Arrange // Arrange
@ -270,8 +263,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesUTF16Output() public async Task WriteAsync_WritesUTF16Output()
{ {
// Arrange // Arrange
@ -300,8 +292,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesIndentedOutput() public async Task WriteAsync_WritesIndentedOutput()
{ {
// Arrange // Arrange
@ -326,8 +317,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_VerifyBodyIsNotClosedAfterOutputIsWritten() public async Task WriteAsync_VerifyBodyIsNotClosedAfterOutputIsWritten()
{ {
// Arrange // Arrange
@ -344,8 +334,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_DoesntFlushOutputStream() public async Task WriteAsync_DoesntFlushOutputStream()
{ {
// Arrange // Arrange
@ -375,8 +364,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[MemberData(nameof(TypesForCanWriteResult))] [MemberData(nameof(TypesForCanWriteResult))]
public void CanWriteResult_ReturnsExpectedOutput(object input, Type declaredType, bool expectedOutput) public void CanWriteResult_ReturnsExpectedOutput(object input, Type declaredType, bool expectedOutput)
{ {
@ -403,8 +391,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[MemberData(nameof(TypesForGetSupportedContentTypes))] [MemberData(nameof(TypesForGetSupportedContentTypes))]
public void GetSupportedContentTypes_ReturnsSupportedTypes(Type type, object expectedOutput) public void GetSupportedContentTypes_ReturnsSupportedTypes(Type type, object expectedOutput)
{ {
@ -428,11 +415,10 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
#if !DNXCORE50 #if !DNXCORE50
// DataContractSerializer in CoreCLR does not throw if the declared type is different from the type being
// serialized.
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 // DataContractSerializer in CoreCLR does not throw if the declared type is different from the type being
[FrameworkSkipCondition(RuntimeFrameworks.Mono)] // serialized. Is this the same issue as aspnet/External#18???
[FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
public async Task WriteAsync_ThrowsWhenNotConfiguredWithKnownTypes() public async Task WriteAsync_ThrowsWhenNotConfiguredWithKnownTypes()
{ {
// Arrange // Arrange
@ -467,8 +453,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
#endif #endif
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_ThrowsWhenNotConfiguredWithPreserveReferences() public async Task WriteAsync_ThrowsWhenNotConfiguredWithPreserveReferences()
{ {
// Arrange // Arrange
@ -485,8 +470,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesWhenConfiguredWithRootName() public async Task WriteAsync_WritesWhenConfiguredWithRootName()
{ {
// Arrange // Arrange
@ -528,8 +512,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesWhenConfiguredWithKnownTypes() public async Task WriteAsync_WritesWhenConfiguredWithKnownTypes()
{ {
// Arrange // Arrange
@ -574,8 +557,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task WriteAsync_WritesWhenConfiguredWithPreserveReferences() public async Task WriteAsync_WritesWhenConfiguredWithPreserveReferences()
{ {
// Arrange // Arrange

6
test/Microsoft.AspNetCore.Mvc.FunctionalTests/ApiExplorerTest.cs
View File

@ -487,8 +487,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ApiExplorer_ResponseContentType_Unset() public async Task ApiExplorer_ResponseContentType_Unset()
{ {
// Arrange & Act // Arrange & Act
@ -553,8 +552,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("Controller", "text/xml", "Microsoft.AspNetCore.Mvc.Formatters.XmlDataContractSerializerOutputFormatter")] [InlineData("Controller", "text/xml", "Microsoft.AspNetCore.Mvc.Formatters.XmlDataContractSerializerOutputFormatter")]
[InlineData("Action", "application/json", "Microsoft.AspNetCore.Mvc.Formatters.JsonOutputFormatter")] [InlineData("Action", "application/json", "Microsoft.AspNetCore.Mvc.Formatters.JsonOutputFormatter")]
public async Task ApiExplorer_ResponseContentType_OverrideOnAction( public async Task ApiExplorer_ResponseContentType_OverrideOnAction(

4
test/Microsoft.AspNetCore.Mvc.FunctionalTests/ConsumesAttributeTests.cs
View File

@ -6,7 +6,6 @@ using System.Net.Http;
using System.Text; using System.Text;
using System.Threading.Tasks; using System.Threading.Tasks;
using BasicWebSite.Models; using BasicWebSite.Models;
using Microsoft.AspNetCore.Mvc.Infrastructure;
using Microsoft.AspNetCore.Testing.xunit; using Microsoft.AspNetCore.Testing.xunit;
using Newtonsoft.Json; using Newtonsoft.Json;
using Xunit; using Xunit;
@ -100,8 +99,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task DerivedClassLevelAttribute_OveridesBaseClassLevel() public async Task DerivedClassLevelAttribute_OveridesBaseClassLevel()
{ {
// Arrange // Arrange

6
test/Microsoft.AspNetCore.Mvc.FunctionalTests/ContentNegotiationTest.cs
View File

@ -107,8 +107,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ProducesAttribute_WithTypeAndContentType_UsesContentType() public async Task ProducesAttribute_WithTypeAndContentType_UsesContentType()
{ {
// Arrange // Arrange
@ -299,8 +298,7 @@ END:VCARD
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task XmlFormatter_SupportedMediaType_DoesNotChangeAcrossRequests() public async Task XmlFormatter_SupportedMediaType_DoesNotChangeAcrossRequests()
{ {
// Arrange // Arrange

3
test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputFormatterTests.cs
View File

@ -22,8 +22,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
public HttpClient Client { get; } public HttpClient Client { get; }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task CheckIfXmlInputFormatterIsBeingCalled() public async Task CheckIfXmlInputFormatterIsBeingCalled()
{ {
// Arrange // Arrange

3
test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputObjectValidationTests.cs
View File

@ -46,8 +46,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task CheckIfObjectIsDeserializedWithoutErrors() public async Task CheckIfObjectIsDeserializedWithoutErrors()
{ {
// Arrange // Arrange

3
test/Microsoft.AspNetCore.Mvc.FunctionalTests/JsonOutputFormatterTests.cs
View File

@ -48,8 +48,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task SerializableErrorIsReturnedInExpectedFormat() public async Task SerializableErrorIsReturnedInExpectedFormat()
{ {
// Arrange // Arrange

9
test/Microsoft.AspNetCore.Mvc.FunctionalTests/RespectBrowserAcceptHeaderTests.cs
View File

@ -41,8 +41,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml,*/*;q=0.2")] [InlineData("application/xml,*/*;q=0.2")]
[InlineData("application/xml,*/*")] [InlineData("application/xml,*/*")]
public async Task AllMediaRangeAcceptHeader_ProducesAttributeIsHonored(string acceptHeader) public async Task AllMediaRangeAcceptHeader_ProducesAttributeIsHonored(string acceptHeader)
@ -69,8 +68,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml,*/*;q=0.2")] [InlineData("application/xml,*/*;q=0.2")]
[InlineData("application/xml,*/*")] [InlineData("application/xml,*/*")]
public async Task AllMediaRangeAcceptHeader_WithContentTypeHeader_ContentTypeIsIgnored(string acceptHeader) public async Task AllMediaRangeAcceptHeader_WithContentTypeHeader_ContentTypeIsIgnored(string acceptHeader)
@ -101,8 +99,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml,application/json;q=0.2")] [InlineData("application/xml,application/json;q=0.2")]
[InlineData("application/xml,application/json")] [InlineData("application/xml,application/json")]
public async Task AllMediaRangeAcceptHeader_WithExactMatch_ReturnsExpectedContent(string acceptHeader) public async Task AllMediaRangeAcceptHeader_WithExactMatch_ReturnsExpectedContent(string acceptHeader)

14
test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs
View File

@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
"application/xml-xmlser" "application/xml-xmlser"
}; };
// Mono issue - https://github.com/aspnet/External/issues/18 // Avoid aspnet/External#18, a DCS issue on Mono.
if (!TestPlatformHelper.IsMono) if (!TestPlatformHelper.IsMono)
{ {
data.Add("application/xml-dcs"); data.Add("application/xml-dcs");
@ -63,10 +63,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18???
// XmlSerializer test is disabled Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
// This is fixed in mono 4.3.0.
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml-xmlser")] [InlineData("application/xml-xmlser")]
[InlineData("application/xml-dcs")] [InlineData("application/xml-dcs")]
public async Task PostedSerializableError_IsBound(string acceptHeader) public async Task PostedSerializableError_IsBound(string acceptHeader)
@ -90,10 +88,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18???
// XmlSerializer test is disabled Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
// This is fixed in mono 4.3.0.
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("application/xml-xmlser")] [InlineData("application/xml-xmlser")]
[InlineData("application/xml-dcs")] [InlineData("application/xml-dcs")]
public async Task IsReturnedInExpectedFormat(string acceptHeader) public async Task IsReturnedInExpectedFormat(string acceptHeader)

24
test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerFormattersWrappingTest.cs
View File

@ -21,8 +21,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
public HttpClient Client { get; } public HttpClient Client { get; }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/ValueTypes")] [InlineData("http://localhost/IEnumerable/ValueTypes")]
[InlineData("http://localhost/IQueryable/ValueTypes")] [InlineData("http://localhost/IQueryable/ValueTypes")]
public async Task CanWrite_ValueTypes(string url) public async Task CanWrite_ValueTypes(string url)
@ -45,8 +44,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/NonWrappedTypes")] [InlineData("http://localhost/IEnumerable/NonWrappedTypes")]
[InlineData("http://localhost/IQueryable/NonWrappedTypes")] [InlineData("http://localhost/IQueryable/NonWrappedTypes")]
public async Task CanWrite_NonWrappedTypes(string url) public async Task CanWrite_NonWrappedTypes(string url)
@ -69,8 +67,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/NonWrappedTypes_Empty")] [InlineData("http://localhost/IEnumerable/NonWrappedTypes_Empty")]
[InlineData("http://localhost/IQueryable/NonWrappedTypes_Empty")] [InlineData("http://localhost/IQueryable/NonWrappedTypes_Empty")]
public async Task CanWrite_NonWrappedTypes_Empty(string url) public async Task CanWrite_NonWrappedTypes_Empty(string url)
@ -92,8 +89,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/NonWrappedTypes_NullInstance")] [InlineData("http://localhost/IEnumerable/NonWrappedTypes_NullInstance")]
[InlineData("http://localhost/IQueryable/NonWrappedTypes_NullInstance")] [InlineData("http://localhost/IQueryable/NonWrappedTypes_NullInstance")]
public async Task CanWrite_NonWrappedTypes_NullInstance(string url) public async Task CanWrite_NonWrappedTypes_NullInstance(string url)
@ -115,8 +111,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/WrappedTypes")] [InlineData("http://localhost/IEnumerable/WrappedTypes")]
[InlineData("http://localhost/IQueryable/WrappedTypes")] [InlineData("http://localhost/IQueryable/WrappedTypes")]
public async Task CanWrite_WrappedTypes(string url) public async Task CanWrite_WrappedTypes(string url)
@ -140,8 +135,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/WrappedTypes_Empty")] [InlineData("http://localhost/IEnumerable/WrappedTypes_Empty")]
[InlineData("http://localhost/IQueryable/WrappedTypes_Empty")] [InlineData("http://localhost/IQueryable/WrappedTypes_Empty")]
public async Task CanWrite_WrappedTypes_Empty(string url) public async Task CanWrite_WrappedTypes_Empty(string url)
@ -163,8 +157,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalTheory] [ConditionalTheory]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
[InlineData("http://localhost/IEnumerable/WrappedTypes_NullInstance")] [InlineData("http://localhost/IEnumerable/WrappedTypes_NullInstance")]
[InlineData("http://localhost/IQueryable/WrappedTypes_NullInstance")] [InlineData("http://localhost/IQueryable/WrappedTypes_NullInstance")]
public async Task CanWrite_WrappedTypes_NullInstance(string url) public async Task CanWrite_WrappedTypes_NullInstance(string url)
@ -186,8 +179,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task CanWrite_IEnumerableOf_SerializableErrors() public async Task CanWrite_IEnumerableOf_SerializableErrors()
{ {
// Arrange // Arrange

9
test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerInputFormatterTest.cs
View File

@ -35,8 +35,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
public HttpClient Client { get; } public HttpClient Client { get; }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task ThrowsOnInvalidInput_AndAddsToModelState() public async Task ThrowsOnInvalidInput_AndAddsToModelState()
{ {
// Arrange // Arrange
@ -57,8 +56,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task RequiredDataIsProvided_AndModelIsBound_NoValidationErrors() public async Task RequiredDataIsProvided_AndModelIsBound_NoValidationErrors()
{ {
// Arrange // Arrange
@ -87,8 +85,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
// Verifies that the model state has errors related to body model validation. // Verifies that the model state has errors related to body model validation.
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mon, SkipReason = "aspnet/External#18, DCS issue on Mono"o)]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task DataMissingForRefereneceTypeProperties_AndModelIsBound_AndHasMixedValidationErrors() public async Task DataMissingForRefereneceTypeProperties_AndModelIsBound_AndHasMixedValidationErrors()
{ {
// Arrange // Arrange

3
test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlOutputFormatterTests.cs
View File

@ -64,8 +64,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
} }
[ConditionalFact] [ConditionalFact]
// Mono issue - https://github.com/aspnet/External/issues/18 [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")]
[FrameworkSkipCondition(RuntimeFrameworks.Mono)]
public async Task XmlSerializerFailsAndDataContractSerializerIsCalled() public async Task XmlSerializerFailsAndDataContractSerializerIsCalled()
{ {
// Arrange // Arrange