diff --git a/build/VSIX.targets b/build/VSIX.targets index de064bc9f9..5995deeabd 100644 --- a/build/VSIX.targets +++ b/build/VSIX.targets @@ -102,6 +102,8 @@ /p:TargetVSIXContainer=$(VSIXOutputPath); /p:SymbolsPublishDir=$(BuildDir); /p:Configuration=$(Configuration); + /p:FeatureBranchVersionSuffix=$(FeatureBranchVersionSuffix); + /p:BuildNumber=$(BuildNumber); /p:LangVersion=7.1" /> diff --git a/build/dependencies.props b/build/dependencies.props index c340259e4a..ccf68131d3 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -47,16 +47,16 @@ 4.3.0 4.6.0-preview1-26508-04 9.0.1 - 2.8.0 - 2.8.0 - 2.8.0 - 2.8.0 - 2.8.0 - 2.8.0-beta2-62721-09 - 2.8.0 - 2.8.0 - 2.8.0 - 2.8.0-beta2-62721-09 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 + 2.9.0-beta4-62911-02 0.8.0 2.3.1 2.4.0-beta.1.build3945 diff --git a/korebuild.json b/korebuild.json index a45ff3a441..6a6da7bd51 100644 --- a/korebuild.json +++ b/korebuild.json @@ -5,7 +5,7 @@ "visualstudio": { "required": false, "includePrerelease": true, - "versionRange": "[15.0.26730.03, 15.9)", + "versionRange": "[15.0.26730.03, 15.8)", "requiredWorkloads": [ "Microsoft.VisualStudio.Component.VSSDK" ] diff --git a/src/Microsoft.VisualStudio.Editor.Razor/RazorDirectiveCompletionProvider.cs b/src/Microsoft.VisualStudio.Editor.Razor/RazorDirectiveCompletionProvider.cs index c55dcc3776..56768829d1 100644 --- a/src/Microsoft.VisualStudio.Editor.Razor/RazorDirectiveCompletionProvider.cs +++ b/src/Microsoft.VisualStudio.Editor.Razor/RazorDirectiveCompletionProvider.cs @@ -14,6 +14,7 @@ using Microsoft.AspNetCore.Razor.Language.Legacy; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Completion; using Microsoft.CodeAnalysis.Razor; +using Microsoft.CodeAnalysis.Tags; using Microsoft.CodeAnalysis.Text; using Microsoft.VisualStudio.Text; using Microsoft.VisualStudio.Text.Projection; @@ -139,7 +140,7 @@ namespace Microsoft.VisualStudio.Editor.Razor // This groups all Razor directives together sortText: "_RazorDirective_", rules: CompletionItemRules.Create(formatOnCommit: false), - tags: ImmutableArray.Create(CompletionTags.Intrinsic), + tags: ImmutableArray.Create(WellKnownTags.Intrinsic), properties: propertyDictionary.ToImmutableDictionary()); completionItems.Add(completionItem); } diff --git a/src/Microsoft.VisualStudio.LanguageServices.Razor/OOPTagHelperResolverFactory.cs b/src/Microsoft.VisualStudio.LanguageServices.Razor/OOPTagHelperResolverFactory.cs index 37c7f48f99..0d588c6cc8 100644 --- a/src/Microsoft.VisualStudio.LanguageServices.Razor/OOPTagHelperResolverFactory.cs +++ b/src/Microsoft.VisualStudio.LanguageServices.Razor/OOPTagHelperResolverFactory.cs @@ -16,36 +16,10 @@ namespace Microsoft.VisualStudio.LanguageServices.Razor { public ILanguageService CreateLanguageService(HostLanguageServices languageServices) { - if (!IsRemoteClientWorking()) - { - return new DefaultTagHelperResolver(); - } - return new OOPTagHelperResolver( languageServices.WorkspaceServices.GetRequiredService(), languageServices.WorkspaceServices.GetRequiredService(), languageServices.WorkspaceServices.Workspace); } - - [MethodImpl(MethodImplOptions.NoInlining)] - private bool IsRemoteClientWorking() - { - try - { - LoadType(); - return true; - } - catch (Exception) - { - return false; - } - } - - [MethodImpl(MethodImplOptions.NoInlining)] - private void LoadType() - { - // During 15.8 Roslyn renamed our OOP client from RazorLangaugeServiceClient to RazorLanguageServiceClient. - GC.KeepAlive(typeof(RazorLangaugeServiceClient)); - } } } \ No newline at end of file diff --git a/test/Microsoft.VisualStudio.Editor.Razor.Test/RazorDirectiveCompletionProviderTest.cs b/test/Microsoft.VisualStudio.Editor.Razor.Test/RazorDirectiveCompletionProviderTest.cs index 0b8ccafb91..1b76f772b6 100644 --- a/test/Microsoft.VisualStudio.Editor.Razor.Test/RazorDirectiveCompletionProviderTest.cs +++ b/test/Microsoft.VisualStudio.Editor.Razor.Test/RazorDirectiveCompletionProviderTest.cs @@ -14,6 +14,7 @@ using Microsoft.AspNetCore.Razor.Language.Legacy; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Completion; using Microsoft.CodeAnalysis.Options; +using Microsoft.CodeAnalysis.Tags; using Microsoft.CodeAnalysis.Text; using Microsoft.VisualStudio.Text; using Moq; @@ -289,7 +290,7 @@ namespace Microsoft.VisualStudio.Editor.Razor Assert.Equal("_RazorDirective_", item.SortText); Assert.False(item.Rules.FormatOnCommit); var tag = Assert.Single(item.Tags); - Assert.Equal(CompletionTags.Intrinsic, tag); + Assert.Equal(WellKnownTags.Intrinsic, tag); } private static Lazy CreateCodeDocumentProvider(string text, IEnumerable directives)