Cleanup after refactoring

This commit is contained in:
Yishai Galatzer 2014-03-13 18:15:24 -07:00
parent c4481cf390
commit 5849ba8544
3 changed files with 8 additions and 9 deletions

View File

@ -22,9 +22,6 @@ namespace Microsoft.AspNet.Mvc.Filters
{
if (context.ActionDescriptor.FilterDescriptors != null)
{
// make a copy of the list, TODO: Make the actiondescriptor immutable
var filterDescriptors = context.ActionDescriptor.FilterDescriptors.ToArray();
foreach (var item in context.Items)
{
ProvideFilter(context, item);
@ -39,14 +36,14 @@ namespace Microsoft.AspNet.Mvc.Filters
public virtual void ProvideFilter(FilterProviderContext context, FilterProviderContext.FilterItem filterItem)
{
var filter = filterItem.Filter;
if (filter != null)
if (filterItem.Filter != null)
{
return;
}
var serviceFilterSignature = filterItem.Descriptor.Filter as IServiceFilter;
var filter = filterItem.Descriptor.Filter;
var serviceFilterSignature = filter as IServiceFilter;
if (serviceFilterSignature != null)
{
var serviceFilter = ServiceProvider.GetService(serviceFilterSignature.ServiceType) as IFilter;
@ -60,7 +57,7 @@ namespace Microsoft.AspNet.Mvc.Filters
}
else
{
var typeFilterSignature = filterItem.Descriptor.Filter as ITypeFilter;
var typeFilterSignature = filter as ITypeFilter;
if (typeFilterSignature != null)
{
if (typeFilterSignature.ImplementationType == null)

View File

@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Diagnostics;
namespace Microsoft.AspNet.Mvc
{
@ -16,6 +17,7 @@ namespace Microsoft.AspNet.Mvc
// Result
public List<FilterItem> Items { get; set; }
[DebuggerDisplay("FilterItem: {Filter}")]
public class FilterItem
{
public FilterItem([NotNull] FilterDescriptor descriptor)

View File

@ -167,7 +167,7 @@ namespace Microsoft.AspNet.Mvc
foreach (var filter in context.Items)
{
PlaceFilter(filter);
PlaceFilter(filter.Filter);
}
}