huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

column attribute for <textarea> is incorrect (#5049) 

- Modify tagBuilder.MergeAttribute key to cols
This commit is contained in:
ivano scifoni 2016-07-20 18:22:39 +02:00 committed by Doug Bunting
parent 35cc5b6e83
commit 581a5ea573
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewFeatures/DefaultHtmlGenerator.cs
View File

@ -658,7 +658,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures
if (columns > 0) if (columns > 0)
{ {
tagBuilder.MergeAttribute("columns", columns.ToString(CultureInfo.InvariantCulture), true); tagBuilder.MergeAttribute("cols", columns.ToString(CultureInfo.InvariantCulture), true);
} }
tagBuilder.MergeAttribute("name", fullName, true); tagBuilder.MergeAttribute("name", fullName, true);

4
test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperTextAreaExtensionsTest.cs
View File

@ -123,7 +123,7 @@ namespace Microsoft.AspNetCore.Mvc.Core
// Assert // Assert
Assert.Equal( Assert.Equal(
"<textarea attr=\"HtmlEncode[[value]]\" columns=\"HtmlEncode[[2]]\" id=\"HtmlEncode[[Property1]]\" " + "<textarea attr=\"HtmlEncode[[value]]\" cols=\"HtmlEncode[[2]]\" id=\"HtmlEncode[[Property1]]\" " +
"name=\"HtmlEncode[[Property1]]\" rows=\"HtmlEncode[[1]]\">" + Environment.NewLine + "name=\"HtmlEncode[[Property1]]\" rows=\"HtmlEncode[[1]]\">" + Environment.NewLine +
"HtmlEncode[[myvalue]]</textarea>", "HtmlEncode[[myvalue]]</textarea>",
HtmlContentUtilities.HtmlContentToString(textAreaResult)); HtmlContentUtilities.HtmlContentToString(textAreaResult));
@ -140,7 +140,7 @@ namespace Microsoft.AspNetCore.Mvc.Core
// Assert // Assert
Assert.Equal( Assert.Equal(
"<textarea attr=\"HtmlEncode[[value]]\" columns=\"HtmlEncode[[2]]\" id=\"HtmlEncode[[Property1]]\" " + "<textarea attr=\"HtmlEncode[[value]]\" cols=\"HtmlEncode[[2]]\" id=\"HtmlEncode[[Property1]]\" " +
"name=\"HtmlEncode[[Property1]]\" rows=\"HtmlEncode[[1]]\">" + Environment.NewLine + "name=\"HtmlEncode[[Property1]]\" rows=\"HtmlEncode[[1]]\">" + Environment.NewLine +
"</textarea>", "</textarea>",
HtmlContentUtilities.HtmlContentToString(textAreaForResult)); HtmlContentUtilities.HtmlContentToString(textAreaForResult));