From 9d594e41c53365358e898ee3574fd81a9fa23dfb Mon Sep 17 00:00:00 2001 From: Pranav K Date: Fri, 2 Aug 2019 11:26:00 -0700 Subject: [PATCH 1/3] Make launchSettings.json a content item that does not get copied to build or publish directory Fixes https://github.com/aspnet/AspNetCore/issues/12841 \n\nCommit migrated from https://github.com/dotnet/aspnetcore-tooling/commit/34628d30663dacd90c09f15017f173061cbd1d3e --- .../Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props | 7 +++---- .../test/IntegrationTests/BuildIntrospectionTest.cs | 12 ++++++++++++ .../test/testassets/RazorTest.Introspection.targets | 4 ++++ 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props b/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props index f468e9caa7..0a9aed20e5 100644 --- a/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props +++ b/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props @@ -23,7 +23,6 @@ Copyright (c) .NET Foundation. All rights reserved. $(DefaultItemExcludes);**\jspm_packages\**;jspm_packages\** $(DefaultItemExcludes);**\bower_components\**;bower_components\** $(DefaultWebContentItemExcludes);wwwroot\** - $(DefaultWebContentItemExcludes);**\launchSettings.json @@ -32,14 +31,14 @@ Copyright (c) .NET Foundation. All rights reserved. - - + + - + <_ContentIncludedByDefault Include="@(Content)" /> diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs index bdc08000c1..87e4fb3d2a 100644 --- a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs +++ b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs @@ -194,5 +194,17 @@ namespace Microsoft.AspNetCore.Razor.Design.IntegrationTests Assert.BuildPassed(result); Assert.BuildOutputContainsLine(result, "UpToDateReloadFileTypes: ;.cs;.razor;.resx;"); } + + [Fact] + [InitializeTestProject("SimpleMvc")] + public async Task IntrospectJsonContentFiles() + { + var result = await DotnetMSBuild("_IntrospectContentItems"); + + Assert.BuildPassed(result); + Assert.BuildOutputContainsLine(result, "Content: Properties\\launchSettings.json CopyToOutputDirectory=Never CopyToPublishDirectory=Never ExcludeFromSingleFile=true"); + Assert.BuildOutputContainsLine(result, "Content: appsettings.json CopyToOutputDirectory=PreserveNewest CopyToPublishDirectory=PreserveNewest ExcludeFromSingleFile=true"); + Assert.BuildOutputContainsLine(result, "Content: appsettings.Development.json CopyToOutputDirectory=PreserveNewest CopyToPublishDirectory=PreserveNewest ExcludeFromSingleFile=true"); + } } } diff --git a/src/Razor/test/testassets/RazorTest.Introspection.targets b/src/Razor/test/testassets/RazorTest.Introspection.targets index 516abc8388..c3fca78317 100644 --- a/src/Razor/test/testassets/RazorTest.Introspection.targets +++ b/src/Razor/test/testassets/RazorTest.Introspection.targets @@ -42,4 +42,8 @@ + + + + From a202e6cfa61c5b1720b12e63426f78f5e27d2e89 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Sat, 3 Aug 2019 16:55:31 -0700 Subject: [PATCH 2/3] Update \n\nCommit migrated from https://github.com/dotnet/aspnetcore-tooling/commit/98d9bda3a2a65f4944be1ef5f202cee6c26e413f --- .../src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props | 4 ++-- .../test/IntegrationTests/BuildIntrospectionTest.cs | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props b/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props index 0a9aed20e5..f54b74ebf4 100644 --- a/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props +++ b/src/Razor/Microsoft.NET.Sdk.Razor/src/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props @@ -31,8 +31,8 @@ Copyright (c) .NET Foundation. All rights reserved. - - + + diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs index 87e4fb3d2a..2c86bf957c 100644 --- a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs +++ b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/BuildIntrospectionTest.cs @@ -202,7 +202,8 @@ namespace Microsoft.AspNetCore.Razor.Design.IntegrationTests var result = await DotnetMSBuild("_IntrospectContentItems"); Assert.BuildPassed(result); - Assert.BuildOutputContainsLine(result, "Content: Properties\\launchSettings.json CopyToOutputDirectory=Never CopyToPublishDirectory=Never ExcludeFromSingleFile=true"); + var launchSettingsPath = Path.Combine("Properties", "launchSettings.json"); + Assert.BuildOutputContainsLine(result, $"Content: {launchSettingsPath} CopyToOutputDirectory=PreserveNewest CopyToPublishDirectory=Never ExcludeFromSingleFile=true"); Assert.BuildOutputContainsLine(result, "Content: appsettings.json CopyToOutputDirectory=PreserveNewest CopyToPublishDirectory=PreserveNewest ExcludeFromSingleFile=true"); Assert.BuildOutputContainsLine(result, "Content: appsettings.Development.json CopyToOutputDirectory=PreserveNewest CopyToPublishDirectory=PreserveNewest ExcludeFromSingleFile=true"); } From f31e951f5dc493f72f7d2c88019b94393591c564 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Sat, 3 Aug 2019 17:29:13 -0700 Subject: [PATCH 3/3] Fixup test \n\nCommit migrated from https://github.com/dotnet/aspnetcore-tooling/commit/5eb86992f4d0d545c8965cf9305ae5231a99605e --- .../test/IntegrationTests/PublishIntegrationTest.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/PublishIntegrationTest.cs b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/PublishIntegrationTest.cs index cf5387538e..cebd5de38c 100644 --- a/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/PublishIntegrationTest.cs +++ b/src/Razor/Microsoft.NET.Sdk.Razor/test/IntegrationTests/PublishIntegrationTest.cs @@ -51,7 +51,6 @@ namespace Microsoft.AspNetCore.Razor.Design.IntegrationTests Assert.FileExists(result, OutputPath, "SimpleMvc.Views.pdb"); Assert.FileExists(result, OutputPath, "appsettings.json"); Assert.FileExists(result, OutputPath, "appsettings.Development.json"); - Assert.FileDoesNotExist(result, OutputPath, Path.Combine("Properties", "launchSettings.json")); Assert.FileExists(result, PublishOutputPath, "SimpleMvc.dll"); Assert.FileExists(result, PublishOutputPath, "SimpleMvc.pdb");