diff --git a/test/EF.Test/SqlStoreTestBase.cs b/test/EF.Test/SqlStoreTestBase.cs index 1a2ca28f41..1cc9204267 100644 --- a/test/EF.Test/SqlStoreTestBase.cs +++ b/test/EF.Test/SqlStoreTestBase.cs @@ -33,7 +33,7 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test protected virtual void SetupAddIdentity(IServiceCollection services) { - services.AddIdentity(options => + services.AddIdentityCore(options => { options.Password.RequireDigit = false; options.Password.RequireLowercase = false; @@ -41,8 +41,11 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test options.Password.RequireUppercase = false; options.User.AllowedUserNameCharacters = null; }) + .AddRoles() .AddDefaultTokenProviders() .AddEntityFrameworkStores(); + + services.AddAuthentication(IdentityConstants.ApplicationScheme).AddIdentityCookies(); } protected override void SetupIdentityServices(IServiceCollection services, object context) diff --git a/test/EF.Test/UserStoreGuidKeyTest.cs b/test/EF.Test/UserStoreGuidKeyTest.cs index de8785fdc0..107610ac66 100644 --- a/test/EF.Test/UserStoreGuidKeyTest.cs +++ b/test/EF.Test/UserStoreGuidKeyTest.cs @@ -2,6 +2,7 @@ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; +using Microsoft.EntityFrameworkCore; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -56,17 +57,34 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test public void AddEntityFrameworkStoresCanInferKey() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw var builder = services.AddIdentity().AddEntityFrameworkStores(); + + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>()); + Assert.NotNull(sp.GetRequiredService>()); + } } [Fact] public void AddEntityFrameworkStoresCanInferKeyWithGenericBase() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw - var builder = services.AddIdentity, IdentityRole>().AddEntityFrameworkStores(); - } + var builder = services.AddIdentityCore>().AddRoles>().AddEntityFrameworkStores(); + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>>()); + Assert.NotNull(sp.GetRequiredService>>()); + } + } } } \ No newline at end of file diff --git a/test/EF.Test/UserStoreIntKeyTest.cs b/test/EF.Test/UserStoreIntKeyTest.cs index 6a32ef04a5..7cc60f3fe7 100644 --- a/test/EF.Test/UserStoreIntKeyTest.cs +++ b/test/EF.Test/UserStoreIntKeyTest.cs @@ -2,6 +2,7 @@ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; +using Microsoft.EntityFrameworkCore; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -34,16 +35,34 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test public void AddEntityFrameworkStoresCanInferKey() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw var builder = services.AddIdentity().AddEntityFrameworkStores(); + + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>()); + Assert.NotNull(sp.GetRequiredService>()); + } } [Fact] public void AddEntityFrameworkStoresCanInferKeyWithGenericBase() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw - var builder = services.AddIdentity, IdentityRole>().AddEntityFrameworkStores(); + var builder = services.AddIdentityCore>().AddRoles>().AddEntityFrameworkStores(); + + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>>()); + Assert.NotNull(sp.GetRequiredService>>()); + } } } diff --git a/test/EF.Test/UserStoreStringKeyTest.cs b/test/EF.Test/UserStoreStringKeyTest.cs index 90e04e05a2..de3f807e36 100644 --- a/test/EF.Test/UserStoreStringKeyTest.cs +++ b/test/EF.Test/UserStoreStringKeyTest.cs @@ -2,6 +2,7 @@ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; +using Microsoft.EntityFrameworkCore; using Microsoft.Extensions.DependencyInjection; using Xunit; @@ -35,16 +36,34 @@ namespace Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test public void AddEntityFrameworkStoresCanInferKey() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw var builder = services.AddIdentity().AddEntityFrameworkStores(); + + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>()); + Assert.NotNull(sp.GetRequiredService>()); + } } [Fact] public void AddEntityFrameworkStoresCanInferKeyWithGenericBase() { var services = new ServiceCollection(); + services.AddLogging() + .AddSingleton(new TestDbContext(new DbContextOptionsBuilder().Options)); // This used to throw - var builder = services.AddIdentity, IdentityRole>().AddEntityFrameworkStores(); + var builder = services.AddIdentityCore>().AddRoles>().AddEntityFrameworkStores(); + + var sp = services.BuildServiceProvider(); + using (var csope = sp.CreateScope()) + { + Assert.NotNull(sp.GetRequiredService>>()); + Assert.NotNull(sp.GetRequiredService>>()); + } } } } \ No newline at end of file