From 5459107832906891d1d55e0a91fd261956014195 Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Fri, 21 Sep 2018 13:29:40 -0700 Subject: [PATCH] Fix #1298 (#1309) * Fix #1298 This change lifts our Razor dependencies to 2.1.1. This is needed because by default ASP.NET Core projects will depend on 2.1.1 - which results in a conflict trying to use the Blazor compiler. The Blazor compiler will load the 2.1.0 msbuild tasks, which then break loading the 2.1.1 tasks. Since this is happening in the MSBuild process, we can't really write any code to sort this out. We have to make sure the versions match. In general the guidance for ASP.NET Core is that projects will **compile against** 2.1.1 so this won't be a problem in the future unless a user project specifically lifts ASP.NET Core to a higher version. If that's the case they will also have to live `Microsoft.AspNetCore.Razor.Design` to match. --- build/dependencies.props | 6 ++++-- .../HostedInAspNet.Server.csproj | 3 ++- samples/MonoSanity/MonoSanity.csproj | 3 ++- .../ServerSideBlazor.Server.csproj | 7 ++++--- .../Microsoft.AspNetCore.Blazor.Build.csproj | 4 ++-- .../ReferenceFromSource.props | 2 +- .../.template.config.src/template.json | 7 ------- .../BlazorHosted-CSharp.Client.csproj | 3 +++ .../BlazorHosted-CSharp.Server.csproj | 2 +- .../.template.config.src/template.json | 7 ------- .../BlazorLibrary-CSharp.csproj | 4 ++++ .../.template.config.src/template.json | 7 ------- .../BlazorServerSide-CSharp.App.csproj | 4 ++++ .../BlazorServerSide-CSharp.Server.csproj | 3 ++- .../.template.config.src/template.json | 7 ------- .../BlazorStandalone-CSharp.csproj | 4 ++++ .../Microsoft.AspNetCore.Blazor.E2ETest.csproj | 13 ++++++++++--- test/testapps/TestServer/TestServer.csproj | 3 ++- 18 files changed, 45 insertions(+), 44 deletions(-) diff --git a/build/dependencies.props b/build/dependencies.props index d14568ba6e..2934930cc7 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -4,12 +4,14 @@ 2.1.0 - 2.1.2 + 2.1.3 0.10.13 2.1.3-rtm-15811 2.2.0-preview1-34576 + 2.1.2 + 2.1.2 2.0.9 - 2.1.2 + 2.1.3 1.0.0 0.6.0-preview1-20180807.1 2.1.0 diff --git a/samples/HostedInAspNet.Server/HostedInAspNet.Server.csproj b/samples/HostedInAspNet.Server/HostedInAspNet.Server.csproj index 7e53192464..e08f1f9ce3 100644 --- a/samples/HostedInAspNet.Server/HostedInAspNet.Server.csproj +++ b/samples/HostedInAspNet.Server/HostedInAspNet.Server.csproj @@ -5,7 +5,8 @@ - + + diff --git a/samples/MonoSanity/MonoSanity.csproj b/samples/MonoSanity/MonoSanity.csproj index 30c57ab28e..da8628f7e6 100644 --- a/samples/MonoSanity/MonoSanity.csproj +++ b/samples/MonoSanity/MonoSanity.csproj @@ -5,7 +5,8 @@ - + + diff --git a/samples/ServerSideBlazor.Server/ServerSideBlazor.Server.csproj b/samples/ServerSideBlazor.Server/ServerSideBlazor.Server.csproj index 698baa0ec6..006fed48d6 100644 --- a/samples/ServerSideBlazor.Server/ServerSideBlazor.Server.csproj +++ b/samples/ServerSideBlazor.Server/ServerSideBlazor.Server.csproj @@ -5,12 +5,13 @@ - + + - - + + diff --git a/src/Microsoft.AspNetCore.Blazor.Build/Microsoft.AspNetCore.Blazor.Build.csproj b/src/Microsoft.AspNetCore.Blazor.Build/Microsoft.AspNetCore.Blazor.Build.csproj index 53cf4d6f60..428dc7f545 100644 --- a/src/Microsoft.AspNetCore.Blazor.Build/Microsoft.AspNetCore.Blazor.Build.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Build/Microsoft.AspNetCore.Blazor.Build.csproj @@ -21,7 +21,7 @@ version=$(PackageVersion); publishDir=$([MSBuild]::NormalizeDirectory($(IntermediatePackDir))); - razorversion=$(RazorPackageVersion); + razorversion=$(MicrosoftAspNetCoreRazorDesignPackageVersion); <_TargetFramework Include="$(TargetFrameworks)" /> @@ -44,7 +44,7 @@ - + diff --git a/src/Microsoft.AspNetCore.Blazor.Build/ReferenceFromSource.props b/src/Microsoft.AspNetCore.Blazor.Build/ReferenceFromSource.props index c56ef232e7..64d7bbe5f6 100644 --- a/src/Microsoft.AspNetCore.Blazor.Build/ReferenceFromSource.props +++ b/src/Microsoft.AspNetCore.Blazor.Build/ReferenceFromSource.props @@ -23,7 +23,7 @@ - + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/.template.config.src/template.json b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/.template.config.src/template.json index 7fb5a0aad5..b42a1b53d3 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/.template.config.src/template.json +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/.template.config.src/template.json @@ -95,13 +95,6 @@ "replaces": "$(TemplateBlazorPackageVersion)", "defaultValue": "${TemplateBlazorVersion}" }, - "AspNetCorePackageVersionSymbol": { - "type": "parameter", - "datatype": "string", - "description": "Intended for internal use only.", - "replaces": " Version=\"$(AspNetCorePackageVersion)\"", - "defaultValue": "" - }, "skipRestore": { "type": "parameter", "datatype": "bool", diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Client/BlazorHosted-CSharp.Client.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Client/BlazorHosted-CSharp.Client.csproj index 2df8de15ec..015fe51d57 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Client/BlazorHosted-CSharp.Client.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Client/BlazorHosted-CSharp.Client.csproj @@ -12,6 +12,9 @@ + + + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Server/BlazorHosted-CSharp.Server.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Server/BlazorHosted-CSharp.Server.csproj index 1637714cc8..b6b082ed04 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Server/BlazorHosted-CSharp.Server.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorHosted-CSharp/BlazorHosted-CSharp.Server/BlazorHosted-CSharp.Server.csproj @@ -9,7 +9,7 @@ - + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/.template.config.src/template.json b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/.template.config.src/template.json index 9ee4e3f4bd..ad7b6acba3 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/.template.config.src/template.json +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/.template.config.src/template.json @@ -56,13 +56,6 @@ "replaces": "$(TemplateBlazorPackageVersion)", "defaultValue": "${TemplateBlazorVersion}" }, - "AspNetCorePackageVersionSymbol": { - "type": "parameter", - "datatype": "string", - "description": "Intended for internal use only.", - "replaces": " Version=\"$(AspNetCorePackageVersion)\"", - "defaultValue": "" - }, "skipRestore": { "type": "parameter", "datatype": "bool", diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/BlazorLibrary-CSharp.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/BlazorLibrary-CSharp.csproj index a7798b1948..a11728217f 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/BlazorLibrary-CSharp.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorLibrary-CSharp/BlazorLibrary-CSharp.csproj @@ -21,6 +21,10 @@ + + + + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/.template.config.src/template.json b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/.template.config.src/template.json index 9fd3d4c95a..72a9e92235 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/.template.config.src/template.json +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/.template.config.src/template.json @@ -87,13 +87,6 @@ "replaces": "$(TemplateBlazorPackageVersion)", "defaultValue": "${TemplateBlazorVersion}" }, - "AspNetCorePackageVersionSymbol": { - "type": "parameter", - "datatype": "string", - "description": "Intended for internal use only.", - "replaces": " Version=\"$(AspNetCorePackageVersion)\"", - "defaultValue": "" - }, "skipRestore": { "type": "parameter", "datatype": "bool", diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.App/BlazorServerSide-CSharp.App.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.App/BlazorServerSide-CSharp.App.csproj index 038d4bf3b0..34f9966033 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.App/BlazorServerSide-CSharp.App.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.App/BlazorServerSide-CSharp.App.csproj @@ -15,6 +15,10 @@ + + + + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.Server/BlazorServerSide-CSharp.Server.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.Server/BlazorServerSide-CSharp.Server.csproj index fb0f4c16be..9d29a0faa0 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.Server/BlazorServerSide-CSharp.Server.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorServerSide-CSharp/BlazorServerSide-CSharp.Server/BlazorServerSide-CSharp.Server.csproj @@ -9,8 +9,9 @@ - + + diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/.template.config.src/template.json b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/.template.config.src/template.json index bf588a9187..9cecdcef83 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/.template.config.src/template.json +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/.template.config.src/template.json @@ -56,13 +56,6 @@ "replaces": "$(TemplateBlazorPackageVersion)", "defaultValue": "${TemplateBlazorVersion}" }, - "AspNetCorePackageVersionSymbol": { - "type": "parameter", - "datatype": "string", - "description": "Intended for internal use only.", - "replaces": " Version=\"$(AspNetCorePackageVersion)\"", - "defaultValue": "" - }, "skipRestore": { "type": "parameter", "datatype": "bool", diff --git a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/BlazorStandalone-CSharp.csproj b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/BlazorStandalone-CSharp.csproj index 1b34c39c12..38a091e9cc 100644 --- a/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/BlazorStandalone-CSharp.csproj +++ b/src/Microsoft.AspNetCore.Blazor.Templates/content/BlazorStandalone-CSharp/BlazorStandalone-CSharp.csproj @@ -13,6 +13,10 @@ + + + + diff --git a/test/Microsoft.AspNetCore.Blazor.E2ETest/Microsoft.AspNetCore.Blazor.E2ETest.csproj b/test/Microsoft.AspNetCore.Blazor.E2ETest/Microsoft.AspNetCore.Blazor.E2ETest.csproj index cb7ce8362f..c6fc1e1c89 100644 --- a/test/Microsoft.AspNetCore.Blazor.E2ETest/Microsoft.AspNetCore.Blazor.E2ETest.csproj +++ b/test/Microsoft.AspNetCore.Blazor.E2ETest/Microsoft.AspNetCore.Blazor.E2ETest.csproj @@ -9,9 +9,16 @@ - - - + + + + diff --git a/test/testapps/TestServer/TestServer.csproj b/test/testapps/TestServer/TestServer.csproj index d89eb92294..fe0b04f262 100644 --- a/test/testapps/TestServer/TestServer.csproj +++ b/test/testapps/TestServer/TestServer.csproj @@ -5,7 +5,8 @@ - + +