This commit is contained in:
Ajay Bhargav Baaskaran 2015-01-07 17:53:35 -08:00
parent 6df288bce7
commit 52a984c52d
6 changed files with 18 additions and 19 deletions

View File

@ -42,7 +42,7 @@ namespace Microsoft.AspNet.Mvc
public async Task<AntiForgeryToken> GetFormTokenAsync(HttpContext httpContext) public async Task<AntiForgeryToken> GetFormTokenAsync(HttpContext httpContext)
{ {
var form = await httpContext.Request.GetFormAsync(); var form = await httpContext.Request.ReadFormAsync();
var value = form[_config.FormFieldName]; var value = form[_config.FormFieldName];
if (string.IsNullOrEmpty(value)) if (string.IsNullOrEmpty(value))
{ {

View File

@ -20,7 +20,7 @@ namespace Microsoft.AspNet.Mvc.ModelBinding
{ {
var culture = GetCultureInfo(request); var culture = GetCultureInfo(request);
return new ReadableStringCollectionValueProvider<IFormDataValueProviderMetadata>( return new ReadableStringCollectionValueProvider<IFormDataValueProviderMetadata>(
() => request.GetFormAsync(), async () => await request.ReadFormAsync(),
culture); culture);
} }

View File

@ -164,13 +164,12 @@ namespace Microsoft.AspNet.Mvc.Core.Test
// Arrange // Arrange
var mockHttpContext = new Mock<HttpContext>(); var mockHttpContext = new Mock<HttpContext>();
var requestContext = new Mock<HttpRequest>(); var requestContext = new Mock<HttpRequest>();
IReadableStringCollection formsCollection = var formCollection = new Mock<IFormCollection>();
new MockCookieCollection(new Dictionary<string, string>() { { "form-field-name", string.Empty } }); formCollection.Setup(f => f["form-field-name"]).Returns(string.Empty);
requestContext.Setup(o => o.GetFormAsync(CancellationToken.None)) requestContext.Setup(o => o.ReadFormAsync(CancellationToken.None))
.Returns(Task.FromResult(formsCollection)); .Returns(Task.FromResult(formCollection.Object));
mockHttpContext.Setup(o => o.Request) mockHttpContext.Setup(o => o.Request)
.Returns(requestContext.Object); .Returns(requestContext.Object);
var config = new AntiForgeryOptions() var config = new AntiForgeryOptions()
{ {
FormFieldName = "form-field-name" FormFieldName = "form-field-name"
@ -191,12 +190,12 @@ namespace Microsoft.AspNet.Mvc.Core.Test
public async Task GetFormToken_FormFieldIsInvalid_PropagatesException() public async Task GetFormToken_FormFieldIsInvalid_PropagatesException()
{ {
// Arrange // Arrange
IReadableStringCollection formsCollection = var formCollection = new Mock<IFormCollection>();
new MockCookieCollection(new Dictionary<string, string>() { { "form-field-name", "invalid-value" } }); formCollection.Setup(f => f["form-field-name"]).Returns("invalid-value");
var requestContext = new Mock<HttpRequest>(); var requestContext = new Mock<HttpRequest>();
requestContext.Setup(o => o.GetFormAsync(CancellationToken.None)) requestContext.Setup(o => o.ReadFormAsync(CancellationToken.None))
.Returns(Task.FromResult(formsCollection)); .Returns(Task.FromResult(formCollection.Object));
var mockHttpContext = new Mock<HttpContext>(); var mockHttpContext = new Mock<HttpContext>();
mockHttpContext.Setup(o => o.Request) mockHttpContext.Setup(o => o.Request)
@ -233,10 +232,10 @@ namespace Microsoft.AspNet.Mvc.Core.Test
// Arrange // Arrange
var mockHttpContext = new Mock<HttpContext>(); var mockHttpContext = new Mock<HttpContext>();
var requestContext = new Mock<HttpRequest>(); var requestContext = new Mock<HttpRequest>();
IReadableStringCollection formsCollection = var formCollection = new Mock<IFormCollection>();
new MockCookieCollection(new Dictionary<string, string>() { { "form-field-name", "valid-value" } }); formCollection.Setup(f => f["form-field-name"]).Returns("valid-value");
requestContext.Setup(o => o.GetFormAsync(CancellationToken.None)) requestContext.Setup(o => o.ReadFormAsync(CancellationToken.None))
.Returns(Task.FromResult(formsCollection)); .Returns(Task.FromResult(formCollection.Object));
mockHttpContext.Setup(o => o.Request) mockHttpContext.Setup(o => o.Request)
.Returns(requestContext.Object); .Returns(requestContext.Object);

View File

@ -155,7 +155,7 @@ namespace Microsoft.AspNet.Mvc.FunctionalTests
{ {
var queryString = QueryHelpers.ParseQuery(query); var queryString = QueryHelpers.ParseQuery(query);
return queryString[key]; return queryString[key].FirstOrDefault();
} }
} }
} }

View File

@ -48,9 +48,9 @@ namespace Microsoft.AspNet.Mvc.ModelBinding.Test
private static ValueProviderFactoryContext CreateContext(string contentType) private static ValueProviderFactoryContext CreateContext(string contentType)
{ {
var collection = Mock.Of<IReadableStringCollection>(); var collection = Mock.Of<IFormCollection>();
var request = new Mock<HttpRequest>(); var request = new Mock<HttpRequest>();
request.Setup(f => f.GetFormAsync(CancellationToken.None)).Returns(Task.FromResult(collection)); request.Setup(f => f.ReadFormAsync(CancellationToken.None)).Returns(Task.FromResult(collection));
request.SetupGet(r => r.ContentType).Returns(contentType); request.SetupGet(r => r.ContentType).Returns(contentType);
var context = new Mock<HttpContext>(); var context = new Mock<HttpContext>();

View File

@ -6,7 +6,7 @@ using System.Globalization;
using System.Linq; using System.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNet.Http; using Microsoft.AspNet.Http;
using Microsoft.AspNet.WebUtilities.Collections; using Microsoft.AspNet.PipelineCore.Collections;
using Xunit; using Xunit;
namespace Microsoft.AspNet.Mvc.ModelBinding.Test namespace Microsoft.AspNet.Mvc.ModelBinding.Test