huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Removed builder arg parameter from IStartupFilter 

- It broke the composition model by allowing you to
reach out to the original app builder. This breaks
the ability to properly wrap and have all configure
methods see the wrapper.
This commit is contained in:
David Fowler 2015-08-15 01:25:49 -07:00
parent dfe8c39fe0
commit 52388e89f8
4 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNet.Hosting/Internal/AutoRequestServicesStartupFilter.cs
View File

@ -9,11 +9,11 @@ namespace Microsoft.AspNet.Hosting.Internal
{
public class AutoRequestServicesStartupFilter : IStartupFilter
{
public Action<IApplicationBuilder> Configure(IApplicationBuilder app, Action<IApplicationBuilder> next)
public Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next)
{
return builder =>
{
app.UseMiddleware<RequestServicesContainerMiddleware>();
builder.UseMiddleware<RequestServicesContainerMiddleware>();
next(builder);
};
}

2
src/Microsoft.AspNet.Hosting/Internal/HostingEngine.cs
View File

@ -151,7 +151,7 @@ namespace Microsoft.AspNet.Hosting.Internal
var configure = Startup.ConfigureDelegate;
foreach (var filter in startupFilters)
{
configure = filter.Configure(builder, configure);
configure = filter.Configure(configure);
}
configure(builder);

3
src/Microsoft.AspNet.Hosting/Startup/IStartupFilter.cs
View File

@ -8,7 +8,6 @@ namespace Microsoft.AspNet.Hosting.Startup
{
public interface IStartupFilter
{
// TODO: replace with ConfigureDelegate?
Action<IApplicationBuilder> Configure(IApplicationBuilder app, Action<IApplicationBuilder> next);
Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next);
}
}

4
test/Microsoft.AspNet.TestHost.Tests/TestServerTests.cs
View File

@ -78,11 +78,11 @@ namespace Microsoft.AspNet.TestHost
public class RequestServicesFilter : IStartupFilter
{
public Action<IApplicationBuilder> Configure(IApplicationBuilder app, Action<IApplicationBuilder> next)
public Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next)
{
return builder =>
{
app.UseMiddleware<TestRequestServiceMiddleware>();
builder.UseMiddleware<TestRequestServiceMiddleware>();
next(builder);
};
}