diff --git a/eng/Publishing.props b/eng/Publishing.props
index 0b01250bff..aa5294832a 100644
--- a/eng/Publishing.props
+++ b/eng/Publishing.props
@@ -46,8 +46,8 @@
- false
- NonShipping=true;ShipInstaller=dotnetcli
+ true
+ ShipInstaller=dotnetcli
true
$(_UploadPathRoot)/%(_InstallersToPublish.UploadPathSegment)/$(_PackageVersion)/%(Filename)%(Extension)
diff --git a/eng/Versions.props b/eng/Versions.props
index c356463d50..bafbb18b96 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -10,10 +10,17 @@
1
0
1
+
+
+ false
+ release
+
true
false
- preview$(PreReleasePreviewNumber)
- Preview $(PreReleasePreviewNumber)
+ preview$(PreReleasePreviewNumber)
+ Preview $(PreReleasePreviewNumber)
$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)
false
diff --git a/src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj b/src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj
index f0edb2163b..e86b8cb5ae 100644
--- a/src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj
+++ b/src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj
@@ -15,10 +15,6 @@
<_Parameter1>SharedFxVersion
<_Parameter2>$(SharedFxVersion)
-
- <_Parameter1>TargetingPackVersion
- <_Parameter2>$(TargetingPackVersion)
-
<_Parameter1>TargetRuntimeIdentifier
<_Parameter2>$(TargetRuntimeIdentifier)
@@ -57,11 +53,35 @@
+
+
+
+
+
+
+
+
+
+
<_Parameter1>RepositoryCommit
<_Parameter2>$(SourceRevisionId)
+
+
+ <_Parameter1>RuntimePackageVersion
+ <_Parameter2>@(_RuntimePackageVersionInfo->'%(PackageVersion)')
+
+
+
+ <_Parameter1>TargetingPackVersion
+ <_Parameter2>@(_TargetingPackVersionInfo->'%(PackageVersion)')
+
diff --git a/src/Framework/test/SharedFxTests.cs b/src/Framework/test/SharedFxTests.cs
index 7dcc3920bd..2fc09b96b0 100644
--- a/src/Framework/test/SharedFxTests.cs
+++ b/src/Framework/test/SharedFxTests.cs
@@ -23,7 +23,7 @@ namespace Microsoft.AspNetCore
_output = output;
_expectedTfm = "netcoreapp" + TestData.GetSharedFxVersion().Substring(0, 3);
_expectedRid = TestData.GetSharedFxRuntimeIdentifier();
- _sharedFxRoot = Path.Combine(TestData.GetTestDataValue("SharedFrameworkLayoutRoot"), "shared", "Microsoft.AspNetCore.App", TestData.GetSharedFxVersion());
+ _sharedFxRoot = Path.Combine(TestData.GetTestDataValue("SharedFrameworkLayoutRoot"), "shared", "Microsoft.AspNetCore.App", TestData.GetTestDataValue("RuntimePackageVersion"));
}
[Fact]
@@ -77,7 +77,7 @@ namespace Microsoft.AspNetCore
var target = $".NETCoreApp,Version=v{TestData.GetSharedFxVersion().Substring(0, 3)}/{_expectedRid}";
var ridPackageId = $"Microsoft.AspNetCore.App.Runtime.{_expectedRid}";
- var libraryId = $"{ridPackageId}/{TestData.GetSharedFxVersion()}";
+ var libraryId = $"{ridPackageId}/{TestData.GetTestDataValue("RuntimePackageVersion")}";
AssertEx.FileExists(depsFilePath);
@@ -136,7 +136,7 @@ namespace Microsoft.AspNetCore
var lines = File.ReadAllLines(versionFile);
Assert.Equal(2, lines.Length);
Assert.Equal(TestData.GetRepositoryCommit(), lines[0]);
- Assert.Equal(TestData.GetSharedFxVersion(), lines[1]);
+ Assert.Equal(TestData.GetTestDataValue("RuntimePackageVersion"), lines[1]);
}
}
}
diff --git a/src/Installers/Debian/Directory.Build.props b/src/Installers/Debian/Directory.Build.props
index 9d46b71673..f3d7df1c9e 100644
--- a/src/Installers/Debian/Directory.Build.props
+++ b/src/Installers/Debian/Directory.Build.props
@@ -12,5 +12,9 @@
amd64
$(MSBuildThisFileDirectory)tools/build.sh
+
+
+ true
+ true
diff --git a/src/Installers/Rpm/Directory.Build.props b/src/Installers/Rpm/Directory.Build.props
index d27e528217..09110a30fb 100644
--- a/src/Installers/Rpm/Directory.Build.props
+++ b/src/Installers/Rpm/Directory.Build.props
@@ -4,10 +4,14 @@
-
+
$(IntermediateOutputPath)$(TargetRuntimeIdentifier)\
$(InstallersOutputPath)
+
+
+ true
+ true
diff --git a/src/Installers/Windows/SharedFramework/SharedFramework.wixproj b/src/Installers/Windows/SharedFramework/SharedFramework.wixproj
index df7f9cdcc4..8ec33b0450 100644
--- a/src/Installers/Windows/SharedFramework/SharedFramework.wixproj
+++ b/src/Installers/Windows/SharedFramework/SharedFramework.wixproj
@@ -84,15 +84,21 @@
$(InstallersOutputPath)$(PackageFileName)
+
+
+ <_GeneratedPackageVersion>$(PackageVersion)
+ <_GeneratedPackageVersion
+ Condition="! $(PackageVersion.Contains('$(_PreReleaseLabel)'))">$(PackageVersion)-$(_PreReleaseLabel)$(_BuildNumberLabels)
-
diff --git a/src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec b/src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
index 62d039eede..b5b8c43d9e 100644
--- a/src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
+++ b/src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
@@ -1,9 +1,9 @@
- VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$
+ VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$
1.0.0
- VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$
+ VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$
Microsoft
Microsoft
https://www.microsoft.com/net/dotnet_library_license.htm
diff --git a/src/Installers/Windows/TargetingPack/TargetingPack.wixproj b/src/Installers/Windows/TargetingPack/TargetingPack.wixproj
index 1780b67ecf..d8b2b051af 100644
--- a/src/Installers/Windows/TargetingPack/TargetingPack.wixproj
+++ b/src/Installers/Windows/TargetingPack/TargetingPack.wixproj
@@ -80,15 +80,21 @@
$(InstallersOutputPath)$(PackageFileName)
+
+
+ <_GeneratedPackageVersion>$(PackageVersion)
+ <_GeneratedPackageVersion
+ Condition="! $(PackageVersion.Contains('$(_PreReleaseLabel)'))">$(PackageVersion)-$(_PreReleaseLabel)$(_BuildNumberLabels)
-
diff --git a/src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec b/src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
index 51f4a304e4..d5ef9a2069 100644
--- a/src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
+++ b/src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
@@ -3,7 +3,7 @@
VS.Redist.Common.AspNetCore.TargetingPack.$ARCH$.$MAJOR$.$MINOR$
1.0.0
- VS.Redist.Common.AspNetCore.TargetingPack.$ARCH$.$MAJOR$.$MINOR$
+ VS.Redist.Common.AspNetCore.TargetingPack.$ARCH$.$MAJOR$.$MINOR$
Microsoft
Microsoft
https://www.microsoft.com/net/dotnet_library_license.htm
@@ -15,4 +15,4 @@
-
\ No newline at end of file
+
diff --git a/src/ProjectTemplates/test/Infrastructure/GenerateTestProps.targets b/src/ProjectTemplates/test/Infrastructure/GenerateTestProps.targets
index 1f434c21db..7a821cb2af 100644
--- a/src/ProjectTemplates/test/Infrastructure/GenerateTestProps.targets
+++ b/src/ProjectTemplates/test/Infrastructure/GenerateTestProps.targets
@@ -1,9 +1,22 @@
-
+
+
+
+
+
+
+
+
+
+
+
RestoreAdditionalProjectSources=$([MSBuild]::Escape("$(RestoreAdditionalProjectSources);$(ArtifactsShippingPackagesDir);$(ArtifactsNonShippingPackagesDir)"));
@@ -12,7 +25,8 @@
MicrosoftNETCoreAppRefPackageVersion=$(MicrosoftNETCoreAppRefPackageVersion);
MicrosoftNETCorePlatformsPackageVersion=$(MicrosoftNETCorePlatformsPackageVersion);
MicrosoftNETSdkRazorPackageVersion=$(MicrosoftNETSdkRazorPackageVersion);
- MicrosoftAspNetCoreAppPackageVersion=$(SharedFxVersion);
+ MicrosoftAspNetCoreAppRefPackageVersion=@(_TargetingPackVersionInfo->'%(PackageVersion)');
+ MicrosoftAspNetCoreAppRuntimePackageVersion=@(_RuntimePackageVersionInfo->'%(PackageVersion)');
SupportedRuntimeIdentifiers=$(SupportedRuntimeIdentifiers);
DefaultNetCoreTargetFramework=$(DefaultNetCoreTargetFramework);
diff --git a/src/ProjectTemplates/test/Infrastructure/TemplateTests.props.in b/src/ProjectTemplates/test/Infrastructure/TemplateTests.props.in
index 9935e3cd8b..11b43cc0cb 100644
--- a/src/ProjectTemplates/test/Infrastructure/TemplateTests.props.in
+++ b/src/ProjectTemplates/test/Infrastructure/TemplateTests.props.in
@@ -19,9 +19,9 @@
diff --git a/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj b/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
index e9d418feb8..4ef7283db6 100644
--- a/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
+++ b/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
@@ -24,8 +24,6 @@
-
-
@@ -39,7 +37,25 @@
+
+
+
+
+
+
+
+
+
+
+
+